DPDK patches and discussions
 help / color / mirror / Atom feed
From: Haoqian He <haoqian.he@smartx.com>
To: dev@dpdk.org
Cc: Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbox@nvidia.com>
Subject: [PATCH] vhost: cleanup vq resubmit info when set_inflight_fd
Date: Thu, 21 Mar 2024 05:57:53 -0400	[thread overview]
Message-ID: <20240321095805.923117-1-haoqian.he@smartx.com> (raw)

We should cleanup vq resubmit info when set_inflight_fd
before set_vring_kick which will check if there is any
inflight io waiting for resubmission.

Otherwise, when the vm is rebooting immediately after
reconnecting to the vhost target (inflight io has not
been resubmitted yet), the vhost backend still use the
old resubmit info set when reconnection.

Signed-off-by: Haoqian He <haoqian.he@smartx.com>
---
 lib/vhost/vhost_user.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
index 414192500e..7c54afc5fb 100644
--- a/lib/vhost/vhost_user.c
+++ b/lib/vhost/vhost_user.c
@@ -1871,6 +1871,7 @@ vhost_user_set_inflight_fd(struct virtio_net **pdev,
 		if (!vq)
 			continue;
 
+		cleanup_vq_inflight(dev, vq);
 		if (vq_is_packed(dev)) {
 			vq->inflight_packed = addr;
 			vq->inflight_packed->desc_num = queue_size;
-- 
2.41.0


             reply	other threads:[~2024-03-21 10:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-21  9:57 Haoqian He [this message]
2024-04-03  5:08 ` Haoqian He
2024-04-12  8:10 ` Haoqian He
2024-04-25 13:12 ` Maxime Coquelin
2024-04-26 11:09   ` [PATCH v2] vhost: cleanup resubmit info before inflight setup Haoqian He
2024-04-26 21:28     ` Patrick Robb
2024-05-21  8:55     ` Haoqian He
2024-06-07 13:50     ` Maxime Coquelin
2024-06-12  8:30 ` [PATCH] vhost: cleanup vq resubmit info when set_inflight_fd Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240321095805.923117-1-haoqian.he@smartx.com \
    --to=haoqian.he@smartx.com \
    --cc=chenbox@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).