From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E7D1343D0F; Thu, 21 Mar 2024 19:15:28 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 758A042D90; Thu, 21 Mar 2024 19:15:28 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0C0E842D45 for ; Thu, 21 Mar 2024 19:15:27 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5375220B74C0; Thu, 21 Mar 2024 11:15:26 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5375220B74C0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1711044926; bh=yMrnlNLeLmpJ2N8yIZCCQ3ORRMJWa7NripHvB82CxgE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IKnl21iE0NiIRD9gK0uCstvuoYRJtvSSUj/qMIJCBadpvetbaWbWgJxuhIuzqItdd RxRL8M423f+2YhoNVSXM0g4pPn8aw4077VXh8d7l+h335Fk/FDifsE/9doDQ2sqzm7 Xl8YT+ktQtXKBdtRpywAjjROxz0mMHOA0ZOkBKoA= Date: Thu, 21 Mar 2024 11:15:26 -0700 From: Tyler Retzlaff To: Aaron Conole Cc: dev@dpdk.org, Mattias =?iso-8859-1?Q?R=F6nnblom?= , Morten =?iso-8859-1?Q?Br=F8rup?= , Abdullah Sevincer , Ajit Khaparde , Alok Prasad , Anatoly Burakov , Andrew Rybchenko , Anoob Joseph , Bruce Richardson , Byron Marohn , Chenbo Xia , Chengwen Feng , Ciara Loftus , Ciara Power , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Erik Gabriel Carrillo , Guoyang Zhou , Harman Kalra , Harry van Haaren , Honnappa Nagarahalli , Jakub Grajciar , Jerin Jacob , Jeroen de Borst , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , Joshua Washington , Joyce Kong , Junfeng Guo , Kevin Laatz , Konstantin Ananyev , Liang Ma , Long Li , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nicolas Chautru , Ori Kam , Pavan Nikhilesh , Peter Mccarthy , Rahul Lakkireddy , Reshma Pattan , Rosen Xu , Ruifeng Wang , Rushil Gupta , Sameh Gobriel , Sivaprasad Tummala , Somnath Kotur , Stephen Hemminger , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Tetsuya Mukawa , Vamsi Attunuru , Viacheslav Ovsiienko , Vladimir Medvedkin , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Ziyang Xuan Subject: Re: [PATCH 15/46] net/sfc: use rte stdatomic API Message-ID: <20240321181526.GA13996@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com> <1710967892-7046-16-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Mar 21, 2024 at 02:11:00PM -0400, Aaron Conole wrote: > Tyler Retzlaff writes: > > > Replace the use of gcc builtin __atomic_xxx intrinsics with > > corresponding rte_atomic_xxx optional rte stdatomic API. > > > > Signed-off-by: Tyler Retzlaff > > --- > > drivers/net/sfc/meson.build | 5 ++--- > > drivers/net/sfc/sfc_mae_counter.c | 30 +++++++++++++++--------------- > > drivers/net/sfc/sfc_repr_proxy.c | 8 ++++---- > > drivers/net/sfc/sfc_stats.h | 8 ++++---- > > 4 files changed, 25 insertions(+), 26 deletions(-) > > > > diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build > > index 5adde68..d3603a0 100644 > > --- a/drivers/net/sfc/meson.build > > +++ b/drivers/net/sfc/meson.build > > @@ -47,9 +47,8 @@ int main(void) > > __int128 a = 0; > > __int128 b; > > > > - b = __atomic_load_n(&a, __ATOMIC_RELAXED); > > - __atomic_store(&b, &a, __ATOMIC_RELAXED); > > - __atomic_store_n(&b, a, __ATOMIC_RELAXED); > > + b = rte_atomic_load_explicit(&a, rte_memory_order_relaxed); > > + rte_atomic_store_explicit(&b, a, rte_memory_order_relaxed); > > return 0; > > } > > ''' > > I think this is a case where simple find/replace is a problem. For > example, this is a sample file that the meson build uses to determine if > libatomic is properly installed. However, it is very bare-bones. > > Your change is likely causing a compile error when cc.links happens in > the meson file. That leads to the ABI error. > > If the goal is to remove all the intrinsics, then maybe a better change > would be dropping this libatomic check from here completely. > > WDYT? yeah, actually it wasn't a search replace mistake it was an unintentionally included file where i was experimenting with keeping the test (thought i had reverted it). i shouldn't have added the change to the series thanks for pointing the mistake out and sorry for the noise. appreciate it!