From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id D4A0243DC3;
	Tue,  2 Apr 2024 18:19:25 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A5877402D9;
	Tue,  2 Apr 2024 18:19:25 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 1F2514028C;
 Tue,  2 Apr 2024 18:19:24 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 3294620E8BEE; Tue,  2 Apr 2024 09:19:23 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3294620E8BEE
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1712074763;
 bh=Ur7C5W5/Qk7JH5tkOyh7k8Rr6dnkudd++zE7FfS+YQQ=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Wmj+vXqa/rXB/eqr1KoQ+QOxaGAx4hu9lam5L9m2EwI/SxTJxA8Kt9efzk0Zzvmwn
 1UopWL82gK6xLsJq7e/M1vPYX0/y0/WKOrdRr1OAmDVKkKIcdPmU1K3kPrtJ44lT96
 FyfAop1cqEuKN8Xb1aDtyOY9GSw9XlEsdghstlbc=
Date: Tue, 2 Apr 2024 09:19:23 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Ashish Sadanandan <ashish.sadanandan@gmail.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 nelio.laranjeiro@6wind.com, stable@dpdk.org
Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h
Message-ID: <20240402161923.GA19422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240202051335.776290-1-ashish.sadanandan@gmail.com>
 <20240318024415.555614-1-ashish.sadanandan@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240318024415.555614-1-ashish.sadanandan@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote:
> The header was missing the extern "C" directive which causes name
> mangling of functions by C++ compilers, leading to linker errors
> complaining of undefined references to these functions.
> 
> Also updated the coding style contribution guideline with a new
> "Language Linkage" section stating `extern "C"` block should be added to
> public headers.
> 
> Fixes: 86c743cf9140 ("eal: define generic vector types")
> Cc: nelio.laranjeiro@6wind.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>