From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 90FCD43DC3;
	Tue,  2 Apr 2024 19:19:18 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D6215402E9;
	Tue,  2 Apr 2024 19:19:09 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 85D8D402E2
 for <dev@dpdk.org>; Tue,  2 Apr 2024 19:19:08 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id DE5B5201F162; Tue,  2 Apr 2024 10:19:07 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com DE5B5201F162
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1712078347;
 bh=PbH17b5NQaOQLuQcf0VK8J1DiQEJ7SkvYOtiRm7pvqA=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=LpAp4U8ge1UfxxSPuaV5w4uuIL1ZudhlwxGnhpMSagc5Aaq1CDCvQcKoCDpERlGEy
 MwolnkNgxEltRoEGpsBJvMiOrl4F7Pj8P1vXioeourWDSQx9awr3ZuZASLbzHiGOQ3
 cATwgn201xSCvHN8pnSxmGBM5GP0pJVvSretyDWQ=
Date: Tue, 2 Apr 2024 10:19:07 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, Morten =?iso-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Chengwen Feng <fengchengwen@huawei.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
 Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [PATCH] build: exclude rather than include libs in MSVC build
Message-ID: <20240402171907.GA28745@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1712076948-25853-1-git-send-email-roretzla@linux.microsoft.com>
 <1712076948-25853-2-git-send-email-roretzla@linux.microsoft.com>
 <20240402101550.6e2966ad@hermes.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240402101550.6e2966ad@hermes.local>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Apr 02, 2024 at 10:15:50AM -0700, Stephen Hemminger wrote:
> On Tue,  2 Apr 2024 09:55:48 -0700
> Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> 
> > Some libraries that could be built with MSVC were not being built.
> > 
> > Switch from explicit include to exclude of libs to get immediate CI
> > coverage of libraries that already work with MSVC Windows builds.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> 
> For mbuf, since it requires mempool, you might not need to explicitly
> exclude it. But the change looks good.

interesting, i wonder if the dependency isn't properly working. the way
i chose to exclude libs was to just enable them all and then selectively
disable those that were attempted build but failed. mbuf did not
complain of missing mempool and there was an attempt to build it.

with your changes mempool will build though, just need to wait for it to
merge.

> Acked-by: Stephen Hemminger <stephen@networkplumber.org>