From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 60F0543DF0; Wed, 3 Apr 2024 23:49:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D401402DE; Wed, 3 Apr 2024 23:49:50 +0200 (CEST) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id 050A3402D8 for ; Wed, 3 Apr 2024 23:49:48 +0200 (CEST) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-6e707210ab9so180059a34.2 for ; Wed, 03 Apr 2024 14:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712180988; x=1712785788; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=lcsjW32akbSHvM49+97w6jS/Pf6kW4mH2flI47OLkCc=; b=wtcS8aY/xKc4GjcCa/MEjKmht0HfIT1ufic9YMg3LYPTQWtA3sN7Eod05rImapaOHX GQsNagtrMUMwC7EQSDuoAqSepvrtBQVXXBdEZtxfYjIPVkytsmesURlzr6SA0cpm8H8R XZPZbFvmlXQP62sAhNrPuLr6F45JGJ17S75J7tqwGhKOxQB8ZmghWwMIk0fZ+GF1YKgj 9Zgw3khwT09IjLLfBIDAWKvqxiY8em3DYTS6x9bLJ+Ql2GjMNRheJJetq8aUsa66V/q5 9Imc6SIE1Ag7zm7to6rBlBxdDf1TNt/i0PaNaduTjTs5DuDtTUhuNTrH0Llnbhdsokch ZqQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712180988; x=1712785788; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lcsjW32akbSHvM49+97w6jS/Pf6kW4mH2flI47OLkCc=; b=iRG1g9Yupgf1OAvMr9bu8dH9H3Kx9TX2j/op+bbmY6QJO9r7hIjTLCUnPfmYz3U4n1 Z9QyBqgH6ez7KekkO4GcSkc+3lyLFDw2D6vy+pEJRpHyPbW3swGyyLIwawda1w8uigVo dfajgjrEFP7AEcbXMljWxVm2CfvPTuAcOYxxGtarxH526PAtEbnF5hqPhNMBzSpqQVro owW7gN71QxdJ/lvGXViSGnrfCblfPM/N2tLNPq7qLFFdpgEyuAzdozuiHpg8tgCUvgPi 8qTfkN7BRX5xnUd8oknBtzxurXRAplnoQ4Gzl7KoOI5Pu55/SRmj0H18tC3Z361a/D7p e81Q== X-Gm-Message-State: AOJu0YxcuF0X2GEYzvpkGq1iofdN8atn6r9F0zz7Nny4S23pzsk/RF04 6VteXnLRS8h870SJ2x7y4Fy4pJwfivjfjSSUtB6NXG/xGvrtE1zUy+VL5ahwyc4= X-Google-Smtp-Source: AGHT+IGellnZclRMMMOZN0enNTDrfKpgkLO0hbuB1nt5SD0H8jIhLyHYS3tieyFaCSIjTnDQst6CDw== X-Received: by 2002:a05:6830:1657:b0:6e8:aba7:4b8b with SMTP id h23-20020a056830165700b006e8aba74b8bmr511223otr.34.1712180988182; Wed, 03 Apr 2024 14:49:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id a4-20020a655c84000000b005e838b99c96sm10677243pgt.80.2024.04.03.14.49.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 14:49:47 -0700 (PDT) Date: Wed, 3 Apr 2024 14:49:45 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Ajit Khaparde , Andrew Boyer , Andrew Rybchenko , Bruce Richardson , Chenbo Xia , Chengwen Feng , Dariusz Sosnowski , David Christensen , Hyong Youb Kim , Jerin Jacob , Jie Hai , Jingjing Wu , John Daley , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Nithin Dabilpuram , Ori Kam , Ruifeng Wang , Satha Rao , Somnath Kotur , Suanming Mou , Sunil Kumar Kori , Viacheslav Ovsiienko , Yisen Zhuang , Yuying Zhang , mb@smartsharesystems.com Subject: Re: [PATCH v10 2/4] mbuf: remove rte marker fields Message-ID: <20240403144945.68340962@hermes.local> In-Reply-To: <1712166816-10624-3-git-send-email-roretzla@linux.microsoft.com> References: <1706657173-26166-1-git-send-email-roretzla@linux.microsoft.com> <1712166816-10624-1-git-send-email-roretzla@linux.microsoft.com> <1712166816-10624-3-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 3 Apr 2024 10:53:34 -0700 Tyler Retzlaff wrote: > RTE_MARKER typedefs are a GCC extension unsupported by MSVC. Remove > RTE_MARKER fields from rte_mbuf struct. > > Maintain alignment of fields after removed cacheline1 marker by placing > C11 alignas(RTE_CACHE_LINE_MIN_SIZE). > > Provide new rearm_data and rx_descriptor_fields1 fields in anonymous > unions as single element arrays of with types matching the original > markers to maintain API compatibility. > > This change breaks the API for cacheline{0,1} fields that have been > removed from rte_mbuf but it does not break the ABI, to address the > false positives of the removed (but 0 size fields) provide the minimum > libabigail.abignore for type = rte_mbuf. > > Signed-off-by: Tyler Retzlaff Acked-by: Stephen Hemminger