From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 19AAC43DF1; Thu, 4 Apr 2024 01:38:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DEEB4402D1; Thu, 4 Apr 2024 01:38:50 +0200 (CEST) Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by mails.dpdk.org (Postfix) with ESMTP id 34A414029B for ; Thu, 4 Apr 2024 01:38:49 +0200 (CEST) Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-22ea1b149bcso299605fac.1 for ; Wed, 03 Apr 2024 16:38:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1712187528; x=1712792328; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fQkGMDO6BYY+qguxBJTXuYt6lMr4LjmnE2W+n7Yes6Y=; b=lFkRhh5gQI4rHW2EeXAnbhZ59dorTDa6QOus0lTbm05Y2sUt9aVd9gxiQr8TjhQ2eW wS4F41VePD5GkUVXKGHk9i80g2JCw7LrLUyi5Rw+gKJ1c+vhFAeoczIuQ2nUx/x0ITWp DSusflyT5x39Ru4wQ06sADS0HUwMJaPs0pe9r1fpTMlKDmOnTykSyLdAkqU4SNfrz35h LYH8jv+9pN0OEJl9cH3RFFmwKu8V13TJKLRJZiQC/6JNWjrnfsV5w1NhY21G9gOMMf0E /l1nrcN032O8mXVhuqZhukFm5U6LHdC4HZFwZgTUsR57bfkzkO6/nWwwZODwQQNXVM+C zcSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712187528; x=1712792328; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fQkGMDO6BYY+qguxBJTXuYt6lMr4LjmnE2W+n7Yes6Y=; b=qj/qVY3ldB0l2Wh7wxL09vnkIrT/oLvk4ZJ+rtRLn6kOLI7R6mEk5ZtkjfSPVg5JVB 33gfEWRP7cKp1z3UVlR1XMwDpR69d/jfPjtnoFoMcjkESfHNBeaFVAZq5vVOx6F22Y5a k4sHhOIHTazBoyy3WaaTWPkT964eH9JbgRiMUdwM8YZtrbSw8QwsN1egnl8nv4GCtkE7 HcfokctPTsyL9o29gAIZPO2iHYCk55OHfYqYFPhxzs0wMguCt6q7ca/tAJmdJ/2MDUrS tZunJj+rNYMnArAii6JHw7iFWUotl1aieTpPf6ME+Z1NNc+NUDYXN8L7Tjfc4HhUgMtP LmCQ== X-Forwarded-Encrypted: i=1; AJvYcCXCfrBMmpJapPyzi2U7YulAQNgHaNaS8KwofxHyWUjW4yBqU4AxbAxm/2/cMHxoa4yAwiBdz1JTZk+n4lc= X-Gm-Message-State: AOJu0YwiFq5JbWANtQY/ZoZfp7rYGn6VDvlZjXinCeMCNOPkylya31QF ZBrvijOMjOYXh+wfP8MqRqeui6eoXUTISbGMAS7sM67SRO9tj7DpKj0iC3UfqTc= X-Google-Smtp-Source: AGHT+IERwhdwbDL5uHSuV984U21ihZfY8vCpHP6IYWPl+mJLruCVKajN350ljhyu5XxNcboAkahnHw== X-Received: by 2002:a05:6870:3913:b0:229:fc81:457e with SMTP id b19-20020a056870391300b00229fc81457emr716252oap.55.1712187528420; Wed, 03 Apr 2024 16:38:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id fa12-20020a056a002d0c00b006e6686effd7sm12304531pfb.76.2024.04.03.16.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 03 Apr 2024 16:38:48 -0700 (PDT) Date: Wed, 3 Apr 2024 16:38:46 -0700 From: Stephen Hemminger To: Marek Pazdan Cc: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Subject: Re: [PATCH] lib: add get/set link settings interface Message-ID: <20240403163846.7ed3ff4a@hermes.local> In-Reply-To: References: <20240326235909.25276-1-mpazdan@arista.com> <20240403135953.7209-1-mpazdan@arista.com> <1924573.MyG8hOvIyE@thomas> <20240403102302.6b700690@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 4 Apr 2024 00:08:41 +0200 Marek Pazdan wrote: > I can remove this part (rte_eth_config), but the new API provides other > link information which is not available from the existing API, like > supported/advertising/partner_advertising link modes. > Additionally from what I see, rte_eth_confg is available from > rte_eth_dev_conf_get API and it's copy of requested configuration: > `memcpy(dev_conf, &dev->data->dev_conf, sizeof(struct rte_eth_conf));` Then the new info should go in the rte_eth_config in a future version of DPDK. Having bits in different places makes the API confusing.