From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C80AA43DFC; Thu, 4 Apr 2024 20:47:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D9814068E; Thu, 4 Apr 2024 20:47:51 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0BC9C4064A for ; Thu, 4 Apr 2024 20:47:50 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 1735620E94A3; Thu, 4 Apr 2024 11:47:49 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 1735620E94A3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1712256469; bh=ZDN09RqRD5rjwXzOQyOD647ZAB6LlNmRS7TYO1rcJLg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WfFfs6T2AUAi1Ro+XqakVKBOhD2yLGj5FUG/M+HI/6bjBnKfsaqxg16I1eacfBSwM tweB8z8UdXNpIliDyRRODn7/FkrbRPtaKiEj+xywpUo9kpXx7W17Xi2qZ49IudfUzp rOr0PNcFqoGNJDkbVgtJyB1k+4hF3+/Pb/clSq1w= Date: Thu, 4 Apr 2024 11:47:49 -0700 From: Tyler Retzlaff To: Bruce Richardson Cc: dev@dpdk.org, Harman Kalra Subject: Re: [PATCH v2 2/2] buildtools: when building static library use static deps Message-ID: <20240404184749.GA12913@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710445477-23848-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-1-git-send-email-roretzla@linux.microsoft.com> <1710484222-17310-3-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 15, 2024 at 08:28:55AM +0000, Bruce Richardson wrote: > On Thu, Mar 14, 2024 at 11:30:22PM -0700, Tyler Retzlaff wrote: > > Use static deps when default_library=static and use shared deps when > > using default_library=shared. > > > > Signed-off-by: Tyler Retzlaff > > --- > > buildtools/chkincs/meson.build | 18 +++++++++++++----- > > 1 file changed, 13 insertions(+), 5 deletions(-) > > > > diff --git a/buildtools/chkincs/meson.build b/buildtools/chkincs/meson.build > > index f2dadca..66245a5 100644 > > --- a/buildtools/chkincs/meson.build > > +++ b/buildtools/chkincs/meson.build > > @@ -20,11 +20,19 @@ sources += gen_c_files.process(dpdk_chkinc_headers) > > > > # some driver SDK headers depend on these two buses, which are mandatory in build > > # so we always include them in deps list > > -deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > > -# add the rest of the libs to the dependencies > > -foreach l:dpdk_libs_enabled > > - deps += get_variable('shared_rte_' + l) > > -endforeach > > +if is_shared_enabled > > + deps = [get_variable('shared_rte_bus_vdev'), get_variable('shared_rte_bus_pci')] > > + # add the rest of the libs to the dependencies > > + foreach l:dpdk_libs_enabled > > + deps += get_variable('shared_rte_' + l) > > + endforeach > > +else > > + deps = [get_variable('static_rte_bus_vdev'), get_variable('static_rte_bus_pci')] > > + # add the rest of the libs to the dependencies > > + foreach l:dpdk_libs_enabled > > + deps += get_variable('static_rte_' + l) > > + endforeach > > +endif > > > > Should the deps checks in lib and driver not be similarly conditional? i might need more context about what you think is wrong. i think the problem here was that there are not separate variables for shared_deps vs static_deps. for my changes to lib/meson.build there's already a separate shared_deps and static_deps variables holding the deps that are used with shared_library and static_library respectively. ty