From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F36DB43E06; Fri, 5 Apr 2024 02:55:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8458D4029C; Fri, 5 Apr 2024 02:55:21 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 8B45B4027E for ; Fri, 5 Apr 2024 02:55:19 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id AD0CC20E97D3; Thu, 4 Apr 2024 17:55:18 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AD0CC20E97D3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1712278518; bh=za+SihZxTituXoz+kv5ZVShPzTAGMGbGJMG/gpyM0Ss=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aJlMiPvJf6tc3l+wRunBDkqax/XDCLQo8YTvY8a0p+PZIOZxlyAoo3xEfJFSK/fjI fuOOX5tO0dAD0xRuiv8At8noHHvs8Qf4Ktahm+h83ls/w4YAXx3op3T6j2sHK3lpzB WUz8TC6p8q3F2R3cVIMerWhrJb0+rm7sMSewlS6s= Date: Thu, 4 Apr 2024 17:55:18 -0700 From: Tyler Retzlaff To: David Marchand Cc: Marek Pazdan , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org Subject: Re: [PATCH] lib: add get/set link settings interface Message-ID: <20240405005518.GA27122@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20240326235909.25276-1-mpazdan@arista.com> <20240403134026.7037-1-mpazdan@arista.com> <20240403164937.GA14169@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 04, 2024 at 09:09:40AM +0200, David Marchand wrote: > Hello Tyler, Marek, > > On Wed, Apr 3, 2024 at 6:49 PM Tyler Retzlaff > wrote: > > > > On Wed, Apr 03, 2024 at 06:40:24AM -0700, Marek Pazdan wrote: > > > There are link settings parameters available from PMD drivers level > > > which are currently not exposed to the user via consistent interface. > > > When interface is available for system level those information can > > > be acquired with 'ethtool DEVNAME' (ioctl: ETHTOOL_SLINKSETTINGS/ > > > ETHTOOL_GLINKSETTINGS). There are use cases where > > > physical interface is passthrough to dpdk driver and is not available > > > from system level. Information provided by ioctl carries information > > > useful for link auto negotiation settings among others. > > > > > > Signed-off-by: Marek Pazdan > > > --- > > > diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h > > > index 147257d6a2..66aad925d0 100644 > > > --- a/lib/ethdev/rte_ethdev.h > > > +++ b/lib/ethdev/rte_ethdev.h > > > @@ -335,7 +335,7 @@ struct rte_eth_stats { > > > __extension__ > > > struct __rte_aligned(8) rte_eth_link { /**< aligned for atomic64 read/write */ > > > uint32_t link_speed; /**< RTE_ETH_SPEED_NUM_ */ > > > - uint16_t link_duplex : 1; /**< RTE_ETH_LINK_[HALF/FULL]_DUPLEX */ > > > + uint16_t link_duplex : 2; /**< RTE_ETH_LINK_[HALF/FULL/UNKNOWN]_DUPLEX */ > > > uint16_t link_autoneg : 1; /**< RTE_ETH_LINK_[AUTONEG/FIXED] */ > > > uint16_t link_status : 1; /**< RTE_ETH_LINK_[DOWN/UP] */ > > > }; > > > > this breaks the abi. David does libabigail pick this up i wonder? > > > > Yes, the CI flagged it. > > Looking at the UNH report (in patchwork): > http://mails.dpdk.org/archives/test-report/2024-April/631222.html i'm jealous we don't have libabigail on windows, so helpfull. > > 1 function with some indirect sub-type change: > > [C] 'function int rte_eth_link_get(uint16_t, rte_eth_link*)' at > rte_ethdev.c:2972:1 has some indirect sub-type changes: > parameter 2 of type 'rte_eth_link*' has sub-type changes: > in pointed to type 'struct rte_eth_link' at rte_ethdev.h:336:1: > type size hasn't changed > 2 data member changes: > 'uint16_t link_autoneg' offset changed from 33 to 34 (in bits) (by +1 bits) > 'uint16_t link_status' offset changed from 34 to 35 (in bits) (by +1 bits) > > Error: ABI issue reported for abidiff --suppr > /home-local/jenkins-local/jenkins-agent/workspace/Generic-DPDK-Compile-ABI > at 3/dpdk/devtools/libabigail.abignore --no-added-syms --headers-dir1 > reference/usr/local/include --headers-dir2 > build_install/usr/local/include > reference/usr/local/lib/x86_64-linux-gnu/librte_ethdev.so.24.0 > build_install/usr/local/lib/x86_64-linux-gnu/librte_ethdev.so.24.2 > ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged > this as a potential issue). > > > GHA would have caught it too, but the documentation generation failed > before reaching the ABI check. > http://mails.dpdk.org/archives/test-report/2024-April/631086.html > > > -- > David Marchand