From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3388D43E98; Thu, 18 Apr 2024 02:13:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAC4E402CC; Thu, 18 Apr 2024 02:13:24 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 1246040272 for ; Thu, 18 Apr 2024 02:13:23 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4B5C220FD4C4; Wed, 17 Apr 2024 17:13:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4B5C220FD4C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1713399202; bh=VsYQJKNZw6vyo45o7LC6rXPVdq8UoyMvYhJoGKMwwDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oLnFqPjRU+HUQWCZ0BMuoG3vBPcl+W9io/NZp/j3N/u1N+a6OhlmfAWZFzGmCjHwh UMEzT9w+GmD/vEl4/qwAdX0ivJGPclpSURha/qJm3w4K/7k0+wBtpgtKy7N9Qc335T k8Qu9AbpQALkJN0sRunl1dYpoFzdCnrMFCO1RC8o= Date: Wed, 17 Apr 2024 17:13:22 -0700 From: Tyler Retzlaff To: Stephen Hemminger Cc: dev@dpdk.org, Reshma Pattan Subject: Re: [PATCH v3 4/5] latencystats: fix log messages Message-ID: <20240418001322.GD26881@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <0240408195036.182545-1-stephen@networkplumber.org> <20240417170908.76701-1-stephen@networkplumber.org> <20240417170908.76701-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240417170908.76701-5-stephen@networkplumber.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 17, 2024 at 10:07:26AM -0700, Stephen Hemminger wrote: > All messages that because of an error should be at log level > NOTICE or above. Do not break log messages across lines. > > Signed-off-by: Stephen Hemminger > --- > lib/latencystats/rte_latencystats.c | 30 ++++++++++++++--------------- > 1 file changed, 15 insertions(+), 15 deletions(-) > > diff --git a/lib/latencystats/rte_latencystats.c b/lib/latencystats/rte_latencystats.c > index 11bd0ea4ae..62038a9f5d 100644 > --- a/lib/latencystats/rte_latencystats.c > +++ b/lib/latencystats/rte_latencystats.c > @@ -235,7 +235,7 @@ rte_latencystats_init(uint64_t app_samp_intvl, > latency_stats_index = rte_metrics_reg_names(ptr_strings, > NUM_LATENCY_STATS); > if (latency_stats_index < 0) { > - LATENCY_STATS_LOG(DEBUG, > + LATENCY_STATS_LOG(ERR, > "Failed to register latency stats names"); > return -1; > } > @@ -255,7 +255,7 @@ rte_latencystats_init(uint64_t app_samp_intvl, > > ret = rte_eth_dev_info_get(pid, &dev_info); > if (ret != 0) { > - LATENCY_STATS_LOG(INFO, > + LATENCY_STATS_LOG(NOTICE, > "Error during getting device (port %u) info: %s", nit: the level is notice, but the message says 'Error' same in a couple of other instances below. arguably fine so you can ignore me. > pid, strerror(-ret)); > > @@ -267,18 +267,18 @@ rte_latencystats_init(uint64_t app_samp_intvl, > cbs->cb = rte_eth_add_first_rx_callback(pid, qid, > add_time_stamps, user_cb); > if (!cbs->cb) > - LATENCY_STATS_LOG(INFO, "Failed to " > - "register Rx callback for pid=%d, " > - "qid=%d", pid, qid); > + LATENCY_STATS_LOG(NOTICE, > + "Failed to register Rx callback for pid=%u, qid=%u", > + pid, qid); > } > for (qid = 0; qid < dev_info.nb_tx_queues; qid++) { > cbs = &tx_cbs[pid][qid]; > cbs->cb = rte_eth_add_tx_callback(pid, qid, > calc_latency, user_cb); > if (!cbs->cb) > - LATENCY_STATS_LOG(INFO, "Failed to " > - "register Tx callback for pid=%d, " > - "qid=%d", pid, qid); > + LATENCY_STATS_LOG(NOTICE, > + "Failed to register Tx callback for pid=%u, qid=%u", > + pid, qid); > } > } > return 0; > @@ -299,7 +299,7 @@ rte_latencystats_uninit(void) > > ret = rte_eth_dev_info_get(pid, &dev_info); > if (ret != 0) { > - LATENCY_STATS_LOG(INFO, > + LATENCY_STATS_LOG(NOTICE, > "Error during getting device (port %u) info: %s", > pid, strerror(-ret)); > > @@ -310,17 +310,17 @@ rte_latencystats_uninit(void) > cbs = &rx_cbs[pid][qid]; > ret = rte_eth_remove_rx_callback(pid, qid, cbs->cb); > if (ret) > - LATENCY_STATS_LOG(INFO, "failed to " > - "remove Rx callback for pid=%d, " > - "qid=%d", pid, qid); > + LATENCY_STATS_LOG(NOTICE, > + "Failed to remove Rx callback for pid=%u, qid=%u", > + pid, qid); > } > for (qid = 0; qid < dev_info.nb_tx_queues; qid++) { > cbs = &tx_cbs[pid][qid]; > ret = rte_eth_remove_tx_callback(pid, qid, cbs->cb); > if (ret) > - LATENCY_STATS_LOG(INFO, "failed to " > - "remove Tx callback for pid=%d, " > - "qid=%d", pid, qid); > + LATENCY_STATS_LOG(NOTICE, > + "Failed to remove Tx callback for pid=%u, qid=%u", > + pid, qid); > } > } > > -- Acked-by: Tyler Retzlaff