From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5BBC43EA5; Thu, 18 Apr 2024 17:12:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C396940272; Thu, 18 Apr 2024 17:12:28 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 3DD5940042 for ; Thu, 18 Apr 2024 17:12:27 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 8C37920FD8AD; Thu, 18 Apr 2024 08:12:26 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 8C37920FD8AD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1713453146; bh=8TLsmGuvO/mgrl90WvqxUuiMAUpKk5WT2Z+4BUrEiqo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WPZVaLxiA7/5Dvl8w9C36S1gH46KDF8PaOYtuiBEBfw8sS+RM97YGhK4jfIGQQhdb MnTairfXRs0Vo5J3d0IQaVBCmzAT0EUZhl/DJxR2Q3hGAeJo1r/fSTtt9xGvQJoVNE nXyEypFmeT6at/AdsfA9r4hEDay9Tvgn/u9JR5D8= Date: Thu, 18 Apr 2024 08:12:26 -0700 From: Tyler Retzlaff To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org, Akhil Goyal , Aman Singh , Andrew Rybchenko , Bruce Richardson , Chengwen Feng , Dariusz Sosnowski , Dmitry Kozlyuk , Fan Zhang , Ferruh Yigit , Harry van Haaren , Honnappa Nagarahalli , Jiayu Hu , Jingjing Wu , Kevin Laatz , Konstantin Ananyev , Matan Azrad , Ori Kam , Pallavi Kadam , Reshma Pattan , Sameh Gobriel , Suanming Mou , Thomas Monjalon , Viacheslav Ovsiienko , Vladimir Medvedkin , Volodymyr Fialko , Yipeng Wang , Yuying Zhang Subject: Re: [PATCH 16/16] build: enable vla warnings on Windows built code Message-ID: <20240418151226.GA31175@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1713397319-26135-1-git-send-email-roretzla@linux.microsoft.com> <1713397319-26135-17-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F3B6@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 18, 2024 at 08:48:39AM +0200, Morten Brørup wrote: > > MSVC does not support optional C11 VLAs. When building for Windows > > enable -Wvla so that mingw and clang also fail if a VLA is used. > > Minor detail, doesn't affect my Ack for the series... > > Applications built for Windows with mingw and clang might use VLAs in the application itself. > > Perhaps we should let them continue doing that for now. i guess you mean our examples or if dpdk is configured as a sub-project? for examples i could explicitly suppress in examples with -Wno-vla but that means any that use VLAs could not be built with MSVC. for sub-module and sub-project of dpdk i feel like these add_project_arguments are not imparted on the application with encapsulating project meson setup no? anyone know? Bruce? Stephen? > > > > > Signed-off-by: Tyler Retzlaff > > --- > > config/meson.build | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/config/meson.build b/config/meson.build > > index 8c8b019..9e887f2 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -344,6 +344,10 @@ if cc.get_id() == 'intel' > > warning_flags += '-diag-disable=@0@'.format(i) > > endforeach > > endif > > +# no VLAs in code built on Windows > > +if is_windows > > + warning_flags += '-Wvla' > > +endif > > foreach arg: warning_flags > > if cc.has_argument(arg) > > add_project_arguments(arg, language: 'c') > > -- > > 1.8.3.1 >