From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E80243F05; Thu, 25 Apr 2024 17:07:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C28A402EE; Thu, 25 Apr 2024 17:07:09 +0200 (CEST) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id E3ABA40284 for ; Thu, 25 Apr 2024 17:07:07 +0200 (CEST) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5e8470c1cb7so777544a12.2 for ; Thu, 25 Apr 2024 08:07:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714057627; x=1714662427; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=No4RYJkX9JAJPZYiO9ZvIr/3q7e3qRsZ5jg8LFGWLQc=; b=paQq8ZflxFI9c6udqmThVTDMdv7CKql5D6sxMR1T1k0LfhicrVwmJbcUPzMOdAIzAD 9RWZbznMWamity+tCoJfR1ZWlPM28X7QplDxQNBprm59x7JQGTV1/z3zvGxSKLIljF33 RR6/AYgIjAkRH0tbhNWrCzN3LOb3dmQ2KiEHDRS6WS5ijGDgBKkFcEdCMjwyW2M+SrZA SvfVrPtSbxHmizGCM/Xs3HIR4lNbDP7diFJ+ORUZVZWaT/WWPe6WIRZwv8ZNxb4TzBGL zfjMml3rDk4YZpiudEK0knEVVjKgiLWMkTNLnThkHx14x1MB4Yw3CAyiMAc0RIMXxRG2 lR2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714057627; x=1714662427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=No4RYJkX9JAJPZYiO9ZvIr/3q7e3qRsZ5jg8LFGWLQc=; b=AvnlXZByiX22K0yk3ZBYtzR9PqgKatkeBY1LYryJTdTNeQ8qEmToIPTB412PeSZh+f 24VeQ58aMkiq3s+P5Q9SIsJkIjfi6WJTBLsaWvmrhd/5tFgWGBRa0YX3c8VBb2OCTshZ Qgn4xgYIAXl+0iX4kYSkdR00wx7+bmr4MRYA+EZnvssoRXd1MP21n0vuMTdGNOPiUMk9 by/rA7xzDwyOx9NpfQRS+5wd5jqcTbXVxNhn8ZoOgTxpFOaeQf1lXIOX42KGhCJSWMdR v89b9SzlJkqM0I/lrcOsxMYbN8nClNQiXG02U86RNs/cnqEoTbub0LuO5BIQvb8wNaQm dFKg== X-Forwarded-Encrypted: i=1; AJvYcCUKHR5I+3EGoCh4U95jAXY36AIZisd+SvGBEfH5jrwdFIHJhcFXK2x6bvATQHV+0L99F6z2DC+EsNXtSg0= X-Gm-Message-State: AOJu0YweIMSj25EL00gGJcjYfgdgg9vHfKesTeIp3IG7OObUM1Ze9hH4 KPeVeEFGDzQaxAVcbfGDCgvhoxb9mOlFZqzVtqSnHRGraRK6kBAatBAI3ebtN2kVtVFSVeI99yK 7 X-Google-Smtp-Source: AGHT+IFAI14uGdp9jqnDeB3Fca4uOjFstkPVNTeQoU494Wm1q7sRSsM7AzTWrEcnwTzxVlS07l27pQ== X-Received: by 2002:a17:902:ecc4:b0:1e8:418b:7640 with SMTP id a4-20020a170902ecc400b001e8418b7640mr6389788plh.48.1714057627060; Thu, 25 Apr 2024 08:07:07 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id s1-20020a170902a50100b001e0e977f655sm13882846plq.159.2024.04.25.08.07.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 08:07:06 -0700 (PDT) Date: Thu, 25 Apr 2024 08:07:04 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Mattias =?UTF-8?B?UsO2bm5ibG9t?= , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , "John W . Linville" , dev@dpdk.org, Tyler Retzlaff , Honnappa Nagarahalli , Morten =?UTF-8?B?QnLDuHJ1cA==?= Subject: Re: [PATCH] net/af_packet: cache align Rx/Tx structs Message-ID: <20240425080704.2f9162de@hermes.local> In-Reply-To: <2d07603e-e024-45a4-bfb1-c350b08ccdfb@amd.com> References: <20240423090813.94110-1-mattias.ronnblom@ericsson.com> <6f7aabcb-2c12-4cfe-ae9d-73b42bfd4977@amd.com> <63dbb564-61f6-4d9f-9c13-4a21f5e97dc9@lysator.liu.se> <5d2a0887-527a-4948-943c-65f1dfda9328@amd.com> <3b2cf48e-2293-4226-b6cd-5f4dd3969f99@lysator.liu.se> <0ff40e60-926b-44eb-8af5-2e16aff1c336@amd.com> <20240424121330.7547e290@hermes.local> <2371b1a8-bdc5-4184-8491-54e2e3a64211@lysator.liu.se> <20240424165534.2ad8ae0a@hermes.local> <4c0f1625-4387-4870-a60a-dc423885811e@lysator.liu.se> <2d07603e-e024-45a4-bfb1-c350b08ccdfb@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 25 Apr 2024 15:04:27 +0100 Ferruh Yigit wrote: > > Maintaining an offset-since-last-reset for counters is a control plane > > thing, and shouldn't be in PMDs. (If MT-safe reset for SW-managed > > counters are to be expected from the PMDs, we should have some helper > > API to facilitate its efficient & correct-enough implementation.) > > > > statistics reset works for HW devices, instead of removing statics reset > I am for documenting API that it may be not reliable, I can send a patch > for it. > > With above change, we can be more relax on stats update specially for > soft drivers, and can convert atomic_add stats updates to "atomic load + > add + atomic store". > > Does this plan make sense? +1