From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C472843F47; Mon, 29 Apr 2024 18:24:37 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FEDE402A3; Mon, 29 Apr 2024 18:24:37 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id D7F6F4029C for ; Mon, 29 Apr 2024 18:24:35 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2a4b457769eso3873684a91.2 for ; Mon, 29 Apr 2024 09:24:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714407875; x=1715012675; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=fkhemvEXQ4MtRtIUWdy9fW1TVYuREndnCvdl95Igrkg=; b=x9oMbrpGd1yQTfVv2tzsAkl1FZtcpCTis2sBsdcj2bPOFEIAOf360lSOVrYg+Xy3tQ 4NoWe7w+BflhmjYIOfe+lF/VXVWwV7HhaNvBdKltw1kMvwxmGyd6f4KaqupTsKIRh5aJ Bl3ti2UvZfL1E2aK/lp3rBlAqo3A3Q9yKxhnUV5mq0JQ3V+TFwrJy/MLAdZ45Do1HxEE MfXVGdD7lyJMR8NA6PzJSU9unSOoWUX3Ii2VwNugv2WCfAvn1mUkDNpYQ+/8UvFaRmZ/ ASXO74SuMwZn4h3rHwVfxcwAL/mC3RnZ8uaGqbGPvOZkEX93CgfkwEUatMoV4DaR3ZzT 3Bgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714407875; x=1715012675; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fkhemvEXQ4MtRtIUWdy9fW1TVYuREndnCvdl95Igrkg=; b=mhW8mJ3r89xgxJpBMKsCb2N6LQU0quIYkKz1ZCzvq1DnRqAlp8KPjdHX9fmsFHhHvs 6K3IeHUOj7tvJxwEjZGNIjFSlY0IvYrv4fSEiRZtllkoscH7d9LlPRAaJ/Y92ZNRjw86 8Wue9Xh0QgLyEO4tv2QbUJcnhbxrwFDfS4lJi3Y20bY7h6uTupqgGhuQcPO987oFaxSB pqCfab1sSCiyImMPvOuFSkd0CvhIZ0ggvgeBi4aigOvqtofW7kLBetHyXIhKK0lPFd/T 3LFvQNlY/eHWDM99S2KupzEWRCeCd2mN4VRkGhaSIXtOr8lxjjpLJJBjBTGEfct5mR+n mN9A== X-Gm-Message-State: AOJu0Yx9GVUJF1/z3kCq5dBv/HwA+dKa+x+WWuQ4pibPw2WkA6suulON 1JAxskNHOAzjDes+SCEWE/0XymS/yL4XizDIwN1bKqk4m9XrlmGJwhKxLbtei0o= X-Google-Smtp-Source: AGHT+IHeE1qMT6DALUjLO5Fhpfg+38sBcHBWW8XNF1MuCcobIQ86qGjWMjnAV4r2GLysJRIceVDs6w== X-Received: by 2002:a17:90b:5242:b0:2a6:1625:368c with SMTP id sh2-20020a17090b524200b002a61625368cmr94648pjb.6.1714407874819; Mon, 29 Apr 2024 09:24:34 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id az24-20020a17090b029800b0029bacd0f271sm21113550pjb.31.2024.04.29.09.24.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Apr 2024 09:24:34 -0700 (PDT) Date: Mon, 29 Apr 2024 09:24:32 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, david.marchand@redhat.com, Wisam Jaddo , Bruce Richardson , Andrew Rybchenko , Reshma Pattan , Maryam Tahhan , Konstantin Ananyev , Nicolas Chautru , Declan Doherty , Ciara Power , Vladimir Medvedkin , Xiaoyun Li , Ori Kam , Bernard Iremonger Subject: Re: [dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help Message-ID: <20240429092432.5030fcf6@hermes.local> In-Reply-To: <20210405193954.1115838-5-thomas@monjalon.net> References: <20210309233116.1934666-1-thomas@monjalon.net> <20210405193954.1115838-1-thomas@monjalon.net> <20210405193954.1115838-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch appears stuck in limbo. Some comments. On Mon, 5 Apr 2021 21:39:54 +0200 Thomas Monjalon wrote: > diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c > index 019eddb7bd..39d7fd8c69 100644 > --- a/app/test-compress-perf/comp_perf_options_parse.c > +++ b/app/test-compress-perf/comp_perf_options_parse.c > @@ -38,8 +38,8 @@ struct name_id_map { > uint32_t id; > }; > > -static void > -usage(char *progname) > +void > +comp_perf_usage(const char *progname) Why does the hook now need to be a non-static function. Should be possible for the hook to still just be: static void usage(const char *progname); Fits the principle of change as little as possible.