From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id AB66143F4D;
	Tue, 30 Apr 2024 01:15:01 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 4A242402A8;
	Tue, 30 Apr 2024 01:15:01 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 0748140262;
 Tue, 30 Apr 2024 01:14:59 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 4B316210FBC8; Mon, 29 Apr 2024 16:14:58 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4B316210FBC8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1714432498;
 bh=hBudyi2l2uXRsUN0+6cooKOUmtdRyGWLoovhzTP4WVU=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=BOYTAK9mRNnhkJQv9KII9n39ZCU0I/CxqZDQaO6YtIkYQjMCuHwV4BIMi/OolKJD9
 b+vVvYWBJ5UcuXPGI7qp1a9LrtfFBkCL5ji4rZ7LlwT8DPz7zCR7N+bO7W/46alHZO
 YaJ/dDFnP3DcpGK18SwxV01BLK701Nc61RXLKLQ4=
Date: Mon, 29 Apr 2024 16:14:58 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: bugzilla@dpdk.org
Cc: dev@dpdk.org
Subject: Re: [DPDK/core Bug 1425] enable_stdatomic=true breaks C++ on GCC 11
 and earlier
Message-ID: <20240429231458.GB17852@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <bug-1425-3@http.bugs.dpdk.org/>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <bug-1425-3@http.bugs.dpdk.org/>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Mon, Apr 29, 2024 at 06:21:13AM +0000, bugzilla@dpdk.org wrote:
> https://bugs.dpdk.org/show_bug.cgi?id=1425
> 
>             Bug ID: 1425
>            Summary: enable_stdatomic=true breaks C++  on GCC 11 and
>                     earlier
>            Product: DPDK
>            Version: 23.11
>           Hardware: All
>                 OS: Linux
>             Status: UNCONFIRMED
>           Severity: normal
>           Priority: Normal
>          Component: core
>           Assignee: dev@dpdk.org
>           Reporter: mattias.ronnblom@ericsson.com
>   Target Milestone: ---
> 
> On GCC 11 and earlier, configuring enable_stdatomic=true prevents the use of
> all DPDK header files that directly or indirectly include <rte_stdatomic.h>
> from a C++ translation unit (e.g., app).
> 
> <rte_stdatomic.h> includes <stdatomic.h>, which in turn is not necessarily
> C++-compatible.

This is known but to add some information.

C++ and enable_stdatomic=true for llvm and gcc are not currently
supported. the combination will remain unsupported for C++ compilers
that do not support -std=c++23 which is the first C++ standard that
requires interoperability with C11 stdatomic.h

When enable_stdatomic=true there are bugs/incorrect usages of atomic
qualifier in casts that (even when using C++23) cause compilation
failure. These are a fixable but are low priority without -std=c++23.

Finally, the legacy atomics remain unconverted to stdatomic. This will
cause enable_stdatomic=true not to build when using llvm (but not gcc)
because llvm strictly enforces qualification when using atomic generics.

> 
> -- 
> You are receiving this mail because:
> You are the assignee for the bug.