DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Simon Jones <batmanustc@gmail.com>
Cc: dev@dpdk.org
Subject: Re: [bugfix] set same mac of bond slave
Date: Tue, 30 Apr 2024 08:55:39 -0700	[thread overview]
Message-ID: <20240430085539.41e20d9a@hermes.local> (raw)
In-Reply-To: <CAOE=1Z1+oQmrofXh7t4fEzCNL_DrHO8iYZ7r2TKym56cyJoA=A@mail.gmail.com>

On Tue, 30 Apr 2024 09:17:30 +0800
Simon Jones <batmanustc@gmail.com> wrote:

> +               for (i = 0; i < internals->slave_count; i++) {
> +                       if (rte_eth_dev_default_mac_addr_set(
> +                                       internals->slaves[i].port_id,
> +                                       bonded_eth_dev->data->mac_addrs)) {
> +                               RTE_BOND_LOG(ERR, "Failed to update port Id
> %d MAC address",
> +
> internals->slaves[i].port_id);
> +                               return -1;
> +                       }
> +               }
>                 bond_mode_8023ad_mac_address_update(bonding_eth_dev);

This patch looks wrong. If you read bond_mode_8023ad_mac_address_update() it
expects each member to have different address.

Other modes, already set all members of the bond to have the same mac address.

      parent reply	other threads:[~2024-04-30 15:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-30  1:17 Simon Jones
2024-04-30  3:37 ` Stephen Hemminger
2024-04-30  6:37   ` Simon Jones
2024-04-30 15:55 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240430085539.41e20d9a@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=batmanustc@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).