From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33D8E43F2D; Tue, 30 Apr 2024 17:55:44 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AE5E94025C; Tue, 30 Apr 2024 17:55:43 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id C3DE4400EF for ; Tue, 30 Apr 2024 17:55:42 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6ecec796323so5600018b3a.3 for ; Tue, 30 Apr 2024 08:55:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714492542; x=1715097342; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7jnMs+oJsnEibmCxlZbduAWll5BA2B7Sbw5pOPVnstQ=; b=GyPYTql31MHZPCdIagCV/Wtd7nMNHsZJXNJxztkI/t3r2TurQvaekVaadslKqM9UIw lmtTnA7GDQY3c7EtGBOL4eArcvydLr+C79b6ajnphsZimPlABRt+Ys0pT5O9F+3aFPAu gPy4xDnLILGwhczDhr4ieGlWTTN4nAMLQLrzlDsOcgaOGCjo3f+G6fqwOgtfNQXaltrP AIUtIAczwVLg0DhIQ/jlALJYgoo8A//d3pbLkkdjnwsOMnZ5s6HDBOwbPP4uoD1fi18F FG5Ii1K4S4paLtfPfpILQFs8MOrV/ppSCCdDDfR0dSFOLBwQP6CcmxnJ7wVi1aQeGoDy rNLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714492542; x=1715097342; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7jnMs+oJsnEibmCxlZbduAWll5BA2B7Sbw5pOPVnstQ=; b=CjNHoZ5MO/5Gwafk4VtFy9aTND/7LKlyXPgBB+BE7nfcC3m7bvvdaDrEYtzciEpJ6x gAgGYDXL0CVZjzkGpiOYYUYlnXTJvetqKTfbCD9oZQJNiX3Vhh3MtpUGEIeHmLRztnwL AZTig9t9Dxn663b949MGawwyLAd0LXdZtfyNXpMlRISh3rchXhRLbRDt9Qf9XnzjBt5l Ovygm5mca1UjNZPnNmfup5MVqA8EAyfEGDIn8pZyHlDoWxgzPewkRil6daOciOZqJca4 QTC40jJRrlEW5nhEQoT16ZW+7nNPYcEVmkMY/M/09LKIC9gM97JAG1zTe4FgmMNuLSYN 63mQ== X-Gm-Message-State: AOJu0Yx2S+e2l91V3k9Q6mowOxrWOjgmBSaZEOznaOprTDnqGaxvJzqG 8Lt9zsNlM+cNmM+1+ibWWo0Y06vXfOwYQrl4TvEJjsUTUdMwlL6TP7z/eAC+WVuPW5cpJWqwsTD T X-Google-Smtp-Source: AGHT+IGIt20xeBWE4U4/DL4FZPkJE98bJiKTqZPblhbuS7D1wILhnWnPdQdx50otNRDsO6M9kCPJfQ== X-Received: by 2002:a05:6a00:4655:b0:6ea:dfbf:13d4 with SMTP id kp21-20020a056a00465500b006eadfbf13d4mr58890pfb.18.1714492541027; Tue, 30 Apr 2024 08:55:41 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id a1-20020aa780c1000000b006f3e7dc6416sm6917166pfn.10.2024.04.30.08.55.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Apr 2024 08:55:40 -0700 (PDT) Date: Tue, 30 Apr 2024 08:55:39 -0700 From: Stephen Hemminger To: Simon Jones Cc: dev@dpdk.org Subject: Re: [bugfix] set same mac of bond slave Message-ID: <20240430085539.41e20d9a@hermes.local> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 30 Apr 2024 09:17:30 +0800 Simon Jones wrote: > + for (i = 0; i < internals->slave_count; i++) { > + if (rte_eth_dev_default_mac_addr_set( > + internals->slaves[i].port_id, > + bonded_eth_dev->data->mac_addrs)) { > + RTE_BOND_LOG(ERR, "Failed to update port Id > %d MAC address", > + > internals->slaves[i].port_id); > + return -1; > + } > + } > bond_mode_8023ad_mac_address_update(bonding_eth_dev); This patch looks wrong. If you read bond_mode_8023ad_mac_address_update() it expects each member to have different address. Other modes, already set all members of the bond to have the same mac address.