From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7278843F54; Tue, 30 Apr 2024 14:19:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1A6C40647; Tue, 30 Apr 2024 14:18:42 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2059.outbound.protection.outlook.com [40.107.22.59]) by mails.dpdk.org (Postfix) with ESMTP id B8D3F402D0 for ; Tue, 30 Apr 2024 14:18:37 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Hv4btXIoQtR2t4ZFn0xpAjIQmQjK4TpxW6afuht3AkLmqO5yY/PG0v0NYgRrDyxupmf6QBYkrWCTZyN/lpYKZkvD0ojSR15uwg92Xi9OOsJatvHM8pJKAF4Sp8zApFZbt5Mt0/decJwNwkWdZ6iHVKS9zfxPDixvcdayCW89UZY75R5/UMIbsuH1ErbpBQBoB6lUJ8j+DqwKYgWvVbDPtXvOMjyM3CMxh2CglJ6G+0UDTb2mpZXeIIKaBvpdX7cKTPWR9JUxwN+XIRnIHAII/z+FEVu8NLrmSX3fFvkYPTvv6Yag6Ux26mwrz71P8Ml1PO3YgcJXI60Nl7NMCJeiFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e0pAQkBnxXs/zgu1ed9S6pjaTi/5suWW5BywutRHSF8=; b=UqPtzw4hOAk0o0Wn/T7Aw+0d7XrvMuh0mqpTYqI6WH4PQWyImm3KlckICRp3GZFg2wOUCMewK81QXF1mjcZ8ewkzHLvNDEX65F7MsYm/9Wg+kLlZa6miNykwVLl0OiwTRIoeR1GmNOtoIzNJ2p36hyMPZOSFwzMBaxRVZExPsniAQi+Zv2wBJDQFPIugjVep+tdoFSO2sz73p0vn5v7gcBw6Tcbb1TwJAA93irGaQAbfltuUewklIzk4QFH6iCKZ6oafvlrEnii8pMbzZEV9R3tCKDdxurDskVjygF/i9JcSRLR1qy5jsz62GXXl0OY9MnKgSHiuL44nhqWFjPv2UA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e0pAQkBnxXs/zgu1ed9S6pjaTi/5suWW5BywutRHSF8=; b=uKPqqQ/auYffmSypEmCYwQs/dMW1Lna0zrRiF4Zwy3RakGwzKqrb5aL9j1K+AyC3n84B6JqcWJnYiQzIqKemzmq/GUrbN40tHhgDkPU/hSyZr85EC1kn8z8+2hgcw8G+kpf+VKyL4anTYe35VDjdGgUYBQcXRWz7B68Qdi6zJSMQrOcJatwO6j9BCv9TX82UiPAR9IUf6UhLIMGiz7POUa+rz3TfXQtVw5/BzPEgsuTKl+jYmSNw5vl2XrpaY7b/a9gu5SU5nK3CA3OtF8TXho88yXxFmP6YUyA3xYYEmK/9D0DSek54c02XG698weyI4KXajVbXOHuE6EHwl2upiw== Received: from AM9P193CA0015.EURP193.PROD.OUTLOOK.COM (2603:10a6:20b:21e::20) by AS8PR07MB7589.eurprd07.prod.outlook.com (2603:10a6:20b:2af::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.35; Tue, 30 Apr 2024 12:18:34 +0000 Received: from AM3PEPF0000A799.eurprd04.prod.outlook.com (2603:10a6:20b:21e:cafe::49) by AM9P193CA0015.outlook.office365.com (2603:10a6:20b:21e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34 via Frontend Transport; Tue, 30 Apr 2024 12:18:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AM3PEPF0000A799.mail.protection.outlook.com (10.167.16.104) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.18 via Frontend Transport; Tue, 30 Apr 2024 12:18:33 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server id 15.2.1544.9; Tue, 30 Apr 2024 14:18:33 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 7A3EB380061; Tue, 30 Apr 2024 14:18:33 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [RFC v5 6/6] eal: add unit tests for atomic bit access functions Date: Tue, 30 Apr 2024 14:08:10 +0200 Message-ID: <20240430120810.108928-7-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240430120810.108928-1-mattias.ronnblom@ericsson.com> References: <20240430095523.108688-2-mattias.ronnblom@ericsson.com> <20240430120810.108928-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM3PEPF0000A799:EE_|AS8PR07MB7589:EE_ X-MS-Office365-Filtering-Correlation-Id: 7a4bfe8a-3984-4c6b-9637-08dc690fa7cd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400014|1800799015|376005|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?B?MFhja1VNTnYvc0JObEtYMDhpSm1kY2dzTlZPbUxaS2lFbGpDa3lUZG5JUzBB?= =?utf-8?B?QjZVVklGS2tNQWh5NFZvdm45UlBKdXcxSnA1S3BtUmtxa2ZubWJtQnlCdEhU?= =?utf-8?B?cGNiU205MnNvK3gyTlRDUkJ5WXBJM2ZQRE9LS2NtNXpkTkE3eEZNTlZXVVZJ?= =?utf-8?B?dnhXdHZUMnl0YzhBaFdjMStqeUJqODBSc2NjUG1Ed1BuNzR3Z0hHb1lmUkxY?= =?utf-8?B?bTBGQlArRkVFQ0s5V2VEbkV0Q3V4OGo5VUJlNlZyMDE3Q0NJT1piOVgyUjN0?= =?utf-8?B?RzRyZmh4ZmZYdkNTdHQ0KzdUMU9EZmZuZzlvZ0w1M1lhMnpBMUliMVphaHRJ?= =?utf-8?B?YzRYMndJdzVPdWQ2azhFZTdPL3VNRzE3SDc2K0lDT0NyQzdNc2ViNzZaWmhI?= =?utf-8?B?S3JtMlc0dldsU2NOQ1lFMkk4YThUaGlBaFkxVWQyV1VtYzhkczZRQ2dmZytq?= =?utf-8?B?eTdVZ0lSdmNtQzlTeUFKTTBZbHM2K2EyZGNjVGZkTDRtblRER3ZXdmpvUVFT?= =?utf-8?B?NjJScnNjUFcrNm05K05IK0NIQXJBK0JRS3N0NnZMaUxhYXZ6dUN4enBwdEJ3?= =?utf-8?B?MUd5Q2VrNEpnaFh1V2NRV1hhT3pFU3ljVjJKVVFTOFVqdDY2VTJOUGo3Nzhx?= =?utf-8?B?ZG0wd3lNbGord01uSVQxaUZPVS9GUFpCMHVkclFEOWdRSlA2c3FidmVkK2ZV?= =?utf-8?B?R3RZVktsT2oyMnhWUi9Ta0lUZitKWWJzREZJT1RhSkJrbzZmdlB5UlVET0NB?= =?utf-8?B?Y2ovZHFFM2RnQ1lNSDRldGd5QkFhSnVUTmtZRE1wY0p3RGxFR1piRnc1MmM1?= =?utf-8?B?WTQvalFIaWJHY3JJWWhLWUozZEZ6Ti8vMFllNFloaldRWU9GOWJRMC9tNlVi?= =?utf-8?B?MDRnMGVNZjA1OHVXSW4ySkg1M2k2V0l5T2ZwYlhsUmNlOWFaTGxBblVoVHpD?= =?utf-8?B?Q2p1VXZtTktKbkZPT3hRNzgydEhlMmxDYjBQS3ZzSnhXT1pvRlpaSnFwNVE2?= =?utf-8?B?eVdaV3BFakRLTVdHblhVQ0xGeVBTakNjSk1JbFJZb1ZWbVk2NzIyV3BFWi9a?= =?utf-8?B?M0pYNFNJamV1Z3Z5Y1N1MHZKSHBrby9Ub21BSTBNelpQMHFNL2k5U3ZHMGFD?= =?utf-8?B?eC96dGVISVZ5RThwRXVjU0dTNW5nclFTdThnK2QzTVJVN2pLM20vdUpwR29K?= =?utf-8?B?QnpJaE5CbDh6QVlVWW1nMTZZS0ZWd3h3d3F5ck5EVTdoWlBoYytRSFdwNUkz?= =?utf-8?B?UlMxaW13ZFZ4UFNQeVljdUFjc3Fyc3d4aUFxUkJMV1R4Ujh2dEFKT1NncGU0?= =?utf-8?B?bWx3b3N5K1J4MytPK0FBeFZoN2dUSGduTXFkejB1dGZwV2NFSngyOUZuZURJ?= =?utf-8?B?Wll4bzhYNGwrU3ZDTU1jRCszWWxVS3lYa2RJREpYdmxOTjVKNmJ6NUJkalRL?= =?utf-8?B?K3BwdWxuMFRpOHBWOG9zTjlKc1VMVEw4VUI4TzY5THcwcENBbjYycm40eXpi?= =?utf-8?B?bzZaYm8rVTEwNGdzS2tlOC80L0dRdEcrdisrdHh2MnFSajhUNWxlYkhqNzF1?= =?utf-8?B?bVhhaXNiRnpwaHlkTU1tNCs3VnFSRGZWZUIvV2lYSythVjFhTkVwVVBmM09K?= =?utf-8?B?Qmt3bnowejlvT296MTNMUEZqSm5HamdWZGxQK3hBOE1lVmtqT1RWVXJTVzVq?= =?utf-8?B?RXhlZVR0UGMwRDlLTmVQTTJIaElWaVF1dVZTZzZaTkt6bGdhYzFtd1hEdzN0?= =?utf-8?B?NVUrRFhnSzcyRWY0dUZUbTNWR0x6ckllTlJ3R1pxOEx3L0J6SjBrRGN2Myth?= =?utf-8?B?RDAzaHpiRUtQOTNySTVxZUxMUlpMSVlFK3hqQ2ZvUnBhR09ZKzM1Ri92bTVu?= =?utf-8?Q?UbDkEoLQ2ZP3I?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(82310400014)(1800799015)(376005)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2024 12:18:33.9993 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7a4bfe8a-3984-4c6b-9637-08dc690fa7cd X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A799.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7589 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_[set|clear|assign|test|test_and_[set|clear|assign]]() family of functions. RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- app/test/test_bitops.c | 315 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 314 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 615ec6e563..abc07e8caf 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -64,6 +67,304 @@ GEN_TEST_BIT_ACCESS(test_bit_once_access64, rte_bit_once_set, rte_bit_once_clear, rte_bit_once_assign, rte_bit_once_flip, rte_bit_once_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -182,6 +483,18 @@ static struct unit_test_suite test_suite = { TEST_CASE(test_bit_access64), TEST_CASE(test_bit_once_access32), TEST_CASE(test_bit_once_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_once_access32), + TEST_CASE(test_bit_once_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1