From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: "Mattias Rönnblom" <hofors@lysator.liu.se>,
"dev@dpdk.org" <dev@dpdk.org>,
"Mattias Rönnblom" <mattias.ronnblom@ericsson.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: Run unit tests with C++ too
Date: Tue, 30 Apr 2024 11:01:09 -0700 [thread overview]
Message-ID: <20240430180109.GA18251@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJvnSUDwS8TpOKhnmKZKwsdyDDGw=K4rK_61QZEuUgjYdNAUTw@mail.gmail.com>
On Tue, Apr 30, 2024 at 09:52:05AM -0400, Patrick Robb wrote:
> On Sun, Apr 28, 2024 at 3:46 AM Mattias Rönnblom <hofors@lysator.liu.se>
> wrote:
>
> > It would be great if the unit test suite (app/test/*) was compiled (and
> > run) using a C++ (C++11) compiler as well. At least, if such is available.
> >
>
> Sure, the UNH Lab can try this.
>
>
> >
> > With the current state of affairs, header file macros or functions are
> > not verified to be functional (or even valid) C++.
> >
> > "C is a subset of C++", which was never true, is becoming less and less so.
> >
> > If all unit tests aren't valid C++, maybe one could start with an "opt
> > in" model.
> >
>
> Okay, so basically run the fast-test suite, record all that don't pass,
> submit a bugzilla ticket stating which unit tests are not valid on a
> certain c++ compiler, then bring CI Testing online using the valid subset
> of fast-tests. This should work.
this seems like a reasonable approach.
>
>
> >
> > A drawback of this is that the unit tests need to be both valid C and
> > valid C++.
> >
next prev parent reply other threads:[~2024-04-30 18:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-28 7:46 Mattias Rönnblom
2024-04-29 8:01 ` Ferruh Yigit
2024-04-29 22:49 ` Tyler Retzlaff
2024-04-30 13:52 ` Patrick Robb
2024-04-30 18:01 ` Tyler Retzlaff [this message]
2024-04-30 20:13 ` Mattias Rönnblom
2024-04-30 20:57 ` Patrick Robb
2024-05-01 9:10 ` Ferruh Yigit
2024-05-01 10:15 ` Bruce Richardson
2024-05-01 14:14 ` Mattias Rönnblom
2024-05-01 14:38 ` Ferruh Yigit
2024-05-01 14:45 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430180109.GA18251@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=hofors@lysator.liu.se \
--cc=mattias.ronnblom@ericsson.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).