From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F7A943F5D; Wed, 1 May 2024 18:42:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2DBEE4027F; Wed, 1 May 2024 18:42:13 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id C1AB34021E for ; Wed, 1 May 2024 18:42:11 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6f3e3d789cdso4766968b3a.1 for ; Wed, 01 May 2024 09:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714581731; x=1715186531; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=AueaCzuI4T3n25mXLPzUNBh9Epe3Gtb4e4SK9yFe1Rc=; b=O5w7haTkXTo2vzi9Q/Yf0vzMbTtq5+r/FCtxGZwBYFZF7kFZleYs3mKPpWKCdM8PkV 0vIyhjPW4bFmQ/X95TzH5O0OlMYXUR2U0tXTz+9utovJw9sMKkNlUoZxnjWkworxFQ4U RUh4k1KTXtss3Q3KltnZfLcHRabQLcbxsJ9HO+V2M0wWcKcpJoNIvQBb39/quvUgJYX0 fEtXxHeEGs1UJT7qvWuH19ZzD/nvaKZR3Qph2SWhgdzUMWEUicpx4HO/QWfiCjzJpjgQ aO7ZJvKNOe3VOJTJrWZCCNe5qpooTZGkyVrT4r99/LCWNrL7Xk6Zf2N476XyZz51G6JH Vszg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714581731; x=1715186531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AueaCzuI4T3n25mXLPzUNBh9Epe3Gtb4e4SK9yFe1Rc=; b=ghd4e3gGDqkbc2OhzJUGK/ncjddevVtpvM2DY3vpdUQsaJ9pIPkWwK5qzbkDjqcioi hGeFXYkLNvmUq8OE+MV6VNYMOgAUxCIInTyXYWyaIG+PYgDZmrF8D/SPy7ZTtvEbtEfr tmPAVBvZ1/GOvD8D9RgMethrOfib4pW1g96JsJwWP1pqLdGfJ8J2OlutLb/wgvB0w5Tb EYbCL08F1a9twj8DaeKvZprGnYX4IgOscKP4XyiVWd+9nWHhvcKNUN7BNkeXgn2R4Qbz 9iOwSO4Oo4gm/bwJxbtzF6sIjh2KzW22aNKI+ASFmTdYnXfjfKYfOxumR5/T2w0H11Ne Vm2Q== X-Gm-Message-State: AOJu0YxtECFUwCF0a5r74qbUPcGmwNl80aMRsYwMRyT0zPk9JxsGn2me 1mB6sRhqgHVw/4haA1u0UwCnpkw9kklPeJlp5y0jEIGYviAMKm/qhJFazTkf7hM= X-Google-Smtp-Source: AGHT+IExmsG/qgll3bvxef5MV0rm4uwBObFWc8wjSpeiHeWNTYaFhI5ERJ5t7aBd7Sgw7OzwLECmuw== X-Received: by 2002:a05:6a00:2448:b0:6ec:f712:8a69 with SMTP id d8-20020a056a00244800b006ecf7128a69mr3634353pfj.29.1714581730830; Wed, 01 May 2024 09:42:10 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id l185-20020a6391c2000000b005ffd8019f01sm16993650pge.20.2024.05.01.09.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:42:10 -0700 (PDT) Date: Wed, 1 May 2024 09:42:08 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, "John W. Linville" , Mattias =?UTF-8?B?UsO2bm5ibG9t?= Subject: Re: [PATCH] net/af_packet: fix statistics Message-ID: <20240501094208.5f9e4cf9@hermes.local> In-Reply-To: <9025199c-585c-4779-9f4e-360845707088@amd.com> References: <20240430154129.7347-1-stephen@networkplumber.org> <9025199c-585c-4779-9f4e-360845707088@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 1 May 2024 17:25:59 +0100 Ferruh Yigit wrote: > On 4/30/2024 4:39 PM, Stephen Hemminger wrote: > > The statistics in af_packet driver do not follow the standard > > practice of other drivers: > > > > - Statistics should be maintained as 64 bit even on 32 bit. > > > > ack > > > - Remove the tx_error counter since it was not correct. > > When transmit ring is full it is not an error and > > the driver correctly returns only the number sent. > > > > nack > Transmit full is not only return case here. > There are actual errors continue to process relying this error calculation. > Also there are error cases like interface down. > Those error cases should be handled individually if we remove this. > I suggest split this change to separate patch. It is possible to get errors, but the code wasn't looking for those. See packet(7) man page.