From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 89FD543F5D; Wed, 1 May 2024 18:44:40 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A891402C7; Wed, 1 May 2024 18:44:40 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 716C74027F for ; Wed, 1 May 2024 18:44:39 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1e50a04c317so38661225ad.1 for ; Wed, 01 May 2024 09:44:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714581878; x=1715186678; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1mbcjFmifsk/4RizH58rQnPB5WSyq4aEYkWM5Ht6pKk=; b=EvjRULyxWCGC6E8z3kf0TZnNqH8pPBHt8QPjxOSvGZApA1M1nLF7pQeO+MO9QXYKKW 0AlibE0PVag5P0DjrbtYX3UyS9wFOtdc42tdv2tGUWc8B5sDtCxZYEKLyx2p3p6pMxBP wE4fMlJSWRSsxDtIYGRYLmpwausNKwhLy1oy2OLPcvkptxz5yxDNV92EwUrAtT0/q/LZ c5JQm4069SxabJgd2vaoFVyGEGT73vbKP/eTpXJRLK/74Iwgg+dfe1gpiSEhG4GXzV6u M0eiteX6WsAceE4K23oZ35mzt2t0GjFtU3rNbLNayWhhzf7HYoDAEWxuSunVQCztaCvn YD0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714581878; x=1715186678; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1mbcjFmifsk/4RizH58rQnPB5WSyq4aEYkWM5Ht6pKk=; b=GSjnYAGbF6DEdRIjEynvwliYrUa3Y/njUvC+mDxwBzjy3WY9YJoMX3Fgw3FjNgmFnt CBSA54fey4/9w/v7XgyFJW3xgYWCHEwBl1ylt+Et6rkE59yBX4U39+G8z2mu4YWm8zEp BYFB+YYwClwECGFeHuU7ybED9RuSyDzwz6eWkEzDR/CwyEOluTSKTZeXsaOBB1Hev43S /VpRvngmWm0M7tL4H0EPfZoQIPdYeiYdEpBGkdAZG3LyyG8hGDnmhzA65xoJs4OmkCeS 0u4cLILuWw6LW4tuqn9HZNvR5XFRwl+aYtRokMGMXo+i7uMDwSVeLUoIpi6y/CHd1iiY a+pA== X-Gm-Message-State: AOJu0Yy9jUzqVh5j5NlpgUaN0+B9d0Zk3Kcw+YlwuRRbKVneE+drbJ+P iPNKETX6EbYuskbZiT/IMw9W+tBr/WeTb/C8aA1NBDT3Va6CkHkRr2bPr92JK5I= X-Google-Smtp-Source: AGHT+IG8TUx7zQd75fVwSzdkWG0bEt4xJrusb5PQg/ZoYA9RFhMOAuAoj7I6PAIaCgjpcBTuR6SJpw== X-Received: by 2002:a17:903:2408:b0:1ec:bc3e:84a3 with SMTP id e8-20020a170903240800b001ecbc3e84a3mr1556513plo.14.1714581878472; Wed, 01 May 2024 09:44:38 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id m6-20020a1709026bc600b001e99ffdbe56sm18449176plt.215.2024.05.01.09.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:44:38 -0700 (PDT) Date: Wed, 1 May 2024 09:44:36 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org, "John W. Linville" , Mattias =?UTF-8?B?UsO2bm5ibG9t?= Subject: Re: [PATCH] net/af_packet: fix statistics Message-ID: <20240501094436.17ac8f00@hermes.local> In-Reply-To: <9025199c-585c-4779-9f4e-360845707088@amd.com> References: <20240430154129.7347-1-stephen@networkplumber.org> <9025199c-585c-4779-9f4e-360845707088@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 1 May 2024 17:25:59 +0100 Ferruh Yigit wrote: > > - Remove the tx_error counter since it was not correct. > > When transmit ring is full it is not an error and > > the driver correctly returns only the number sent. > > > > nack > Transmit full is not only return case here. > There are actual errors continue to process relying this error calculation. > Also there are error cases like interface down. > Those error cases should be handled individually if we remove this. > I suggest split this change to separate patch. I see multiple drivers have copy/pasted same code and consider transmit full as an error. It is not. There should be a new statistic at ethdev layer that does record transmit full, and make it across all drivers, but that would have to wait for ABI change.