From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5147E43F5D; Wed, 1 May 2024 18:14:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 64463402A7; Wed, 1 May 2024 18:14:18 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 8A1934021E for ; Wed, 1 May 2024 18:14:15 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2b2b02d4148so1364904a91.1 for ; Wed, 01 May 2024 09:14:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714580055; x=1715184855; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=CoE/dU6vV4CmXZmPgQ/EkR/QzMzhJPdFBrMY+SZoaa43hyk+sp1DQOyoPDEblPOdv6 jd4FmHDLDUIiHe47rKzm/ZjXfk8FnHFoZbdgQ8BU6mahn4D//hZpweLJpXwmPWRzN6k1 MJBbsa0GlJlVCZrnrmvB9MnL42QMis8WwGNnLJiu398rL/sj6F7xfOsQ9MfmLYavzOt8 IbfAJ6nAoRA2Jf2XLpfPOzCfc2/6Lxwhxxfyouo62Z07z2Vst93lP/n8DsOKFhV/gn3m A201ZRgAuNBiBQQoFHrIfEKtgjgWA12mcjYj3RFSz0xPQSmvDdnjFmjtsPTnmfAFGHSp xpMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714580055; x=1715184855; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=wCBNFdIihcZbZaV+gtVCJ6kU0sBl838vs9udTfmzaGU8z3D49YadPCGYmMXe/WgQwt B5HVXMVNBd/rRXaeysqoqSCKlEIfo+1EvnhmisHURslcCbIGuxMHnT+ckSV6aK6FEd4Y 3pgd/oPt4QhmGVF/bkR7rx76AXExO442Kf0dJ21r66BiOKJLs9BloI8Bj0u/x8q4flTm eC+n61SwA/6C/D4/bM/dBq7HhIeFmtUt/0xxD+YWLafrfKRFTACX9g7AAswVER4RVEmR QqHjpZdqQX23NhEDAQRZ50qhWDLUoCAwNoNy76kpEnwqSmZJG9cTxMmisEmT73P02LBE MDgg== X-Gm-Message-State: AOJu0Yxq8PyicOmVgZh8+rpg0EHZOXGsVG0ZeGOQwwpc3Dosy++WjETo lni4bgnNPoYQBtUIh9x0ImwdBiJ9mNSQ6azeV9gSHLJhOAyOV7gXhmipPF1dJKJyTh1w0ogF8q5 IayA= X-Google-Smtp-Source: AGHT+IGuGvTM/FigNTHSGC5+VKlU2mZpRf0TlbgmnsIatV+9r9rMyP9VPJKDfYMrqR+jOOTb+UZ0xg== X-Received: by 2002:a17:90a:f498:b0:2ac:8099:ec66 with SMTP id bx24-20020a17090af49800b002ac8099ec66mr2861857pjb.30.1714580054696; Wed, 01 May 2024 09:14:14 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id ee6-20020a17090afc4600b002b328adc4b9sm1382447pjb.42.2024.05.01.09.14.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 May 2024 09:14:14 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v10 2/9] net/tap: remove unused fields Date: Wed, 1 May 2024 09:12:01 -0700 Message-ID: <20240501161403.114658-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240501161403.114658-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240501161403.114658-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c | 1 - drivers/net/tap/tap_rss.h | 6 ------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h index dc8201020b..1bcf92ce80 100644 --- a/drivers/net/tap/rte_eth_tap.h +++ b/drivers/net/tap/rte_eth_tap.h @@ -77,14 +77,12 @@ struct pmd_internals { int ioctl_sock; /* socket for ioctl calls */ int nlsk_fd; /* Netlink socket fd */ int flow_isolate; /* 1 if flow isolation is enabled */ - int flower_support; /* 1 if kernel supports, else 0 */ - int flower_vlan_support; /* 1 if kernel supports, else 0 */ int rss_enabled; /* 1 if RSS is enabled, else 0 */ int persist; /* 1 if keep link up, else 0 */ /* implicit rules set when RSS is enabled */ int map_fd; /* BPF RSS map fd */ int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */ - LIST_HEAD(tap_rss_flows, rte_flow) rss_flows; + LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */ /* implicit rte_flow rules set when a remote device is active */ LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a78fd50cd4..8fccd599f0 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd, errno, strerror(errno)); return err; } - LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next); } pmd->rss_enabled = 1; diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..8766ffc244 100644 --- a/drivers/net/tap/tap_rss.h +++ b/drivers/net/tap/tap_rss.h @@ -21,12 +21,6 @@ enum hash_field { HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */ HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */ HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */ - HASH_FIELD_L2_SRC, /* Ethernet src addr */ - HASH_FIELD_L2_DST, /* Ethernet dst addr */ - HASH_FIELD_L3_SRC, /* L3 src addr */ - HASH_FIELD_L3_DST, /* L3 dst addr */ - HASH_FIELD_L4_SRC, /* TCP/UDP src ports */ - HASH_FIELD_L4_DST, /* TCP/UDP dst ports */ }; struct rss_key { -- 2.43.0