From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F04A43F65; Thu, 2 May 2024 08:08:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9610D402F0; Thu, 2 May 2024 08:07:37 +0200 (CEST) Received: from EUR02-AM0-obe.outbound.protection.outlook.com (mail-am0eur02on2080.outbound.protection.outlook.com [40.107.247.80]) by mails.dpdk.org (Postfix) with ESMTP id 86BD3402D6 for ; Thu, 2 May 2024 08:07:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jwbZgHVwTMP4EHdlIlzKWMhWeSbcp9S/pYHVMFZpf3j/wU9YC0b7E8vxpBo7gZfzyOebPtIXMBBWn+weScurUw2a5j4z6o3vEI7j/klAn0SezElBTqTrlHvjJ3QirwMMb5EixwOTjsgEtIQtLjFuOzA4rZi6ppA1PcYV+31Et63UjxTGC4OU/35ecKwh5ZgoNZnECAx/OnGThoZOgrrgSMIrZByare7UekRAmT235UX1ol0+QS67P0sWksr4QvMx6xuZzVJUSWcz7hq3Epm6O2D6EKz2G36NACTwk+iJsXgxRQFNEJP8n49GNIu9AoMozW8wDQSUjQKYzj626VcrKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9OUelsYpMkkuM3XvGHV53aJb4v8YWs53DjmkXfumHoc=; b=ZdRvL9iag0MVyLoL+ivfHHSbVgeh4dhjZv1g05wBfB2LiO4b0Dm+wYvLj22/I93F4tw2gx+b0SmIZnPCUiodi8yZ1h6GS66JQIp7G0fCSTLw8YF9o/f2/ors1tgy7ONEvZkM4LDKZ/UvzGI7jI+YN5qR1JGsqV23y1/mlMaKv1gCb4QVCQJK4MbEvjWX5vy2ESDyMT1xqRLLBQFgjw48sqwHBYfOv7dayl4Hjm/A1Kpi4JFzscaJ4IpOQdjc1Cx6vRxSgc5QQMsYIaSNIApGWVXX4VxR9R5VktX4uN9QhxOIdO3M0jDljK0wKHMQUf7NfvpM0z3Sq+o7IB7nt8UGGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9OUelsYpMkkuM3XvGHV53aJb4v8YWs53DjmkXfumHoc=; b=jo0r5exqj3lg8w5FpZbpLK47fQ53rGSlwsGGD4bqX+v7LPpuJM7AvPho5XZ3bGkpBiq4+XkYxaVDHSUExDrX0TzNT5PQbmNPOh9fV5hWlsksaZhk6/UxGzcsC/+MaCNtN6yUEHxXi7SIM+npF7F/sgXlU7b7qPke186GM5xQMa1sIlH1FuVyvxu71ZqRLcBSKs3e6Spk6BLcNiiud2UwM5CcH/zZK674qmG9SIMmgXAQgZsDVBppP4Xok/kBVMhvR1UYWL4USKI0gUamARzh/TJWoBL4hp9Iv6Iv9oOSUnvZL1s8ANfLcPV2YBblFrXJS7rxn45CftbxpH/4mIwPlQ== Received: from AS4P251CA0024.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:5d3::16) by DB9PR07MB10004.eurprd07.prod.outlook.com (2603:10a6:10:4cd::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.29; Thu, 2 May 2024 06:07:32 +0000 Received: from AM4PEPF00025F98.EURPRD83.prod.outlook.com (2603:10a6:20b:5d3:cafe::2e) by AS4P251CA0024.outlook.office365.com (2603:10a6:20b:5d3::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.27 via Frontend Transport; Thu, 2 May 2024 06:07:32 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AM4PEPF00025F98.mail.protection.outlook.com (10.167.16.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.0 via Frontend Transport; Thu, 2 May 2024 06:07:31 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server id 15.2.1544.9; Thu, 2 May 2024 08:07:31 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 8056E380061; Thu, 2 May 2024 08:07:31 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?UTF-8?q?Morten=20Br=C3=B8rup?= , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Subject: [RFC v6 6/6] eal: add unit tests for atomic bit access functions Date: Thu, 2 May 2024 07:57:06 +0200 Message-ID: <20240502055706.112443-7-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240502055706.112443-1-mattias.ronnblom@ericsson.com> References: <20240430120810.108928-2-mattias.ronnblom@ericsson.com> <20240502055706.112443-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AM4PEPF00025F98:EE_|DB9PR07MB10004:EE_ X-MS-Office365-Filtering-Correlation-Id: 1463655b-71f5-4d0a-c5c4-08dc6a6e2770 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|1800799015|36860700004|376005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?dFR6STdFaEw4TDZieUVIaHBFZDlFSzliRXM0UW5zL1NYaFBMbFdOVFJxNHIr?= =?utf-8?B?aVdCTWh2Mjk4eXIxWnBFc3JxTEhTbXJ1c0g1Nk5RVzMxTGpVdFMrNVl0dWRH?= =?utf-8?B?WUxOV2Q4ZjY2K284Z0hmZTZ0RVVhUFViWDJYNEkzVFdSa25VcUhMZUUxTGhS?= =?utf-8?B?VHZrclNMb3F5TTR6R0VuZ2dtK2s3cXgra2orb0dyek1uQ01vSG5kc2NqMVN3?= =?utf-8?B?UXhZTGgvZHphbjhCejZlekVkVVM5VmpxeEJweVFkdWo3Skp4d3FTRi9SMlI3?= =?utf-8?B?MU5FMmRvN2FkOHFpM3gvcGRTb0RzWnpUWjlRVnJXczdMMVZvckh0U2pENjJ0?= =?utf-8?B?WmNOR2taOWtQRHZpOElxRFUwZmRnbk0xNENQYnFkZUJVN1RVM2dsWU9GZm1F?= =?utf-8?B?a1NZSC8yaElUejhrNm9DYjRUVWJ3OFBMaW5sWkJEUXR4amtuYTBQanpSTkxq?= =?utf-8?B?cDQ2TENVK0ExNFJaQUlxcXRoRjRrTXdHTVRMcTdtRUM1RXdrczN3WE5hWEZL?= =?utf-8?B?WmgwU01IRi94bndoMG4rSnFaRlpvY1BvQkRPK3lMcFc5VzRQRzFmMjlPNDRG?= =?utf-8?B?a0VISWFMVlgvbjI5WjNidU8vcldlR092RUxMQnJvMUIwT2hOYXJ2V3Z2eitS?= =?utf-8?B?akh1VCsrb25UUlRkVUN6OFp2aDYwdGE0dzFzWEx5dDVVakx6Tlc0Nk1FbmhZ?= =?utf-8?B?T21lWjlNZXJwbFB4ejh2cVM2QzJBQkV3cEpESzFDWTk2c2ZhVFRrWUc2UXhI?= =?utf-8?B?bUhFc2RBSVBNamhoNCtUTGVWTElrdWtZK3o4WHVMTjh5NnlmcUZKd2N3b2FF?= =?utf-8?B?MUpFM1pOanFodUM5ckdmSTlnSDFFOWpWd1hndURNcWNXMWUzLzFSdUpGUkRR?= =?utf-8?B?QmdWRUJkR28xY1VRY3QyMlZFZXpKWXNENWkvZEl3UG83eEUzb1VuQ0NkZjVC?= =?utf-8?B?R09nL3JqbWRFSHN6SzkwcGZHWWhMdmV3eW5pYWVjTzZVWlRjZHB3SXI5Tnlp?= =?utf-8?B?OVAvcHIrMER2WjVPTTJzN2F0d0pXb3pqcFR4bTJmWU9PMTVoMG1zUmFONExz?= =?utf-8?B?NUsyTm9CRFgvNlFCMU0wZGUwUEV2aEFCVnRsaFVOalFaU3RQUmNIbGI5QjVx?= =?utf-8?B?ejRkQll1a3N2eEZkd05wWU9zQVdkbXVIZE95TWNlSGNva2prZWZxc1Jwcitz?= =?utf-8?B?SU95cWpwQlZBaUg4VlR6RGE0R1RidFJ1MjJ1c1QvZEtyZ2Nwckk3SEswWXcx?= =?utf-8?B?bWxMNnE0WHJkY1lxQVBleUhzcUl3ZXA4dUxqdFdJQUYzdmFYZU5Gbm5qQnhF?= =?utf-8?B?Q0xKNHBPTDg5d2IzdEtPTDJrQzlKSTk3d1dVS1cva3dWODFKd1hQdlVlQ3U1?= =?utf-8?B?aG9vbDhyVFJMaWJtbDRJcWdCY2tCMGc5c21pV0k5bWRVbGl0S1hWZGxQc3pX?= =?utf-8?B?YTc1OFEweDBibVFuOHo4K0RxTDBIa0pHeDFqVzNGaHRqQ1BySkNxUGpibE1J?= =?utf-8?B?bG1Da3F5M29LcDFUZTRLZWMycW50cHN3NkcyQW5TRUhsN3JOQUtOeGhXblVt?= =?utf-8?B?K3VwZk5OeXBaVUt5Y2ZubFJYZDJaYXMyZkUwQmhldjFXTk1rdmMvblVITU50?= =?utf-8?B?cWVkQXlIaGpLNDdUK1MwakVrbkhyYTI0LzR4VEJ6VytQN1M5SENGTXFBVU5v?= =?utf-8?B?anI4S1VQVllGTUR6R2ZJeC9VTnFPYzNzOW5NSUNvblBCZmdNN0ZIOUVvUExG?= =?utf-8?B?Q1RrSE1lT3liTktUZ29nNTVnOEYvWkwrTGRNNHArMVExTnNLdm9hSnd4dWJ1?= =?utf-8?B?WmwzS0NMZjJMT2F0YTJXVU1JSVQ2QmtnM2VyakxNRCtaeC9mZ1VQL1RQNDli?= =?utf-8?Q?nnClLrFLrDih4?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(1800799015)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 May 2024 06:07:31.9947 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1463655b-71f5-4d0a-c5c4-08dc6a6e2770 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AM4PEPF00025F98.EURPRD83.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR07MB10004 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Extend bitops tests to cover the rte_bit_atomic_*() family of functions. RFC v4: * Add atomicity test for atomic bit flip. RFC v3: * Rename variable 'main' to make ICC happy. Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- app/test/test_bitops.c | 315 ++++++++++++++++++++++++++++++++++++++++- 1 file changed, 314 insertions(+), 1 deletion(-) diff --git a/app/test/test_bitops.c b/app/test/test_bitops.c index 9bffc4da14..c86d7e1f77 100644 --- a/app/test/test_bitops.c +++ b/app/test/test_bitops.c @@ -3,10 +3,13 @@ * Copyright(c) 2024 Ericsson AB */ +#include #include -#include #include +#include +#include +#include #include #include "test.h" @@ -69,6 +72,304 @@ GEN_TEST_BIT_ACCESS(test_bit_once_access64, rte_bit_once_set, rte_bit_once_clear, rte_bit_once_assign, rte_bit_once_flip, rte_bit_once_test, 64) +#define bit_atomic_set(addr, nr) \ + rte_bit_atomic_set(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_clear(addr, nr) \ + rte_bit_atomic_clear(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_assign(addr, nr, value) \ + rte_bit_atomic_assign(addr, nr, value, rte_memory_order_relaxed) + +#define bit_atomic_flip(addr, nr) \ + rte_bit_atomic_flip(addr, nr, rte_memory_order_relaxed) + +#define bit_atomic_test(addr, nr) \ + rte_bit_atomic_test(addr, nr, rte_memory_order_relaxed) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access32, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 32) + +GEN_TEST_BIT_ACCESS(test_bit_atomic_access64, bit_atomic_set, + bit_atomic_clear, bit_atomic_assign, + bit_atomic_flip, bit_atomic_test, 64) + +#define PARALLEL_TEST_RUNTIME 0.25 + +#define GEN_TEST_BIT_PARALLEL_ASSIGN(size) \ + \ + struct parallel_access_lcore ## size \ + { \ + unsigned int bit; \ + uint ## size ##_t *word; \ + bool failed; \ + }; \ + \ + static int \ + run_parallel_assign ## size(void *arg) \ + { \ + struct parallel_access_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + bool value = false; \ + \ + do { \ + bool new_value = rte_rand() & 1; \ + bool use_test_and_modify = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (rte_bit_atomic_test(lcore->word, lcore->bit, \ + rte_memory_order_relaxed) != value) { \ + lcore->failed = true; \ + break; \ + } \ + \ + if (use_test_and_modify) { \ + bool old_value; \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else { \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + if (old_value != value) { \ + lcore->failed = true; \ + break; \ + } \ + } else { \ + if (use_assign) \ + rte_bit_atomic_assign(lcore->word, lcore->bit, \ + new_value, \ + rte_memory_order_relaxed); \ + else { \ + if (new_value) \ + rte_bit_atomic_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + else \ + rte_bit_atomic_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + } \ + } \ + \ + value = new_value; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_assign ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + struct parallel_access_lcore ## size lmain = { \ + .word = &word \ + }; \ + struct parallel_access_lcore ## size lworker = { \ + .word = &word \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + lmain.bit = rte_rand_max(size); \ + do { \ + lworker.bit = rte_rand_max(size); \ + } while (lworker.bit == lmain.bit); \ + \ + int rc = rte_eal_remote_launch(run_parallel_assign ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_assign ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + TEST_ASSERT(!lmain.failed, "Main lcore atomic access failed"); \ + TEST_ASSERT(!lworker.failed, "Worker lcore atomic access " \ + "failed"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_ASSIGN(32) +GEN_TEST_BIT_PARALLEL_ASSIGN(64) + +#define GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(size) \ + \ + struct parallel_test_and_set_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_test_and_modify ## size(void *arg) \ + { \ + struct parallel_test_and_set_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + bool old_value; \ + bool new_value = rte_rand() & 1; \ + bool use_assign = rte_rand() & 1; \ + \ + if (use_assign) \ + old_value = rte_bit_atomic_test_and_assign( \ + lcore->word, lcore->bit, new_value, \ + rte_memory_order_relaxed); \ + else \ + old_value = new_value ? \ + rte_bit_atomic_test_and_set( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed) : \ + rte_bit_atomic_test_and_clear( \ + lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + if (old_value != new_value) \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_test_and_modify ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_test_and_set_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_test_and_set_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_test_and_modify ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_test_and_modify ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(32) +GEN_TEST_BIT_PARALLEL_TEST_AND_MODIFY(64) + +#define GEN_TEST_BIT_PARALLEL_FLIP(size) \ + \ + struct parallel_flip_lcore ## size \ + { \ + uint ## size ##_t *word; \ + unsigned int bit; \ + uint64_t flips; \ + }; \ + \ + static int \ + run_parallel_flip ## size(void *arg) \ + { \ + struct parallel_flip_lcore ## size *lcore = arg; \ + uint64_t deadline = rte_get_timer_cycles() + \ + PARALLEL_TEST_RUNTIME * rte_get_timer_hz(); \ + do { \ + rte_bit_atomic_flip(lcore->word, lcore->bit, \ + rte_memory_order_relaxed); \ + lcore->flips++; \ + } while (rte_get_timer_cycles() < deadline); \ + \ + return 0; \ + } \ + \ + static int \ + test_bit_atomic_parallel_flip ## size(void) \ + { \ + unsigned int worker_lcore_id; \ + uint ## size ## _t word = 0; \ + unsigned int bit = rte_rand_max(size); \ + struct parallel_flip_lcore ## size lmain = { \ + .word = &word, \ + .bit = bit \ + }; \ + struct parallel_flip_lcore ## size lworker = { \ + .word = &word, \ + .bit = bit \ + }; \ + \ + if (rte_lcore_count() < 2) { \ + printf("Need multiple cores to run parallel test.\n"); \ + return TEST_SKIPPED; \ + } \ + \ + worker_lcore_id = rte_get_next_lcore(-1, 1, 0); \ + \ + int rc = rte_eal_remote_launch(run_parallel_flip ## size, \ + &lworker, worker_lcore_id); \ + TEST_ASSERT(rc == 0, "Worker thread launch failed"); \ + \ + run_parallel_flip ## size(&lmain); \ + \ + rte_eal_mp_wait_lcore(); \ + \ + uint64_t total_flips = lmain.flips + lworker.flips; \ + bool expected_value = total_flips % 2; \ + \ + TEST_ASSERT(expected_value == rte_bit_test(&word, bit), \ + "After %"PRId64" flips, the bit value " \ + "should be %d", total_flips, expected_value); \ + \ + uint64_t expected_word = 0; \ + rte_bit_assign(&expected_word, bit, expected_value); \ + \ + TEST_ASSERT(expected_word == word, "Untouched bits have " \ + "changed value"); \ + \ + return TEST_SUCCESS; \ + } + +GEN_TEST_BIT_PARALLEL_FLIP(32) +GEN_TEST_BIT_PARALLEL_FLIP(64) + static uint32_t val32; static uint64_t val64; @@ -187,6 +488,18 @@ static struct unit_test_suite test_suite = { TEST_CASE(test_bit_access64), TEST_CASE(test_bit_once_access32), TEST_CASE(test_bit_once_access64), + TEST_CASE(test_bit_access32), + TEST_CASE(test_bit_access64), + TEST_CASE(test_bit_once_access32), + TEST_CASE(test_bit_once_access64), + TEST_CASE(test_bit_atomic_access32), + TEST_CASE(test_bit_atomic_access64), + TEST_CASE(test_bit_atomic_parallel_assign32), + TEST_CASE(test_bit_atomic_parallel_assign64), + TEST_CASE(test_bit_atomic_parallel_test_and_modify32), + TEST_CASE(test_bit_atomic_parallel_test_and_modify64), + TEST_CASE(test_bit_atomic_parallel_flip32), + TEST_CASE(test_bit_atomic_parallel_flip64), TEST_CASE(test_bit_relaxed_set), TEST_CASE(test_bit_relaxed_clear), TEST_CASE(test_bit_relaxed_test_set_clear), -- 2.34.1