From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6724F43F6A; Thu, 2 May 2024 18:22:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0543E402B2; Thu, 2 May 2024 18:22:58 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id CBD1040299 for ; Thu, 2 May 2024 18:22:56 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1e5c7d087e1so70458795ad.0 for ; Thu, 02 May 2024 09:22:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714666976; x=1715271776; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=KXmxPjGrtyj/JBpBR0sSqgSOHS1OJc/S4Gw5mpriON0=; b=U8HaGFFqaDMuvyWXUJ8pcLmqFWGoSBXE6LuZ2RFUovwpkF7pyqv37x2LLNYYFWlJxr F3+1xk5+zllqzY4J2W2QNjHQBMwy0KwOj+wZHJDxGDIEzQIMRt4NF0zvnJ3YTofNEibr KYx4pHSz+aH38UiCiMyag8G8pBQqGhVXRahbJLqKnueEEqI9UuNfNi6JoTJGr3jzX0kW wVHlmq4e4Riw36ThImN2wmOzBCMsO9IAhVRfdIuszRPkmWIAOkPYq+RiY2dZ6HIeTHQ6 hh6sizgpfllgbFNulIsc6E57rjquuojes/3HAuLTCfwWBj61NCaj3S8dsMH2F1oDKMUE PVSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714666976; x=1715271776; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KXmxPjGrtyj/JBpBR0sSqgSOHS1OJc/S4Gw5mpriON0=; b=kkx/zigcjrK8v2cih0wMELotvHOJcsDHPLEOShQxwfEZDFGxzP42HxpCspaMYQzvPH PtgmuSQjfNkMahUT97tx/OSXx165Rg2KZuvltCbHb8zI4FSVNfZaEGAwBm+fT3VDqWi8 Bq7pvPtm8seViR7ZzcKU129mJOh7pUs62AIvGCdgBWHiv6zS+FyqzYObiHJB9Tw2YR6W iqxe1j18bVO82tCKsovsITiKTTCDkmt0UEhODlGWs4ZToHTMaRav2hr7IAo3987sg3Ea SUEKPdr94+xLpeDzQU/QTpxJvGdHoi96PUFlPk6xAmAmcexNjmVRpp4Rt9Gw5HCcGH+q iI4w== X-Gm-Message-State: AOJu0YzVmudDfu/+r/WgzXf9lUeqW9v3fHslayEMQh5Ul/zuHqZy+1QQ mw/Phgae0U/PK7AnTmj6E9bonia1RjXHJo5R+MeSV3w1G+EFIKhAOxaqwt/AA9kJeqAHDGOIiNj 6dF4= X-Google-Smtp-Source: AGHT+IEbQ16QuYyd6o85h4y1JkDkCcdBonUInYtTL5EqD3pUprWIkQA+IWg7dlF3/iQQzFYu8yqfIA== X-Received: by 2002:a17:903:24e:b0:1eb:1d30:64b5 with SMTP id j14-20020a170903024e00b001eb1d3064b5mr171636plh.19.1714666975940; Thu, 02 May 2024 09:22:55 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id j12-20020a170903024c00b001eb51a46f5bsm1504418plh.43.2024.05.02.09.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 09:22:51 -0700 (PDT) Date: Thu, 2 May 2024 09:22:49 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v9 1/9] net/tap: do not duplicate fd's Message-ID: <20240502092249.44af109b@hermes.local> In-Reply-To: <38443222-c3ce-41dd-91c9-1038df042b92@amd.com> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240426155125.125910-1-stephen@networkplumber.org> <20240426155125.125910-2-stephen@networkplumber.org> <57fcc4d9-211b-4615-b380-2bf4f83926af@amd.com> <20240501165333.3c7ec80b@hermes.local> <38443222-c3ce-41dd-91c9-1038df042b92@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 2 May 2024 15:51:43 +0100 Ferruh Yigit wrote: > I agree on the fix, only I don't think it belongs to this patch. > > As far as I can see 'rxq_fds' was already initialized to '-1' and > original code was already wrong. > > This patch merges 'rxq_fds' & 'txq_fds' to 'fds', but this patch doesn't > do anything that requires updating the above condition, or if I missing > it please show me. > > I think better to fix condition first in a separate patch. Your right rxq_fds was not checked correctly in original code. Let me split out that one.