From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABE7143F6B; Thu, 2 May 2024 20:27:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 77DE3402B2; Thu, 2 May 2024 20:27:57 +0200 (CEST) Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) by mails.dpdk.org (Postfix) with ESMTP id 5C42740299 for ; Thu, 2 May 2024 20:27:56 +0200 (CEST) Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-5d8b887bb0cso6755327a12.2 for ; Thu, 02 May 2024 11:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714674475; x=1715279275; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=diVpulC6t4vFsURuXrnEqWbJm4gPgQQ3YqieZpdi1to=; b=FwROVMHmHHLEbotXT8UjSXwyfFWZ25Q1u/yxlSDhhrDsWT6lrPFCPbh0SJZamEBpOu hahjWxcXZGb8N4DrxrRtX/dtNt+/Di0BJrmx3iEmLvDXPU1kpnCpPENUzHmbEMtYHCzK iGU/KD6mMQM7+t4sHUKlzgTR1K4E91k3OJgx9KNPZ8+g6gBB7ygAJ4wVEJ92Qg9tEYtn kpJlvh1eA5uu0a3Lr4zAPjTMOP8A98iF9QyeIfQi3V2/VDmvmBpNdrgXl2q8WXTRLMNB c29UeFV6TZwmyDDASVDT2BmJiETsICfRk/9rI1XwVNgj+th7tgyDCPl9yfqTJhjHMj/n a2Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714674475; x=1715279275; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=diVpulC6t4vFsURuXrnEqWbJm4gPgQQ3YqieZpdi1to=; b=XL6xWF6jPMT7yq7brFWMJLhoOVBvnDaHvxwNr7F8xw7qDCIoNof9duGKd0WOZ+i2Wu KgBQLUwwjYqCk+vrTIRGTfdR46DKFTPkD4v+d5lX1g88R9RqUGx/rqp8y8kBxRQYmCu/ nDiPKqAxDjfdmSUJ4KahIC9wOMP5GWnnYp/u9HQkqFeCFQgieE90NWGQIOX1ti6vVrhp UylL07M2mplfXODgHg8n9J7D+EtmojSmg4Iu3kwY5hFixaPaG/12xWjZlciPG2habNgI /e5kDNZ0O8di4u3DC9kz8LELXY8RqECm3F/a5xIybadvn8mViWXxlE/Q6Imxd0sp3Psg E11A== X-Forwarded-Encrypted: i=1; AJvYcCUHPvMYYR03q1WNLMeEIb5KuurV/V/o52KMOTlVyLx11CV8N5snimM7KMFBtTz+QlKMjJKMq8oA3mMd1Dw= X-Gm-Message-State: AOJu0YzP8BdJuNkt/c0PmVtpEbcOKYSbPT09SDrryxELf0q1T1rRdG7e oFEgQqVTcI7n5LdLbR5s3BqF4zax7EKE8fSSPNFxnsxr2nY8s0shQs/ouWkKHDM= X-Google-Smtp-Source: AGHT+IGPMi5Oyz5eBMeBQolcSyEtaPaaHRyH7d439ir8TxPKBeqpc4ov2U32i6Xd7tcK9pwdQTbZdw== X-Received: by 2002:a17:90b:23c8:b0:2a5:e087:768a with SMTP id md8-20020a17090b23c800b002a5e087768amr690963pjb.29.1714674475340; Thu, 02 May 2024 11:27:55 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id gc19-20020a17090b311300b002b05e390c59sm1564328pjb.27.2024.05.02.11.27.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 11:27:55 -0700 (PDT) Date: Thu, 2 May 2024 11:27:53 -0700 From: Stephen Hemminger To: Daniel Gregory Cc: Ruifeng Wang , dev@dpdk.org, Punit Agrawal , Liang Ma Subject: Re: [PATCH] eal/arm: replace RTE_BUILD_BUG on non-constant Message-ID: <20240502112753.1bdf08f7@hermes.local> In-Reply-To: <20240502174420.GA3883350@ste-uk-lab-gw> References: <20240502142116.63760-1-daniel.gregory@bytedance.com> <20240502092045.02a426fe@hermes.local> <20240502174420.GA3883350@ste-uk-lab-gw> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, 2 May 2024 18:44:20 +0100 Daniel Gregory wrote: > What toolchain are you using? With your change I still get errors about > the expression not being constant: >=20 > In file included from ../lib/eal/arm/include/rte_pause.h:13, > from ../lib/eal/include/generic/rte_spinlock.h:25, > from ../lib/eal/arm/include/rte_spinlock.h:17, > from ../lib/telemetry/telemetry.c:20: > ../lib/eal/arm/include/rte_pause_64.h: In function =E2=80=98rte_wait_unti= l_equal_16=E2=80=99: > ../lib/eal/arm/include/rte_pause_64.h:156:23: error: expression in static= assertion is not constant > 156 | static_assert(__builtin_constant_p(memorder), "memory ord= er is not a constant"); > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ >=20 > I'm cross-compiling with GCC v12.2 using the > config/arm/arm64_armv8_linux_gcc cross-file, and enabling > RTE_ARM_USE_WFE by uncommenting it in config/arm/meson.build and setting > its value to true. The problem with your patch is that checking at runtime generates additional instructions in the critical path. Looks like more of a compiler bug.