From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A95943F6B; Thu, 2 May 2024 20:34:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 392B4402B2; Thu, 2 May 2024 20:34:02 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id A3ABE40299 for ; Thu, 2 May 2024 20:34:00 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-618a2b12dbbso1012392a12.0 for ; Thu, 02 May 2024 11:34:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714674840; x=1715279640; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=0a9zVZejZTrRdHCegUIDaire+zulXWgAUWRyUH7103A=; b=ji8xspA7K9GP6lTqs+Duc4sitBK7EKJUhwpX674cvoWEEjaFR4NXBLM3dZcsK5Orde kP8/pd1K35FoH+057PLhk7KqzhWn2skWCxi3GJ7z/9ZvIMuzw/9VFtxNRMgbOD1jItmn x04tBMnOQRseQzadmpmaF7AbiOCr/WwRTafcUMYDe3FEwQ1y4BbSjjbieSunBDCT6Q/V O0j6NBy45XS0n1XY9Fm7Gg+6swlP5RF97ewfBgOYDiCzRV2Ii79jU3nwDoEgAEIUsAtW DVNCakakqS7odgP82Hwk3J2946JaPkye/5AIavKU54yiwLEAsF5I8eKt0WXJlUOGAomm zgIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714674840; x=1715279640; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0a9zVZejZTrRdHCegUIDaire+zulXWgAUWRyUH7103A=; b=bKk1dxeXv5AYx17nwUYZhmEzuMh1wGOk9iqgvij01CUd5v2UrBTO4OwaMB5+M7g7h9 vLplFUZBe+pgXimZxWAk1wCLbCwvqhMsc9xNvHBNs/yG/Smty9sLevQF9ZCxuf1aQ66M F4Cicfgr0BMOWy4H9mIhni8zdx4LrAhno65Y870Vl/EFExBbHizbiBNqypVBRGNFy/HR lHSM8LfPlriG1f+UvPJIWtRPUt7QwMFwnjCykP2oOxrGCCgYZMxGkHANXJkRDj8AGOYJ kp45sFygC1gYU46E5eECRH1l17JPJeuINz/15Yxk1jqZyQKWhZDRrBlhKDX38JDm8jnS x0bQ== X-Gm-Message-State: AOJu0YzRCE4/Q6Xc0Cwi0N5y5npDgfiyDR2IFoKfbpjxIxczotYRRYGX cB1EiMcmqRYTqpD6+cvaxMzUmN8BAUeqq+AtfRt75r7MrmUVU2iPwXdSnLjiCUA= X-Google-Smtp-Source: AGHT+IE0B/85YOpQDgS3TyvhDYRWBzs/hHoAzVP8Ze8gtSn/E7VmYkvIEzZ5fVLA/z2YC2mXuGDEPA== X-Received: by 2002:a17:90a:bc98:b0:2b2:c85f:a835 with SMTP id x24-20020a17090abc9800b002b2c85fa835mr5413133pjr.15.1714674839551; Thu, 02 May 2024 11:33:59 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id gv12-20020a17090b11cc00b002b2827e6330sm3495867pjb.56.2024.05.02.11.33.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 11:33:59 -0700 (PDT) Date: Thu, 2 May 2024 11:33:55 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Mattias =?UTF-8?B?UsO2bm5ibG9t?= , "Min Hu (Connor)" , Morten =?UTF-8?B?QnLDuHJ1cA==?= , Abdullah Sevincer , Ajit Khaparde , Akhil Goyal , Alok Prasad , Amit Bernstein , Anatoly Burakov , Andrew Boyer , Andrew Rybchenko , Ankur Dwivedi , Anoob Joseph , Ashish Gupta , Ashwin Sekhar T K , Bruce Richardson , Byron Marohn , Chaoyong He , Chas Williams , Chenbo Xia , Chengwen Feng , Conor Walsh , Cristian Dumitrescu , Dariusz Sosnowski , David Hunt , Devendra Singh Rawat , Ed Czeck , Evgeny Schemeilin , Fan Zhang , Gagandeep Singh , Guoyang Zhou , Harman Kalra , Harry van Haaren , Hemant Agrawal , Honnappa Nagarahalli , Hyong Youb Kim , Jakub Grajciar , Jerin Jacob , Jian Wang , Jiawen Wu , Jie Hai , Jingjing Wu , John Daley , John Miller , Joyce Kong , Kai Ji , Kevin Laatz , Kiran Kumar K , Konstantin Ananyev , Lee Daly , Liang Ma , Liron Himi , Long Li , Maciej Czekaj , Matan Azrad , Matt Peters , Maxime Coquelin , Michael Shamis , Nagadheeraj Rottela , Nicolas Chautru , Nithin Dabilpuram , Ori Kam , Pablo de Lara , Pavan Nikhilesh , Peter Mccarthy , Radu Nicolau , Rahul Lakkireddy , Rakesh Kudurumalla , Raveendra Padasalagi , Reshma Pattan , Ron Beider , Ruifeng Wang , Sachin Saxena , Selwin Sebastian , Shai Brandes , Shepard Siegel , Shijith Thotton , Sivaprasad Tummala , Somnath Kotur , Srikanth Yalavarthi , Steven Webster , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Sunila Sahu , Tejasree Kondoj , Viacheslav Ovsiienko , Vikas Gupta , Volodymyr Fialko , Wajeeh Atrash , Wisam Jaddo , Xiaoyun Wang , Yipeng Wang , Yisen Zhuang , Yuying Zhang , Zhangfei Gao , Zhirun Yan , Ziyang Xuan Subject: Re: [PATCH v2 31/83] net/tap: move alignment attribute on types Message-ID: <20240502113355.1abd7f67@hermes.local> In-Reply-To: <1713211485-9021-32-git-send-email-roretzla@linux.microsoft.com> References: <1710949096-5786-1-git-send-email-roretzla@linux.microsoft.com> <1713211485-9021-1-git-send-email-roretzla@linux.microsoft.com> <1713211485-9021-32-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 15 Apr 2024 13:03:53 -0700 Tyler Retzlaff wrote: > Move location of __rte_aligned(a) to new conventional location. The new > placement between {struct,union} and the tag allows the desired > alignment to be imparted on the type regardless of the toolchain being > used for both C and C++. Additionally, it avoids confusion by Doxygen > when generating documentation. >=20 > Signed-off-by: Tyler Retzlaff > Acked-by: Morten Br=C3=B8rup > --- > drivers/net/tap/tap_bpf.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/tap/tap_bpf.h b/drivers/net/tap/tap_bpf.h > index 0d38bc1..d843792 100644 > --- a/drivers/net/tap/tap_bpf.h > +++ b/drivers/net/tap/tap_bpf.h > @@ -50,7 +50,7 @@ enum bpf_map_type { > }; > =20 > /* union of anonymous structs used with TAP BPF commands */ > -union bpf_attr { > +union __rte_aligned(8) bpf_attr { > /* BPF_MAP_CREATE command */ > struct { > __u32 map_type; > @@ -84,7 +84,7 @@ enum bpf_map_type { > __u32 kern_version; > __u32 prog_flags; > }; > -} __rte_aligned(8); > +}; > =20 > #ifndef __NR_bpf > # if defined(__i386__) This file is removed in the BPF fix patchset.