From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63AA143FB8; Sun, 5 May 2024 18:21:04 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D40DE4028C; Sun, 5 May 2024 18:21:03 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 690474025D for ; Sun, 5 May 2024 18:21:02 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1ecd3867556so6290595ad.0 for ; Sun, 05 May 2024 09:21:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714926061; x=1715530861; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Mdn1gS5BBBVz0bOPNUIjkNhK12sCdVijtYVs8yc/ec0=; b=NPIVDosmNg47MZX2Fh5YR7vbedJO7eGQvS1w9rkQOU3jVy3rfX77JdPCYX3q/le/Es cuKzq89Jxp4A19aG18k7aiWUNghkJigC+xEMVxPWqasr7RMgEhOmHDgSYIvPLdxwcXNd A6RkodF36gu8MpEkSl36/utOMwZbRwuws5/ceUr34ZGTbuk0oc3L+7/zUZpOdjBgFJPl Le0oIDMl+zKZENol1x5BKPDyH2xOGkCggnk2YoQDnWhmohI/32+YHIBk/ncQ1Id4jkYW KERfLz0YIySzsFWDokmVMfX0tfTlsvQK0uxMabsRjz453TIqj6Pm9h1pUPNUfMspuprS P5vQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714926061; x=1715530861; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Mdn1gS5BBBVz0bOPNUIjkNhK12sCdVijtYVs8yc/ec0=; b=KMpt3MPmDGeqYKZcGMv/onJ1M4AHICNvz/5b0LfjvHdO1c2LA8KSkPTyzAVQDJ/1Gm HdkW1SYQv8fV3NZuKgBbvYKG5ryruMwLUusfO6sASBdet/5HGNwkLXiPu4j61DREzKKy jjv+3kX0AbP9kZNvqTe8XLQnQG8CNGglEqw2P1ICrHTT/ivUrDIzmWOeEFrI4pPGDwle K7nrMk6kaMWRpBnlhwxPaUP8lh5/nQhVJf9GYTFpJ2jxDBL4atFwRJB8o2bFhmTwEwDP WVGUwiSqxblh4zDEHxCBkxWeuhNaV65zsGbZ3XnYQsYViZ+PSCRH7JLDoGG24iHTfvY/ NqTQ== X-Gm-Message-State: AOJu0YyZvAHZzs4ku2M5alqBimRIgiifd8Qa054Mhl5MKjJgfsSiXMwY wqcvnVqvETCghy78xNz5erfFhdmveEpNfxYOL9HVm8WyYIJ9W4vIfBwvpFmqD2k= X-Google-Smtp-Source: AGHT+IGFCYce1qQy0QBb9yQ/k0r0SUdj0YqfDksjjHT7KOD1X0/KwXo03UdpYQXv44Msgy60mIrgdg== X-Received: by 2002:a17:902:f60e:b0:1e1:1791:3681 with SMTP id n14-20020a170902f60e00b001e117913681mr10961613plg.61.1714926061503; Sun, 05 May 2024 09:21:01 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id i12-20020a17090332cc00b001ecd2c44ae0sm6648317plr.4.2024.05.05.09.21.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 May 2024 09:21:00 -0700 (PDT) Date: Sun, 5 May 2024 09:20:59 -0700 From: Stephen Hemminger To: Abdullah =?UTF-8?B?w5ZtZXIgWWFtYcOn?= Cc: dev@dpdk.org Subject: Re: [PATCH v3] devtools: add .clang-format file Message-ID: <20240505092059.69486f4e@hermes.local> In-Reply-To: <20240504191837.1096185-1-aomeryamac@gmail.com> References: <20240504191837.1096185-1-aomeryamac@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, 4 May 2024 19:18:37 +0000 Abdullah =C3=96mer Yama=C3=A7 wrote: > clang-format is a tool to format C/C++/Objective-C code. It can be used > to reformat code to match a given coding style, or to ensure that code > adheres to a specific coding style. It helps to maintain a consistent > coding style across the DPDK codebase. >=20 > .clang-format file overrides the default style options provided by > clang-format and large set of IDEs and text editors support it. >=20 > Signed-off-by: Abdullah =C3=96mer Yama=C3=A7 Also, this looks wrong. The initialized arrays looked better before. =20 -static const char *tuntap_types[ETH_TUNTAP_TYPE_MAX] =3D { - "UNKNOWN", "TUN", "TAP" -}; +static const char *tuntap_types[ETH_TUNTAP_TYPE_MAX] =3D {"UNKNOWN", "TUN"= , "TAP"}; =20 -static const char *valid_arguments[] =3D { - ETH_TAP_IFACE_ARG, - ETH_TAP_REMOTE_ARG, - ETH_TAP_MAC_ARG, - ETH_TAP_PERSIST_ARG, - NULL -}; +static const char *valid_arguments[] =3D {ETH_TAP_IFACE_ARG, ETH_TAP_REMOT= E_ARG, ETH_TAP_MAC_ARG, + ETH_TAP_PERSIST_ARG, NULL};