From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A1C743FCF; Tue, 7 May 2024 20:47:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A888243460; Tue, 7 May 2024 20:47:09 +0200 (CEST) Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by mails.dpdk.org (Postfix) with ESMTP id 86EF8402DF for ; Tue, 7 May 2024 20:47:07 +0200 (CEST) Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-6f489e64eb3so1290144b3a.1 for ; Tue, 07 May 2024 11:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715107626; x=1715712426; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=jmHUm3EkL/3sK7TYGwzI2YMt4FcSEf/72hypPo113nk=; b=be4v1Vy+3pdXDPDDzhDc0wdG8IYk3iOAEaGr4ePjGSwDN6VMtOY3ZPVvbNVxlYoYpZ 9Tm11hhU+79SIr88Wm/VD22B3aPrgLxdepnlCxhiqZToDOoKKHxVc5uCounXfqM41SWM G3HcywwjpRNyffYXoh37fuG7SVdQKPNkM1vO7QoxfAEBLZKbC0FgN8O0jD0QmY1Dre7p BJ6YHX0Z+oWcKj0WIc1ZM2YaAwPhjJwEp3BkngJ22Q5T2V3QRsDp8mKnpU7t+MnAJloh RvuCs5xay/pg7d7Sm6ETCgGYQVy4kueRW2hoEn/dBI/OiBA0LM/7uj+WDRzc+QytXS9h vXQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715107626; x=1715712426; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jmHUm3EkL/3sK7TYGwzI2YMt4FcSEf/72hypPo113nk=; b=YSCE4YJPLnjwpsPNF1xKzhYGo8mtQmRPLZCKJxFiltkDHLJHpGXg+FEPFoj2b1emYn EopulFbsiQuvMPggva3nGjdhVPbBFHz6wcX1aZGrM7QsX57BGbstU2CYHK5bQe/U5GbL 2wvFq7ky3Bkj77frJD5VoN7REuvEla9keQodYW4ZY42oM4ysJUABP3ZK79dCgIPER92I Cz5V0AA2ah//FJMWLyBOGk7+hhuYuhVDLZP3OqUB3Xak/UpgZOGxZ/tuT4us1EuMqHtc LMxVBDG+Kq4TOWZtAcaUl5i+dTeGGqs/32cFoog/GPm4WqQWVvBqnRJO3GrjP5rNrYTZ VagQ== X-Forwarded-Encrypted: i=1; AJvYcCXIf/W6NFdfpg6p/zdXkLUr/sRBTZOptr8VI80P2wOtYdi532EY6ez/n78xDwD96HnXvFlseT444A9ZJUw= X-Gm-Message-State: AOJu0Yya58hSUKoz3bURbLIl4pMRU0IHEyF5+7hjyQcB1/9ZkVFTzN4E 0qoKD8ulci0PfoQsVnA5HgSq/VIdzhAdLI71F9OOPcHM0Qj2YABRL2pXUil6TvI= X-Google-Smtp-Source: AGHT+IHz3O99MW25epnaBzUd+Tpp56rXTKzjHrlEso9Cb0iU98ZTKc4ZZSeLgruq7mUlwAH/flbR1A== X-Received: by 2002:a05:6a21:8199:b0:1af:5c59:1132 with SMTP id adf61e73a8af0-1afc8d3cde6mr496624637.14.1715107626480; Tue, 07 May 2024 11:47:06 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id w11-20020aa7858b000000b006ea923678a6sm9702288pfn.137.2024.05.07.11.47.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 11:47:06 -0700 (PDT) Date: Tue, 7 May 2024 11:47:04 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Morten =?UTF-8?B?QnLDuHJ1cA==?= , Mattias =?UTF-8?B?UsO2bm5ibG9t?= , "John W. Linville" , Thomas Monjalon , dev@dpdk.org, Mattias =?UTF-8?B?UsO2bm5ibG9t?= Subject: Re: [RFC v2] net/af_packet: make stats reset reliable Message-ID: <20240507114704.686d2ac2@hermes.local> In-Reply-To: <18c1a9ae-4713-4a2e-9759-c6b240cbe926@amd.com> References: <20240425174617.2126159-1-ferruh.yigit@amd.com> <20240426143848.2280689-1-ferruh.yigit@amd.com> <108e0c40-33e7-4eed-83de-eaedee454480@lysator.liu.se> <238675d1-b0bb-41df-8338-a1052c1a88c1@lysator.liu.se> <20240507075128.36484b4b@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F423@smartserver.smartshare.dk> <18c1a9ae-4713-4a2e-9759-c6b240cbe926@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 7 May 2024 17:54:18 +0100 Ferruh Yigit wrote: > On 5/7/2024 5:00 PM, Morten Br=C3=B8rup wrote: > >> From: Stephen Hemminger [mailto:stephen@networkplumber.org] > >> Sent: Tuesday, 7 May 2024 16.51 =20 > > =20 > >> I would prefer that the SW statistics be handled generically by ethdev > >> layers and used by all such drivers. =20 > >=20 > > I agree. > >=20 > > Please note that maintaining counters in the ethdev layer might cause m= ore cache misses than maintaining them in the hot parts of the individual d= rivers' data structures, so it's not all that simple. ;-) > >=20 > > Until then, let's find a short term solution, viable to implement acros= s all software NIC drivers without API/ABI breakage. > > =20 >=20 > I am against ehtdev layer being aware of SW drivers and behave > differently for them. > This is dev_ops and can be managed per driver. We can add helper > functions for drivers if there is a common pattern. It is more about having a set of helper routines for SW only drivers. I have something in progress for this.