From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: stephen@networkplumber.org, Ciara Loftus <ciara.loftus@intel.com>,
stable@dpdk.og
Subject: [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic
Date: Fri, 10 May 2024 10:03:57 +0000 [thread overview]
Message-ID: <20240510100358.18815-2-ciara.loftus@intel.com> (raw)
In-Reply-To: <20240510100358.18815-1-ciara.loftus@intel.com>
Failures to allocate mbufs in the receive path were not being
accounted for in the ethdev statistics. Fix this.
Bugzilla ID: 1429
Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD")
cc: stable@dpdk.og
Reported-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/af_xdp/rte_eth_af_xdp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index fee0d5d5f3..968bbf6d45 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -124,6 +124,7 @@ struct rx_stats {
uint64_t rx_pkts;
uint64_t rx_bytes;
uint64_t rx_dropped;
+ uint64_t alloc_failed;
};
struct pkt_rx_queue {
@@ -339,6 +340,8 @@ af_xdp_rx_zc(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
* xsk_ring_cons__peek
*/
rx->cached_cons -= nb_pkts;
+ rxq->stats.alloc_failed += nb_pkts;
+
return 0;
}
@@ -408,6 +411,7 @@ af_xdp_rx_cp(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)
* xsk_ring_cons__peek
*/
rx->cached_cons -= nb_pkts;
+ rxq->stats.alloc_failed += nb_pkts;
return 0;
}
@@ -872,6 +876,7 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
stats->ibytes += stats->q_ibytes[i];
stats->imissed += rxq->stats.rx_dropped;
stats->oerrors += txq->stats.tx_dropped;
+ dev->data->rx_mbuf_alloc_failed += rxq->stats.alloc_failed;
fd = process_private->rxq_xsk_fds[i];
ret = fd >= 0 ? getsockopt(fd, SOL_XDP, XDP_STATISTICS,
&xdp_stats, &optlen) : -1;
--
2.34.1
next prev parent reply other threads:[~2024-05-10 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 10:03 [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Ciara Loftus
2024-05-10 10:03 ` Ciara Loftus [this message]
2024-05-10 12:35 ` [PATCH 2/3] net/af_xdp: Fix mbuf alloc failed statistic Maryam Tahhan
2024-05-10 15:06 ` Stephen Hemminger
2024-05-13 8:23 ` Maryam Tahhan
2024-05-13 15:53 ` Stephen Hemminger
2024-05-14 8:37 ` Loftus, Ciara
2024-05-10 10:03 ` [PATCH 3/3] net/af_xdp: Fix stats reset Ciara Loftus
2024-05-10 12:36 ` Maryam Tahhan
2024-05-10 12:20 ` [PATCH 1/3] net/af_xdp: Fix port id not set in rx mbuf Maryam Tahhan
2024-05-10 14:58 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240510100358.18815-2-ciara.loftus@intel.com \
--to=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.og \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).