DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] lib/vhost: add flag for async connection in client mode
@ 2024-04-17  8:41 Ушков Даниил
  2024-04-17  9:15 ` [PATCH v2] " Ушков Даниил
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Ушков Даниил @ 2024-04-17  8:41 UTC (permalink / raw)
  To: dev
  Cc: Ушков
	Даниил,
	Maxime Coquelin, Chenbo Xia

This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT,
which in combination with the flag RTE_VHOST_USER_CLIENT makes
rte_vhost_driver_start connect asynchronously to the vhost server.

Signed-off-by: Daniil Ushkov <udav@mts.ru>
---
 lib/vhost/rte_vhost.h |  1 +
 lib/vhost/socket.c    | 28 ++++++++++++++++------------
 2 files changed, 17 insertions(+), 12 deletions(-)

diff --git a/lib/vhost/rte_vhost.h b/lib/vhost/rte_vhost.h
index db92f05344..b0434c4b8d 100644
--- a/lib/vhost/rte_vhost.h
+++ b/lib/vhost/rte_vhost.h
@@ -41,6 +41,7 @@ extern "C" {
 #define RTE_VHOST_USER_ASYNC_COPY	(1ULL << 7)
 #define RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS	(1ULL << 8)
 #define RTE_VHOST_USER_NET_STATS_ENABLE	(1ULL << 9)
+#define RTE_VHOST_USER_ASYNC_CONNECT	(1ULL << 10)
 
 /* Features. */
 #ifndef VIRTIO_NET_F_GUEST_ANNOUNCE
diff --git a/lib/vhost/socket.c b/lib/vhost/socket.c
index 96b3ab5595..38c400f173 100644
--- a/lib/vhost/socket.c
+++ b/lib/vhost/socket.c
@@ -45,6 +45,7 @@ struct vhost_user_socket {
 	bool async_copy;
 	bool net_compliant_ol_flags;
 	bool stats_enabled;
+	bool async_connect;
 
 	/*
 	 * The "supported_features" indicates the feature bits the
@@ -533,21 +534,23 @@ vhost_user_start_client(struct vhost_user_socket *vsocket)
 	const char *path = vsocket->path;
 	struct vhost_user_reconnect *reconn;
 
-	ret = vhost_user_connect_nonblock(vsocket->path, fd, (struct sockaddr *)&vsocket->un,
-					  sizeof(vsocket->un));
-	if (ret == 0) {
-		vhost_user_add_connection(fd, vsocket);
-		return 0;
-	}
+	if (!vsocket->async_connect || !vsocket->reconnect) {
+		ret = vhost_user_connect_nonblock(vsocket->path, fd, (struct sockaddr *)&vsocket->un,
+							sizeof(vsocket->un));
+		if (ret == 0) {
+			vhost_user_add_connection(fd, vsocket);
+			return 0;
+		}
 
-	VHOST_CONFIG_LOG(path, WARNING, "failed to connect: %s", strerror(errno));
+		VHOST_CONFIG_LOG(path, WARNING, "failed to connect: %s", strerror(errno));
 
-	if (ret == -2 || !vsocket->reconnect) {
-		close(fd);
-		return -1;
-	}
+		if (ret == -2 || !vsocket->reconnect) {
+			close(fd);
+			return -1;
+		}
 
-	VHOST_CONFIG_LOG(path, INFO, "reconnecting...");
+		VHOST_CONFIG_LOG(path, INFO, "reconnecting...");
+	}
 	reconn = malloc(sizeof(*reconn));
 	if (reconn == NULL) {
 		VHOST_CONFIG_LOG(path, ERR, "failed to allocate memory for reconnect");
@@ -930,6 +933,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 	vsocket->async_copy = flags & RTE_VHOST_USER_ASYNC_COPY;
 	vsocket->net_compliant_ol_flags = flags & RTE_VHOST_USER_NET_COMPLIANT_OL_FLAGS;
 	vsocket->stats_enabled = flags & RTE_VHOST_USER_NET_STATS_ENABLE;
+	vsocket->async_connect = flags & RTE_VHOST_USER_ASYNC_CONNECT;
 	if (vsocket->is_vduse)
 		vsocket->iommu_support = true;
 	else
-- 
2.34.1

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2024-06-12  8:31 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-17  8:41 [PATCH] lib/vhost: add flag for async connection in client mode Ушков Даниил
2024-04-17  9:15 ` [PATCH v2] " Ушков Даниил
2024-04-25 13:47   ` Maxime Coquelin
2024-04-25 14:04     ` Morten Brørup
2024-04-29 19:43       ` Thomas Monjalon
2024-04-26  8:38 ` [PATCH v3] " Daniil Ushkov
2024-04-26  8:47 ` [PATCH v4] " Daniil Ushkov
2024-04-26 21:29 ` [PATCH] " Patrick Robb
2024-05-14  9:13 ` [PATCH v5] This patch introduces a new flag RTE_VHOST_USER_ASYNC_CONNECT, which in combination with the flag RTE_VHOST_USER_CLIENT makes rte_vhost_driver_start connect asynchronously to the vhost server Daniil Ushkov
2024-05-14  9:16 ` [PATCH v6] lib/vhost: add flag for async connection in client mode Daniil Ushkov
2024-06-07 13:59   ` Maxime Coquelin
2024-06-12  8:30   ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).