From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B14A43FD4; Tue, 14 May 2024 18:03:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBDA4402B7; Tue, 14 May 2024 18:03:55 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4783F40156 for ; Tue, 14 May 2024 18:03:53 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 3FC3320B2C80; Tue, 14 May 2024 09:03:52 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3FC3320B2C80 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1715702632; bh=BeMcX6aUSATltmVBthgFt70ly3yGgTJxhYrJ0Fg9Kdo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sOm8aiVGt1bxSza8rhuriodjjcR7I4rr/O6BoLo3IqmKW/ZDoFyLQgENoF0DA5jBM HdJYKk8h9lBthBdLJaaXsGBLnPa7/garrB9dMvVm5W3hk5qLEY0lndiXAco2fHS3XP NnKkp9oAuIzSn2uujAGOBFK1wTYgX9lgtT0tNrHE= Date: Tue, 14 May 2024 09:03:52 -0700 From: Tyler Retzlaff To: David Marchand Cc: Morten =?iso-8859-1?Q?Br=F8rup?= , "Chautru, Nicolas" , dev@dpdk.org, Mattias =?iso-8859-1?Q?R=F6nnblom?= , "Sevincer, Abdullah" , Ajit Khaparde , Alok Prasad , "Burakov, Anatoly" , Andrew Rybchenko , Anoob Joseph , "Richardson, Bruce" , "Marohn, Byron" , Chenbo Xia , Chengwen Feng , "Loftus, Ciara" , "Power, Ciara" , Dariusz Sosnowski , "Hunt, David" , Devendra Singh Rawat , "Carrillo, Erik G" , Guoyang Zhou , Harman Kalra , "Van Haaren, Harry" , "Nagarahalli, Honnappa" , Jakub Grajciar , Jerin Jacob , Jeroen de Borst , Jian Wang , Jiawen Wu , Jie Hai , "Wu, Jingjing" , Joshua Washington , Joyce Kong , "Guo, Junfeng" , "Laatz, Kevin" , Konstantin Ananyev , Liang Ma , Long Li , Maciej Czekaj , Matan Azrad , Maxime Coquelin , Ori Kam , Pavan Nikhilesh , "Mccarthy, Peter" , Rahul Lakkireddy , "Pattan, Reshma" , "Xu, Rosen" , Ruifeng Wang , Rushil Gupta , "Gobriel, Sameh" , Sivaprasad Tummala , Somnath Kotur , Stephen Hemminger , Suanming Mou , Sunil Kumar Kori , Sunil Uttarwar , Tetsuya Mukawa , Vamsi Attunuru , Viacheslav Ovsiienko , "Medvedkin, Vladimir" , Xiaoyun Wang , "Wang, Yipeng1" , Yisen Zhuang , Ziyang Xuan Subject: Re: [PATCH v5 31/45] baseband/acc: use rte stdatomic API Message-ID: <20240514160352.GA9208@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1710967892-7046-1-git-send-email-roretzla@linux.microsoft.com> <1715018306-13741-1-git-send-email-roretzla@linux.microsoft.com> <1715018306-13741-32-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F448@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 14, 2024 at 09:31:18AM +0200, David Marchand wrote: > On Mon, May 13, 2024 at 9:05 PM Morten Brørup wrote: > > > > Tyler, it looks like the line continuations in /drivers/baseband/acc/rte_vrb_pmd.c are indented with four spaces instead of double . > > For Tyler defence, indentation is a nice mess in a lot of DPDK code > (for legacy, superficial reviews, not enough coffee etc... reasons). > mlx5 code is also a big pain as it seems to have its own coding style. > > I was in the progress of taking this series yesterday and I was > looking at those indents before getting EINTR. > Tyler, can you please fix those? This will save me some time and I can > get this merged soon. sure David i'll tweak this patch. > > > Thanks. > > -- > David Marchand