From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 6D22443F81;
	Thu, 16 May 2024 17:21:04 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E58DB402DC;
	Thu, 16 May 2024 17:21:03 +0200 (CEST)
Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com
 [209.85.215.174])
 by mails.dpdk.org (Postfix) with ESMTP id E7D684029B
 for <dev@dpdk.org>; Thu, 16 May 2024 17:21:01 +0200 (CEST)
Received: by mail-pg1-f174.google.com with SMTP id
 41be03b00d2f7-5e42b4bbfa4so226312a12.1
 for <dev@dpdk.org>; Thu, 16 May 2024 08:21:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1715872861;
 x=1716477661; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:from:to:cc:subject:date
 :message-id:reply-to;
 bh=g/M1iiinBT2Lkp5as+ytiezDNyx6wWZfQTdts4t+Bko=;
 b=pbBoc74KETQrUozLTxqrJQmrZbEMmLhUNBRDAoPj0F1xmOUS5TaqkqlQ7CLc1ycznv
 ae16EmeT4WPD4WLt/lAZ5is6SMzXi3A9WhJBztO5CySWOyzsBKvX8odVPwM0HUhNWyf+
 c50NQf7T/VSnQ328FFCAg8c/72/R2n+RWPZ04ls8msjTR5Z6zXJGI0h5KxxjLSz0mu51
 xf5VGcP+y1OsOrIJ6lNnSO0f1wxP1OFFpcgRMjZbu30Eyy++u6cDNEHUf7T1LaOZ0sAz
 k9HNYb63h62eDOVEmUbjE50PaaSGDNmgSVKRjhESgPagP7+F/dAqrGm9H/XJzWXxDpXq
 6bJQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1715872861; x=1716477661;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=g/M1iiinBT2Lkp5as+ytiezDNyx6wWZfQTdts4t+Bko=;
 b=RPel/NSlBnjzhXVZYRVu6bgh7X8Am4r2B/FBSGoszPHOgQ9/8fGZc+xkkjHEh8ckxh
 hD/RLBbMsfbLG4Ex/R0nFFpNMD7+ciwj/wedLTmfMDVSSyGpEgmQrY5vOaHt9G1ymUPR
 9l9Z6fN8KXf4MM/BJBL6oVkaBOQUu4wMkTQyTRHxTkpbc+dUzCzYJCH64P3HAQzr9alw
 Eh/c/B8mW4ChiG2mfjT5FFcXtf8buwebC4YZU+6VucMRLeDnOv+HGvuGWaO1J1RQ5THL
 RomF6oLrnI9spEk5TfTRM220o59Dy0Pw6e1naftq/hGCxSji+j6PXhdjbPgnPJ1fweAS
 QknA==
X-Forwarded-Encrypted: i=1;
 AJvYcCXtqi5U+TpGQL+OQGJGVe2LJXJNJD8ZjAjvXrBd4pJfpRtHVyakFrPMvT2lU9jWZOKpU48pniZ3M9ru34c=
X-Gm-Message-State: AOJu0YynOITIB9HXHwyeNmTHqmaAN1fPKjZeMhwTmSs+4g/l/m8iu9vX
 XDE+nWPNO+tDTG5kZJ83yyET8IldN50i1sdiKBLdZwBqGtA0OK9YMO2t+C/RIDI=
X-Google-Smtp-Source: AGHT+IHj3Rkjje7QFxAbsQJeoWEBsrZ+zMH8swwFN3cnqPMwpQnUJSt1qRaI+BfBrOb7wrMDbzdh9w==
X-Received: by 2002:a17:90a:dc82:b0:2ad:f278:77b4 with SMTP id
 98e67ed59e1d1-2b6cc76f6e2mr19337321a91.23.1715872860732; 
 Thu, 16 May 2024 08:21:00 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-2b6c51b59fesm12283173a91.48.2024.05.16.08.20.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Thu, 16 May 2024 08:21:00 -0700 (PDT)
Date: Thu, 16 May 2024 08:20:57 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Morten =?UTF-8?B?QnLDuHJ1cA==?= <mb@smartsharesystems.com>
Cc: andrew.rybchenko@oktetlabs.ru, konstantin.v.ananyev@yandex.ru,
 paul.szczepanek@arm.com, dev@dpdk.org
Subject: Re: [PATCH] mempool: dump includes list of memory chunks
Message-ID: <20240516082057.40f3ce56@hermes.local>
In-Reply-To: <20240516085940.61119-1-mb@smartsharesystems.com>
References: <20240516085940.61119-1-mb@smartsharesystems.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, 16 May 2024 10:59:40 +0200
Morten Br=C3=B8rup <mb@smartsharesystems.com> wrote:

> +	fprintf(f, "  mem_list:\n");
> +	n =3D 0;
> +	STAILQ_FOREACH(memhdr, &mp->mem_list, next) {
> +		fprintf(f, "    addr[%u]=3D%p\n", n, memhdr->addr);
> +		fprintf(f, "    iova[%u]=3D0x%" PRIx64 "\n", n, memhdr->iova);
> +		fprintf(f, "    len[%u]=3D%zu\n", n, memhdr->len);
> +		n++;
> +	}

The output would look better if it was a table with one line per mempool, a=
nd the name first
and column headers, and n is redundant

mem_list:
Addr	Iova	Len
...