From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FB0F4407F; Tue, 21 May 2024 04:01:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45D5940265; Tue, 21 May 2024 04:01:27 +0200 (CEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id 703AC4021E for ; Tue, 21 May 2024 04:01:26 +0200 (CEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1e3c3aa8938so94244065ad.1 for ; Mon, 20 May 2024 19:01:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716256885; x=1716861685; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=kQNQaHG5afD4ke+GOyO8sLI7kbRvFrOq1qVdnAqaAC4=; b=pYp5wQEYGNsmfPFZdTEiHvXNjuZyz6+XDommCt5bwgV4opwAebrjtL4QWj76Zv3ped L6zSdDUx52yAUMCnU4UnFBkc0VC0Ir21Z1o17llzOgeXIkAchAB1T0771CrAupbpuZXg Oh+7rh8XSQhkax5yd36DuHDe2SbqbDsyy/E52NneI0SFneJP2dbgGtwUEeGe1zVPoLHw chzyJtXsp3U60RE3cQS6smXdZA8KSLA3EHAa598i2QHDtlwSo8ZSoSRWfdpdFPKsXnyA El5vP731ktkyJuoPZS1ijD7vlVtOWU7UOQbb3/8w7ab5kUZftk98Rpo7tUvIw7d+ncwe +vvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716256885; x=1716861685; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kQNQaHG5afD4ke+GOyO8sLI7kbRvFrOq1qVdnAqaAC4=; b=TDh6ABcWiVsowvF6o4Vyb0ikX7RFehQSlv0X3pcbAMCSNa7DPIgiW2ZNMXNqMlfsd4 0EW+VZQLKL38zrh6CTL+9zybPtzZK0ukWlT6kTPWq0Vm9tqBCGNXbZXYip/fhnHOrgeQ vQVovrAfSmgPoX3hOnzvOcenDEBVq2+J0WWzUHISEEXF6cRXnq81RkTWV5MnUiPKeAYs 9Q04G/WwIseK+Sfu420njZpyFweLfneDtbcEdRf0ryl2uOU8TKscmFnFipGZYvhFz0aE SPHsNx9ZllGqjjqbmgmKP3yJBK7a9gipScuidVyoNAy/DHerI9WnIeLzIKqIOSW0HGn1 EXEA== X-Gm-Message-State: AOJu0Yw/shYErsKGNNHNllM4vVa+GtXFbq+Jpcj9IIMKn4qDPrXBEbuw OLu77/Xk+rkWwy3xmS4u7OYwNAnyrnjHVeJwxWhlGASlE5TFKdyf8WEUzOFOR9cX3DxmwEPfTw/ k X-Google-Smtp-Source: AGHT+IHSkMMYxF+S7r5FAJ9UYzLa7sWDntmKo9/eN/PI2OiUdmWVxOP0hlj+HrEdwLVLZ05sfuo3DA== X-Received: by 2002:a17:903:2306:b0:1f2:f6f7:bf6e with SMTP id d9443c01a7336-1f2f6f7c225mr70851145ad.22.1716256885236; Mon, 20 May 2024 19:01:25 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f13ebfd8a5sm85141745ad.296.2024.05.20.19.01.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 19:01:25 -0700 (PDT) Date: Mon, 20 May 2024 19:01:22 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: dev@dpdk.org Subject: Re: [PATCH v12 04/12] net/tap: validate and setup parameters for BPF RSS Message-ID: <20240520190122.2469474a@hermes.local> In-Reply-To: References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> <20240502213618.11391-5-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 20 May 2024 18:47:08 +0100 Ferruh Yigit wrote: > > + > > > > Why 'rte_convert_rss_key()' is required? Is this making an assumption on > the CPU architecture? What is happening here is that the key passed in is in cpu native order, but the SW RSS algorithm needs it to be in big-endian to work with IP protocols that are big-endian. In rte_thash the code to convert key is: rte_convert_rss_key() and the code use the converted key is rte_softrss_be(). The BPF code doesn't (and cant easily because of license/validator) use the same exact routine but it is equivalent to rte_softrss_be and uses pre-converted key for performance.