From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A7284407F; Tue, 21 May 2024 04:50:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1D32C40DDC; Tue, 21 May 2024 04:49:45 +0200 (CEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id 20459402E2 for ; Tue, 21 May 2024 04:49:35 +0200 (CEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1e3c3aa8938so94893825ad.1 for ; Mon, 20 May 2024 19:49:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716259774; x=1716864574; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BofXLaCQzFPxNJh9822n+x8IHkD2bpi6dG3sqDlipgY=; b=SR0GA+6O8CtcVfNn+FGkM1RDtrFqweNzcrZQ5MHVPE+fYv2XTslA43fiojiGI/7OxP SdumoxIoOIuvE2rkFGXehq9nis+NnjkEhswAgnfwc5w7n11HZ3g+1LYhX03JN7AWMK9I BsQMK6020yzdO2aEKi0k29ozANAhZI9PH7z4pgvDv7TSC+HKbR09x/3CYNX76UKHWg9F /bCS5EzIZVn3FrgIsqIQ08Z43jr5cwLsFlmtwy3G+0IhTc05BY2lNBq4/9uVOc/wR/g9 23alz7erxVIqts+VccwFSYpV23SnEA2i/SpM2huQ8O/zk289UdxPF0QPuO/ceH1rMcnu NDrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716259774; x=1716864574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BofXLaCQzFPxNJh9822n+x8IHkD2bpi6dG3sqDlipgY=; b=D7Or2ZS44Ti+dqk30CDUu6kfah4k6gT/z2BC8uUCn86ZY4osWXmwRDeP8M/or/713S LFAzU5wFMQCTYfEn6DcKxF9fkEkZ8vBdKa+ud7V9sRwG7XeIfttufhttQjvW+Q9FWLvE LStbAVTKQCC6GCSOjE3Kf/sGjW2uKl9ohzLgI7UA2w9qObJFNSoAUx1yey9ou/hLkv9y ZHTifwwISFAVs5ecXCVD3f0zX1ZSJ4JBV57kN/oUIK2ZSSrbPRhEFbVJP0SM4/mUG2hx OTFh2cxSwRs/A+F6rT74TzlF0yhs1TjwKCdj3kXiaTOFl3+HBXownYnMwN7Mt4924fmO NwVA== X-Gm-Message-State: AOJu0YxzGvHckfZRJBWGH1Z18wFUJT0rgbSRjG+dTU0LFrAUvFIUUMsg SNbQi+FTZRoeZXIXtvcu8Pn7uQqgGJcs72IrZMVSyshpcixJgbjwarejASZ9GIgzB23Or6FR/rP I X-Google-Smtp-Source: AGHT+IGSOQJbXcMr2i+J0RL2XCdRJO+Jwv6+g5pK9pS4i7K5/qBtZzTCp9XgZ6lTLyoY+Qt0fdplgw== X-Received: by 2002:a17:903:451:b0:1e4:b1a2:b40c with SMTP id d9443c01a7336-1ef43f4d25amr254938905ad.42.1716259774191; Mon, 20 May 2024 19:49:34 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d4828sm209742315ad.20.2024.05.20.19.49.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 May 2024 19:49:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ferruh Yigit Subject: [PATCH v13 10/11] net/tap: remove extraneous newlines Date: Mon, 20 May 2024 19:47:29 -0700 Message-ID: <20240521024923.150983-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240521024923.150983-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521024923.150983-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some log messages contained extra newlines. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3614aaf1dc..2484a82ccb 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -235,9 +235,8 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) flags = fcntl(fd, F_GETFL); if (flags == -1) { - TAP_LOG(WARNING, - "Unable to get %s current flags\n", - ifr.ifr_name); + TAP_LOG(WARNING, "Unable to get %s current flags: %s", + ifr.ifr_name, strerror(errno)); goto error; } @@ -279,7 +278,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) if (sigaction(signo, &sa, NULL) == -1) { TAP_LOG(WARNING, - "Unable to set rt-signal %d handler\n", signo); + "Unable to set rt-signal %d handler", signo); goto error; } @@ -290,11 +289,11 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) } if (signo == SIGRTMAX) { - TAP_LOG(WARNING, "All rt-signals are in use\n"); + TAP_LOG(WARNING, "All rt-signals are in use"); /* Disable trigger globally in case of error */ tap_trigger = 0; - TAP_LOG(NOTICE, "No Rx trigger signal available\n"); + TAP_LOG(NOTICE, "No Rx trigger signal available"); } else { /* Enable signal on file descriptor */ if (fcntl(fd, F_SETSIG, signo) < 0) { @@ -920,7 +919,7 @@ tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void } process_private = dev->process_private; - TAP_LOG(DEBUG, "tap_attach q:%d\n", request_param->q_count); + TAP_LOG(DEBUG, "tap_attach q:%d", request_param->q_count); for (int q = 0; q < request_param->q_count; q++) process_private->fds[q] = request->fds[q]; @@ -1463,7 +1462,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) if (ret < 0 || ret >= (int)sizeof(pool_name)) { TAP_LOG(ERR, "%s: failed to create mbuf pool name for device %s," - "device name too long or output error, ret: %d\n", + "device name too long or output error, ret: %d", pmd->name, dev->device->name, ret); return -ENAMETOOLONG; } @@ -1473,7 +1472,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!pmd->gso_ctx_mp) { TAP_LOG(ERR, - "%s: failed to create mbuf pool for device %s\n", + "%s: failed to create mbuf pool for device %s", pmd->name, dev->device->name); return -1; } -- 2.43.0