From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D3764408C; Tue, 21 May 2024 19:08:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B6C440A81; Tue, 21 May 2024 19:08:03 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id F099C406B6 for ; Tue, 21 May 2024 19:08:00 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6f44d2b3130so1658712b3a.2 for ; Tue, 21 May 2024 10:08:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716311280; x=1716916080; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=e5E1AqdLATcVM+Lo+U/ZIX0kh2xZTr7NuQBdC08F0AU=; b=phoF281GVxev69j4D9EHDTBANVynlLLau3shIzAVY/oiTIBakMFRj5ka1wQMYVAR83 ZSXYfhjP0buH5QqTJvd1Oqw4Bx6kWe8CIoFicBPaRVRtVs4CbUxuO1C6yW0zAa1bplvS Zm6tYrIvYNNUWVduGtjNVp7SIdgznc3JXXedkRJmMMKzp/UqL88pSr/WjO0aO+d9ZDZq z9tIKiSBynduR65GwQEyYGPZHD4s1o7pRVZXD1btxuALTeMtXlQKDW4T8O1ekn4Pu3Jf usYbbXdCYDLlglEaziUJYr6dmo2dJv5jxWUUqcYhTeSxQHyIAk6t+LHIR8d0LXf2BXSs mS0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716311280; x=1716916080; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=e5E1AqdLATcVM+Lo+U/ZIX0kh2xZTr7NuQBdC08F0AU=; b=IuGoN/Rvx0/B4dQyQCMD/TX5Gazfy0wzKa3+c8uEJjfcwYrn+Jlk+9RNFbDJk8ILQR PmGj+GoIQAfF47y1I9msREMChlqinKFbYzjmWEeAHu/Z39SBuGQGYzQ73es0TJs1SFkj dYok3ugtCSy0P8b0X3LkYLlbMtmEiJDF9rG8uOVi1vtbU1TLhoHLcTxMeE4cMrHhOMxX CRiT9TiyIbRINbfQQCDaMUscAuHp2gEfsDnL3mgeSqGgWLxRnny5R5QciM9Pg6t7TAC5 H+yjlsdZWnqFCChCZnrOaDQrteybzpc1kjnc/yQJRWcHMyLnF+S3mdilSy5xrXNOlPvU Ic0A== X-Gm-Message-State: AOJu0YxD8SoqfLVBI4YcZSImPDUnGkT1EsVks1Vrg3hVnZzdLGwsoMMK Y404xrHpJV/Wt3jFP7h7JKAclbRPGl2j9NQ+sZVEnPagW5GvDdsKDRrBFMqNsqQAjDxaxSGZwWD y X-Google-Smtp-Source: AGHT+IHLKAQoraCHb1xi5lzEo4lwSP+WXeRRGdMTxhKVAZyBwkjjnuZPhzajBSG9xM++MCtbci5W0A== X-Received: by 2002:a05:6a00:2daa:b0:6f3:ebc4:4407 with SMTP id d2e1a72fcca58-6f4e0299e1amr34086616b3a.4.1716311280138; Tue, 21 May 2024 10:08:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-6f4d2af52b4sm21634041b3a.174.2024.05.21.10.07.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 10:07:59 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ferruh Yigit Subject: [PATCH v14 03/11] net/tap: remove unused fields Date: Tue, 21 May 2024 10:06:03 -0700 Message-ID: <20240521170746.119330-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240521170746.119330-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521170746.119330-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c | 1 - drivers/net/tap/tap_rss.h | 6 ------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h index dc8201020b..1bcf92ce80 100644 --- a/drivers/net/tap/rte_eth_tap.h +++ b/drivers/net/tap/rte_eth_tap.h @@ -77,14 +77,12 @@ struct pmd_internals { int ioctl_sock; /* socket for ioctl calls */ int nlsk_fd; /* Netlink socket fd */ int flow_isolate; /* 1 if flow isolation is enabled */ - int flower_support; /* 1 if kernel supports, else 0 */ - int flower_vlan_support; /* 1 if kernel supports, else 0 */ int rss_enabled; /* 1 if RSS is enabled, else 0 */ int persist; /* 1 if keep link up, else 0 */ /* implicit rules set when RSS is enabled */ int map_fd; /* BPF RSS map fd */ int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */ - LIST_HEAD(tap_rss_flows, rte_flow) rss_flows; + LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */ /* implicit rte_flow rules set when a remote device is active */ LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a78fd50cd4..8fccd599f0 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd, errno, strerror(errno)); return err; } - LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next); } pmd->rss_enabled = 1; diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..8766ffc244 100644 --- a/drivers/net/tap/tap_rss.h +++ b/drivers/net/tap/tap_rss.h @@ -21,12 +21,6 @@ enum hash_field { HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */ HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */ HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */ - HASH_FIELD_L2_SRC, /* Ethernet src addr */ - HASH_FIELD_L2_DST, /* Ethernet dst addr */ - HASH_FIELD_L3_SRC, /* L3 src addr */ - HASH_FIELD_L3_DST, /* L3 dst addr */ - HASH_FIELD_L4_SRC, /* TCP/UDP src ports */ - HASH_FIELD_L4_DST, /* TCP/UDP dst ports */ }; struct rss_key { -- 2.43.0