From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 64EBD44093; Wed, 22 May 2024 04:21:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E6E7540273; Wed, 22 May 2024 04:21:15 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 458E84025C for ; Wed, 22 May 2024 04:21:15 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6f6911d16b4so1107198b3a.3 for ; Tue, 21 May 2024 19:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716344474; x=1716949274; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=emt2McNa4zC++6cCj5MAMLQHIW5+OSioKZ3ftgvJnV8=; b=QoElKeScxE7mPS1uf/B/uloPhfoYf9E/nucq/u40tVnfVvLlk2xUkBa65fx3xe0bWX H9EH2ATjR7KUCShZXkq1+IMgE/BN3mCg2ZyrqYFncXkm/daTVqRcx8Q90YQsTNEZXLVn /911gRjVM5ukWObxSM3DV+R9NT2ckY3A+quCs74BvStLwaJwgKPH73Q4CBqHYGtEE2mb FhgaYk/Ukkqp+Z0QPuHO8JTLZ36AfnS17UI8t1LPbtYGvcBZXitAmTanaejUUrwE0mqg BjkbGvPrw40hrApHFrW1hdI5VCH/25O4P1ffPJ2dbNZ/8MgvHn15UPt2UQUeT4AOnXSI 6qYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716344474; x=1716949274; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=emt2McNa4zC++6cCj5MAMLQHIW5+OSioKZ3ftgvJnV8=; b=wJcQncIKYLXPDBzBLdT8F/zyBG+bhMVu033RIkcbgSfBFk48sjI3pksqjG8hn3qgXT Vgf9W3UGHhPTmaUcRP8uXWFvKJNi5IifcaHYcsJfmYOiJWBMqo3unkrvZ4Ml7/tIoJgy G0VonVrpKh0rURho0/COMpaJe50NdOVf2sFko0gm8Q5oCq/HBn7aa2ddDHjQZY5gtR1m 85tthcERi2TsAaHQtc5tHmvac9Ljx7k8GmsC/zqO/tN3Z4udxSldhdE7VN7JfdCSfRKv lO6TiFPdEX/aZLJWsqW46floIiwAMJ85I2c/DFDnkbvTaWM4Y1sBJ4nAk9vsaWaW6Cws YK4A== X-Gm-Message-State: AOJu0YyVWZrs+nIe2uVrDv6+yj0+WLCtDj+OI+UHefAvBk/a3/xGgScM tk99QqfceUigxZ8i0pshvmtaG9rIj2qqteMzIzgjx6D1ZHwQn4Hao4ab62U4Mtc= X-Google-Smtp-Source: AGHT+IEfLOQ8e2WpUct+rtkUAFEKTlYpoDALFtdXdwfmFrqVtwoIeQYQOjc3amX7d0V1PH0XyJ3zmw== X-Received: by 2002:a05:6a20:914f:b0:1af:cd45:598b with SMTP id adf61e73a8af0-1b1f884782dmr881110637.34.1716344474020; Tue, 21 May 2024 19:21:14 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0c136a12sm228813475ad.251.2024.05.21.19.21.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 19:21:13 -0700 (PDT) Date: Tue, 21 May 2024 19:21:11 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, Bruce Richardson , Sameh Gobriel , Vladimir Medvedkin , Yipeng Wang Subject: Re: [PATCH v2] hash: provide crc32 functions based on intrinsics Message-ID: <20240521192111.3c2e9eda@hermes.local> In-Reply-To: <1716336134-27366-2-git-send-email-roretzla@linux.microsoft.com> References: <1710970127-25938-2-git-send-email-roretzla@linux.microsoft.com> <1716336134-27366-1-git-send-email-roretzla@linux.microsoft.com> <1716336134-27366-2-git-send-email-roretzla@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 21 May 2024 17:02:14 -0700 Tyler Retzlaff wrote: > MSVC does not support inline asm so replace crc32 inline function > implementations with intrinsics compatible with all toolchains. > > Signed-off-by: Tyler Retzlaff > --- always good to remove asm since in tends not to get optimized. Acked-by: Stephen Hemminger