From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABA694408D; Tue, 21 May 2024 22:15:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B06DD40C35; Tue, 21 May 2024 22:14:29 +0200 (CEST) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id 9197F406A2 for ; Tue, 21 May 2024 22:14:22 +0200 (CEST) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-1ec92e355bfso5958275ad.3 for ; Tue, 21 May 2024 13:14:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716322462; x=1716927262; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BofXLaCQzFPxNJh9822n+x8IHkD2bpi6dG3sqDlipgY=; b=i0R7RRah5ikoyh8kF1/XmB6atoYqNV2pF54n1qbVf1BieOYpZd1cduKQPU+4d4GtO4 ahJURix7fZseo+Nl7QUYGAyRtF9KTF0gMllIrmln3eALLzl7ew9hqLKqNieLXMI+y1aK HF0ZngknA23aEZQu6DuRn9ThJnL1x7oVjIoavo6DRbGy9YWPmekYpl9n5TOu4hLxjjvW FcO3vnoAAb3i+lnoePu1KpCTJH4rCELV2snEXrMUlKHETac+tStkOGjmALnmeOKSXUk+ oU4LNUJbHHTvHbo5z1nhdkUUPK8Fr8mkggsqQky/3L4FgI7PyX549HQnWFuvXfnhCs1H ZiIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716322462; x=1716927262; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BofXLaCQzFPxNJh9822n+x8IHkD2bpi6dG3sqDlipgY=; b=fr/3f/SmUOusTRlN2KN8bq+178JCKR7WPUCxOi9JHiLPD33bU+I+hW/EFR8EOjN87f w5l0t/UKHSemrMvAOyIxLw1SS0oVMPezlA+JMB6GnN6pwQVHNiVpEjjK+T5Z4rkA0LGm ykqXTwIdzTU6LBPOzU6wWobvMKsOYxv571dE7EkBoSDCD39Zibs4t+xmQuI+kd+1IgMZ JLdIYci7sp8nW5kZwx/TPQKv+UcJoN23ocNw4mNDZ9AMvp4t/REBnKuMcqq6hU1/16r/ JKQoa61Z0KBOiVK2yAzHk8UTkdFL8Jnl54MFnA+G+5Isv9cWsELcyjiW1/cE4MWExh92 x01Q== X-Gm-Message-State: AOJu0YyZABcfNCePj1eTrMoc3rSRAABzXIk+tD7DaWwCM749RdcDTK5z 1s2d6degxD+SpIWKOtnzueYRBUumGRjPNHgP2wGZBKj7VsRNFK4S7tgY4tCQ4whD0yHcMvmNpPB s X-Google-Smtp-Source: AGHT+IFFp2HT5BgRrm2TDzHfUJQuWjM/oZ7l0qwbkMpWMAHSZg37en8pETdGgUGfYc5WO8SEqP68zQ== X-Received: by 2002:a17:903:120d:b0:1f3:b0:f9ef with SMTP id d9443c01a7336-1f31c9f04f4mr46855ad.43.1716322461734; Tue, 21 May 2024 13:14:21 -0700 (PDT) Received: from hermes.lan (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f2fccc9d16sm45509895ad.31.2024.05.21.13.14.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 May 2024 13:14:21 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ferruh Yigit Subject: [PATCH v15 10/11] net/tap: remove extraneous newlines Date: Tue, 21 May 2024 13:12:55 -0700 Message-ID: <20240521201410.126116-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240521201410.126116-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240521201410.126116-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some log messages contained extra newlines. Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/tap/rte_eth_tap.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 3614aaf1dc..2484a82ccb 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -235,9 +235,8 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) flags = fcntl(fd, F_GETFL); if (flags == -1) { - TAP_LOG(WARNING, - "Unable to get %s current flags\n", - ifr.ifr_name); + TAP_LOG(WARNING, "Unable to get %s current flags: %s", + ifr.ifr_name, strerror(errno)); goto error; } @@ -279,7 +278,7 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) if (sigaction(signo, &sa, NULL) == -1) { TAP_LOG(WARNING, - "Unable to set rt-signal %d handler\n", signo); + "Unable to set rt-signal %d handler", signo); goto error; } @@ -290,11 +289,11 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive, int persistent) } if (signo == SIGRTMAX) { - TAP_LOG(WARNING, "All rt-signals are in use\n"); + TAP_LOG(WARNING, "All rt-signals are in use"); /* Disable trigger globally in case of error */ tap_trigger = 0; - TAP_LOG(NOTICE, "No Rx trigger signal available\n"); + TAP_LOG(NOTICE, "No Rx trigger signal available"); } else { /* Enable signal on file descriptor */ if (fcntl(fd, F_SETSIG, signo) < 0) { @@ -920,7 +919,7 @@ tap_mp_req_start_rxtx(const struct rte_mp_msg *request, __rte_unused const void } process_private = dev->process_private; - TAP_LOG(DEBUG, "tap_attach q:%d\n", request_param->q_count); + TAP_LOG(DEBUG, "tap_attach q:%d", request_param->q_count); for (int q = 0; q < request_param->q_count; q++) process_private->fds[q] = request->fds[q]; @@ -1463,7 +1462,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) if (ret < 0 || ret >= (int)sizeof(pool_name)) { TAP_LOG(ERR, "%s: failed to create mbuf pool name for device %s," - "device name too long or output error, ret: %d\n", + "device name too long or output error, ret: %d", pmd->name, dev->device->name, ret); return -ENAMETOOLONG; } @@ -1473,7 +1472,7 @@ tap_gso_ctx_setup(struct rte_gso_ctx *gso_ctx, struct rte_eth_dev *dev) SOCKET_ID_ANY); if (!pmd->gso_ctx_mp) { TAP_LOG(ERR, - "%s: failed to create mbuf pool for device %s\n", + "%s: failed to create mbuf pool for device %s", pmd->name, dev->device->name); return -1; } -- 2.43.0