From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43F0F4409D; Wed, 22 May 2024 21:53:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9DF1402C8; Wed, 22 May 2024 21:53:48 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id D699E400D6 for ; Wed, 22 May 2024 21:53:47 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-1f32448e8fbso7794495ad.1 for ; Wed, 22 May 2024 12:53:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1716407627; x=1717012427; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=+MFBvBXxv+1KbCvjcLXXnG3SA6FYE0Lwf80sl/3G4ss=; b=OaCUupTv0Ua+IFNfE8OtVmAH6dOT9mh3p2vPblq7S0Ea7WszcAEiZpRYnCcaDdYuU0 +ZeRBLuXzYl3nBF+F5sR/uE2msv7tFi+swTNEZYI9jJD+4LMrtsMzuYTRgvqO/oEI0cd FjvQiHXqvOm3G8G9Qfbox6Oh/yOINuFiTLcQQXbPBkQMZBRztdTlej9GisV6aZCRhyow 3iyULJi9GZARe5mosAlnMfD0uzVT+UkMwYEJXXITdynDfPhIiDqPEUFIeuB+upoXYuL7 4pHOl+BHzddt3slFm8R9f9dkxbQJQVrHF0/Z5C2ZkHxE52SBX7YrKPbxc/gfZVAI7LbF 6HLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716407627; x=1717012427; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+MFBvBXxv+1KbCvjcLXXnG3SA6FYE0Lwf80sl/3G4ss=; b=U8MI5xhoQ1pComckXUuGwoo4k/+I4tZv4z+d0UQCDdRpSnGHnmw7JVK67ut67K1/1Y 0HjPDuatD5/BvlnBb6liK/Np0QjbyhiIo13/LPMnEqev2M2s19MFacL0NH4clS3tA92P ukY/AkuzJuo0QegJbr/28ljtKJpK1rv4siUnpQrXxQMUpna3HcV8ge/7DfvCQGDfq1cZ uMrgxRaUjTrTuUa7J443HWNKdg0g9RaMjX4FdU1SCVB3mrbIRm7d2X+XHJ4VhjGySc33 6h89rTksvb9umvB4Tr0n+udinwJE+/lowi+mM5epqubflZq3VIp0EvcjY/1gi4IYCx// Xqlw== X-Gm-Message-State: AOJu0YxjB3PWzFH79Yzy9uWdLDCog8yPOKuPpDhYQo10990Ju/9HjNhX 2abrtD7kQZtxLwOUM1/oG/HCVHCe11k4dv1vFMhnwuX7/VVLwM3vS0x5XuBL2VA= X-Google-Smtp-Source: AGHT+IEzzlJR7gqPpE70G3qIimo4YbpnJMkfnNaIA4rJDcbvSyTv5i1vGzC3YEHSmwPbTUxyJk8h+g== X-Received: by 2002:a17:902:b908:b0:1f2:f497:2409 with SMTP id d9443c01a7336-1f31c978a36mr26830585ad.19.1716407626982; Wed, 22 May 2024 12:53:46 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1ef0b9d38ddsm243383275ad.47.2024.05.22.12.53.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 May 2024 12:53:46 -0700 (PDT) Date: Wed, 22 May 2024 12:53:45 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: , "Tyler Retzlaff" Subject: Re: [PATCH v9 1/8] eal: generic 64 bit counter Message-ID: <20240522125345.694d7b9f@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F48D@smartserver.smartshare.dk> References: <20240510050507.14381-1-stephen@networkplumber.org> <20240521201801.126886-1-stephen@networkplumber.org> <20240521201801.126886-2-stephen@networkplumber.org> <98CBD80474FA8B44BF855DF32C47DC35E9F488@smartserver.smartshare.dk> <20240522083309.3faa305f@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F48D@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 22 May 2024 20:09:23 +0200 Morten Br=C3=B8rup wrote: > > There are no size_bins in the current version of the patch. > > And the number of counters in ethdev part are small so it is less of a > > concern. > > The code is easier to maintain if the counter object is self contained.= =20 >=20 > I agree that there are advantages to keeping the counter object self cont= ained. >=20 > However, these counters are generic, so we cannot assume that there are o= nly very few, based on how the current software device drivers use them. >=20 > Someone might want to add size_bins to the software device drivers. > And someone else might want to collect many counters in some application = or library structure. No. The implementation should be as simple and as small as possible for the use= case that is presented in the patch series. Doing something more complex leads t= o the classic YAGNI situation, where when the new case really happens the impleme= nation just doesn't quite fit.