From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B11F7440A7;
	Thu, 23 May 2024 18:42:55 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 46953402EE;
	Thu, 23 May 2024 18:42:55 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 23912402DE
 for <dev@dpdk.org>; Thu, 23 May 2024 18:42:54 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 78D3020679DB; Thu, 23 May 2024 09:42:53 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 78D3020679DB
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1716482573;
 bh=iQjfzJMrGSy6QUswNLUXmRL5F/mPhrq6hEur1q6d1xg=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=Hql2XpJ0GD2AuXBtsdwfM9C90M2Mil1lBIRHrN7jjdaCfx6IqiOlCwJdZK28O7Fl3
 P5fqlTxgTaxVOX6XD1966eya2U9JmvuRQGRN5ARiEbggjisLq6sqSn3al70UGRne16
 FjdvWUTk2LSID0u6Ac0ysUaqcDH/kZ07z0oA23GM=
Date: Thu, 23 May 2024 09:42:53 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>,
 Zhangfei Gao <zhangfei.gao@linaro.org>, Akhil Goyal <gakhil@marvell.com>,
 Fan Zhang <fanzhang.oss@gmail.com>,
 Ashish Gupta <ashish.gupta@marvell.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver
Message-ID: <20240523164253.GA17186@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20240422143102.251-1-zhangfei.gao@linaro.org>
 <20240422143102.251-2-zhangfei.gao@linaro.org>
 <20240523092047.79bb2262@hermes.local>
 <d6404d49b88245e9ba19db8e7c8c6103@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d6404d49b88245e9ba19db8e7c8c6103@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Thu, May 23, 2024 at 04:30:30PM +0000, Konstantin Ananyev wrote:
> 
> 
> > -----Original Message-----
> > From: Stephen Hemminger <stephen@networkplumber.org>
> > Sent: Thursday, May 23, 2024 5:21 PM
> > To: Zhangfei Gao <zhangfei.gao@linaro.org>
> > Cc: Akhil Goyal <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashish.gupta@marvell.com>;
> > dev@dpdk.org
> > Subject: Re: [PATCH 1/3] compress/uadk: Introduce UADK compression driver
> > 
> > On Mon, 22 Apr 2024 14:31:00 +0000
> > Zhangfei Gao <zhangfei.gao@linaro.org> wrote:
> > 
> > > +static struct rte_compressdev_ops uadk_compress_pmd_ops = {
> > > +		.dev_configure		= NULL,
> > > +		.dev_start		= NULL,
> > > +		.dev_stop		= NULL,
> > > +		.dev_close		= NULL,
> > > +		.stats_get		= NULL,
> > > +		.stats_reset		= NULL,
> > > +		.dev_infos_get		= NULL,
> > > +		.queue_pair_setup	= NULL,
> > > +		.queue_pair_release	= NULL,
> > > +		.private_xform_create	= NULL,
> > > +		.private_xform_free	= NULL,
> > > +		.stream_create		= NULL,
> > > +		.stream_free		= NULL,
> > > +};
> > 
> > If you just used { } then all the elements are initialized to NULL anyway
> 
> Or even 
> static struct rte_compressdev_ops uadk_compress_pmd_ops;
> should do the same.

+1

>