From: Stephen Hemminger <stephen@networkplumber.org>
To: Howard Wang <howard_wang@realsil.com.cn>
Cc: <dev@dpdk.org>, Howard Wang <pro_nic_dpdk@realtek.com>
Subject: Re: [PATCH] r8126: add r8126 ethernet poll mode driver
Date: Tue, 28 May 2024 14:34:28 -0700 [thread overview]
Message-ID: <20240528143428.45a07477@hermes.local> (raw)
In-Reply-To: <20240527061347.10013-1-howard_wang@realsil.com.cn>
Went to apply this to review, and noticed that git is complains.
Looks like editor or mailer problem.
$ git am /tmp/r8126.mbox
warning: quoted CRLF detected
Applying: r8126: add r8126 ethernet poll mode driver
.git/rebase-apply/patch:71: trailing whitespace.
;
.git/rebase-apply/patch:72: trailing whitespace.
; Supported features of the 'r8126' network poll mode driver.
.git/rebase-apply/patch:73: trailing whitespace.
;
.git/rebase-apply/patch:74: trailing whitespace.
; Refer to default.ini for the full list of available PMD features.
.git/rebase-apply/patch:75: trailing whitespace.
;
warning: squelched 48 whitespace errors
warning: 53 lines add whitespace errors.
And checkpatch complains about 220 other issues.
Some are noise but most all of them look like real issues.
Please fix and resubmit.
next prev parent reply other threads:[~2024-05-28 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-27 6:13 Howard Wang
2024-05-28 21:34 ` Stephen Hemminger [this message]
2024-05-29 2:14 ` 答复: " 王颢
2024-06-13 3:39 ` [PATCH v2] " Howard Wang
2024-06-17 23:56 ` Stephen Hemminger
2024-06-18 6:50 ` 答复: " 王颢
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240528143428.45a07477@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=pro_nic_dpdk@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).