From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 45E5C440F9;
	Wed, 29 May 2024 19:56:42 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2312040273;
	Wed, 29 May 2024 19:56:42 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id 952CD4026F
 for <dev@dpdk.org>; Wed, 29 May 2024 19:56:40 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id E325620B915A; Wed, 29 May 2024 10:56:39 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com E325620B915A
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1717005399;
 bh=cvQLeDeP4LihOK+2iKez17hvJaMTmrf65kR0EOI5W0Q=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=mOfnbmatETnaHnKPnGaEr6wY/Ka7XgGIBTUw/3E++sHaBPVWlFl2Axva8+3PLLkjJ
 wHo9Il4O5lqCSwCkErkWdkZhu2mR9dRdLjNO8PjuoANAyhdn9F6W91nbp+UY3Fyrp8
 KPMdW6NP/yjgcALEhtgK1cwyYGQbLKRUr0Kxwd3g=
Date: Wed, 29 May 2024 10:56:39 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH v5 2/2] eal: initialize shared plugins on Windows
Message-ID: <20240529175639.GA22530@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1701976851-17275-1-git-send-email-roretzla@linux.microsoft.com>
 <1710262359-14217-1-git-send-email-roretzla@linux.microsoft.com>
 <1710262359-14217-3-git-send-email-roretzla@linux.microsoft.com>
 <9541360.2WqB4rESCP@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <9541360.2WqB4rESCP@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Wed, May 29, 2024 at 04:29:29PM +0200, Thomas Monjalon wrote:
> 12/03/2024 17:52, Tyler Retzlaff:
> > When EAL is built with MSVC it is possible to dynamically load plugins
> > on Windows. Hook eal_plugins_init into rte_eal_init if built with MSVC
> > and provide code to load plugins on Windows.
> > 
> > Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
> > Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> > +#ifdef RTE_EXEC_ENV_WINDOWS
> > +static void*
> > +eal_dlopen(const char *pathname)
> > +{
> 
> I'm not sure about having a Windows-specific implementation in lib/eal/common/

are you asking for the unix and windows implementations to be moved out
to eal/{windows,unix} respectively rather than the current conditional
compiled in eal/common?

> 
> Also, the CI is failing with this patchset.
> 

i'll take a look when i get a chance, you can leave it unmerged for now.