From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BA3C4408B; Fri, 31 May 2024 19:41:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8861E402D0; Fri, 31 May 2024 19:41:31 +0200 (CEST) Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by mails.dpdk.org (Postfix) with ESMTP id 0CC374027D for ; Fri, 31 May 2024 19:41:29 +0200 (CEST) Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-701b0b0be38so2177242b3a.0 for ; Fri, 31 May 2024 10:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1717177289; x=1717782089; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wGG02vXeQgxlo+hs6kxeMKWSfAWMFCXqeffcInmuvmA=; b=SfuehIA40UcBQFaBWkzvZpQ9Qshm2NB/1hPLaaX0MMXQN/nAiseMDe27EdzwGfjgGL JjtGQrYrQeu2NPfWu5ESX/FHuGV+kjCVjPYL1WkdphFfKuRxmU9G44dwPA5AlQ+ZRAKe L4x3F9fkDLWY6Hsb7y4PYaGrCJ1Hlg79OhSXhZE4ZbXez6FYaBEVt1NwTiIgkLqCubCG Ej12v1RYbuixQiKcHUKNCPRhhpMp8nKwmqo4PGY7yUxaDflFQqRLQbDgPCpSswS9ZOw+ AFyIfphhjzRr+gtc1DrE+wbxxW+Px3hCcVk5iMmYPtVCryz4GG5LGZPgsYOa8LZlubcE x6Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717177289; x=1717782089; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wGG02vXeQgxlo+hs6kxeMKWSfAWMFCXqeffcInmuvmA=; b=XHfBYIhBxZ3QOvj1LxWcz19snVFcnfEyEeoIn1tgyvx2PXlOswQ2F/sxYwcI6vS2AP DYJfG3Z8xJw7QHIcG65ciIOS3ezBjbeccvk8eq5yVZSZVKd68BKbeFGWx1H0udXR6ewr itT3k6LQyLoikU9afcHwScioBQ7X2EPTtDBsZxl8uVh5AojwFGsc5pdMNioKsTWM7pYm VQLMXf3/tN+tXDF8rZjiDh3IwA4PDD92/r24P0AbrDUIVQ+QMgUCAzBJKYxgsW4eZ1Pj Rtr6Ecfkq/IX7h2nA1iZH+gFC/xFfMbrJv+Z3kJ6tZshqbgW5u0xUWLMJFkYrlobbV7v ThgA== X-Gm-Message-State: AOJu0Ywiyl/pD5XXP3j5oAvoFa2o0nYcvmlkqi4TnAKv2vRimFIdwJs4 NDJUsz0npj5CnfJpjelwAwuIXdsbXUuvv0Rt4m17o6vE9MDsQVrus9lzw/ba6a7C3e4109Rm0bV r X-Google-Smtp-Source: AGHT+IFEU+304zK3fnBtExKDnrVPIM8cx2kf5IKY32Tz75B6ATwtX3lIJ6GOf0e7mt4j4lKaBMyYpQ== X-Received: by 2002:a05:6a00:138c:b0:702:4a0a:145a with SMTP id d2e1a72fcca58-7024a0a1d43mr2511579b3a.34.1717177288920; Fri, 31 May 2024 10:41:28 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-70251b2ecc7sm392442b3a.186.2024.05.31.10.41.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 May 2024 10:41:28 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Anatoly Burakov Subject: [PATCH] Revert "bus/vdev: fix devargs in secondary process" Date: Fri, 31 May 2024 10:41:18 -0700 Message-ID: <20240531174118.414736-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This reverts commit 6666628362c94a0b567a39a0177539c12c97d999. That commit broke use of dumpcap with vdev's and probably other uses of secondary processes with vdev as well. Bugzilla ID: 1450 Signed-off-by: Stephen Hemminger --- drivers/bus/vdev/vdev.c | 22 +--------------------- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index 14cf856237..05582f1727 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) return devargs; } -static struct rte_devargs * -vdev_devargs_lookup(const char *name) -{ - struct rte_devargs *devargs; - char dev_name[32]; - - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { - devargs->bus->parse(devargs->name, &dev_name); - if (strcmp(dev_name, name) == 0) { - VDEV_LOG(INFO, "devargs matched %s", dev_name); - return devargs; - } - } - return NULL; -} - static int insert_vdev(const char *name, const char *args, struct rte_vdev_device **p_dev, @@ -291,11 +275,7 @@ insert_vdev(const char *name, const char *args, if (name == NULL) return -EINVAL; - if (rte_eal_process_type() == RTE_PROC_PRIMARY) - devargs = alloc_devargs(name, args); - else - devargs = vdev_devargs_lookup(name); - + devargs = alloc_devargs(name, args); if (!devargs) return -ENOMEM; -- 2.43.0