From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7907544144; Mon, 3 Jun 2024 10:05:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6857342DE6; Mon, 3 Jun 2024 10:05:38 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2040.outbound.protection.outlook.com [40.107.220.40]) by mails.dpdk.org (Postfix) with ESMTP id D0ADB4026C for ; Mon, 3 Jun 2024 10:05:36 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cBf7LwYCiDVKIc2HrrYnQZW6m5rVzGIljeK/2gaaUXQLv3XSHJomBWOpovn149sRCNif5brpmJ8rOcNarQPSO8mOT43nxrQ6q+7n3MZO6nlzVzc0Q+GLTqsXuolMh2vuC065I75cVXk4GlCVe+q6Eo8n6qVt7TTs9LIicylEnuMONjjRu5gnbV5wVEcl2wSu7taa1c2g3FA+ZAObqrCf+xbxA0l55D0NABdAy7tUGWi3B1qYqQa6Xbwl8lrXTrEo5ZqyIHC6WArlbBVLjliqrljKEHABXWOXjb4GHf1narJAd4mz+dwdVgdWid1GAKAIF09CepG40xUAYmRFPiC2mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YpCSOZPVG1USBmj9oqiCWMYhRTSw3M4u605R3v7ObAg=; b=hKiBTzdV+6daJ0b/dSpwS1X6e9DlyMWjvONc12aMyXakJEfmZcYB6k7Pgj9KoiwYqflUELMBpBe+40C+tG0Gh2kfg7vkcYmlLOMZVVWXirqcW0+6mupC+CkKRx4e6q0EHTuAMbQX1tJhBvbDg6u0YJB/nPC4MvnH3oJ5Tm8729YBlADFXVpGh1TC0j1pLm+flVR9xLu+fE3/hnR7qWUCrFa65PuYSxSoGBzlMAhhPYgSXcJF/5sYhWQUi92SJyQF2yv+dJh2OG6zK/WeHeBkImgps+JTE8WeCTiqC/kAI9V+H1sykhpbYL1lVTvMTRscinIKfrXBBcj9B6qsuxR4vw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YpCSOZPVG1USBmj9oqiCWMYhRTSw3M4u605R3v7ObAg=; b=VB43suwVavIJ8oj2lDCRArquToYKMy4nXPhht4VM2aMDQyGj3CbjEmWTD9yihXMhiOnS4oTrJnW4T3hFjtj6Sg4LbSyT/rcc7rSP/ueJ4tiLjJevrqCkX0lj9FqrmPLqrIcDdjxsDRU7v8tD+hSpfIBgmtqisHCg3wx9qd/+GE5XJD3Z8Kpkbe+kjV63u5G3NT5m0d/Bz0sxgD/hM0cidLK+FSjN2Vek0f/GJ075EQrIHF1FKZgZZreb9CP+2iMK1q+XWd5HURHVCdvRJGHZMyOoftlvyOjoQyq/HCHSq5Tj0TWfSbJBkDEzU1daZZPUW5sT4BpYJ2PHNeYSLwGr/w== Received: from PH2PEPF00003858.namprd17.prod.outlook.com (2603:10b6:518:1::7a) by PH7PR12MB8827.namprd12.prod.outlook.com (2603:10b6:510:26b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.19; Mon, 3 Jun 2024 08:05:33 +0000 Received: from SJ1PEPF00002323.namprd03.prod.outlook.com (2a01:111:f403:c902::4) by PH2PEPF00003858.outlook.office365.com (2603:1036:903:48::3) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.29 via Frontend Transport; Mon, 3 Jun 2024 08:05:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF00002323.mail.protection.outlook.com (10.167.242.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 3 Jun 2024 08:05:33 +0000 Received: from drhqmail202.nvidia.com (10.126.190.181) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 3 Jun 2024 01:05:14 -0700 Received: from drhqmail201.nvidia.com (10.126.190.180) by drhqmail202.nvidia.com (10.126.190.181) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 3 Jun 2024 01:05:14 -0700 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 3 Jun 2024 01:05:12 -0700 From: Maayan Kashani To: CC: , , , "Bing Zhao" , Viacheslav Ovsiienko , "Ori Kam" , Suanming Mou , Matan Azrad Subject: [PATCH v2 06/34] net/mlx5: add dummy last action Date: Mon, 3 Jun 2024 11:04:55 +0300 Message-ID: <20240603080505.2641-2-mkashani@nvidia.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20240603080505.2641-1-mkashani@nvidia.com> References: <20240602102802.196920-1-mkashani@nvidia.com> <20240603080505.2641-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002323:EE_|PH7PR12MB8827:EE_ X-MS-Office365-Filtering-Correlation-Id: a962b577-6650-494f-4ef1-08dc83a3f17a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|36860700004|1800799015|82310400017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?5aSvyac9szOvzAxgeM38Fet7Be+v4nNN9sbWDw+xdFJnfo7ugM8j0YpmyNXh?= =?us-ascii?Q?hb9UQ1P/qEkKIgifRXcayANuNkd1ayGt+MxgYVJK89qkPZJY8OepRh9Hfb8w?= =?us-ascii?Q?/YFBQL837NjJsseNnjbL2b60d4nbVZO4ZoeSePTwM2nArYXIi1B7gW+3UGZo?= =?us-ascii?Q?z9CHfNMsLRNpF1O1bMbq/z5AwQVetp8YZFrZFEDva7c9jFcrSfiFIKkktn7+?= =?us-ascii?Q?xCi+CbBJ/30Q8Hk+gLyPaY0Z5tzwAPQZVB3XvwNv+w2kL8/a1K2Vh2vwD+m7?= =?us-ascii?Q?vG2eNb1kNpNYlrjvZo8vnWrP5TtgCFTHlUPGxXdD93of61cdo1OoJKdCw8oX?= =?us-ascii?Q?b/ChIHYUO5Fsyx07LCbO2suBvwEhuHnDwkKHAidhLOXVRw8HpOfD6CodsfjP?= =?us-ascii?Q?55VxVOMSzRtRz/dXvOx+HLaBEnVRKr392qnP82pwZz9u/3noYmcz42j0GzMV?= =?us-ascii?Q?QDfpmhuw/7LwbcMAyWo0W+FabmiRYv54aj1zTGtEMI72rLNdASi7JldBBcnh?= =?us-ascii?Q?QyAB2/v18LP/Hx7B45JfExg+AjUb7ZBl6g6FB05L9Kwmyr8m4JcpSVdHrlRN?= =?us-ascii?Q?y2X2pUuIOlGZpu07L+yR/lar5fnWZnEByHBY0DfAMw8p0K4d6bDh1AsmOT+L?= =?us-ascii?Q?bzaufoWizsVZwr4itIZ2h0SM2t+JYDWd5gOex2Rn23plmyil8HX8Hq1iJd3z?= =?us-ascii?Q?UQPKApiI1hxExk9N0J/shmNaDt20CB6A4EpEFhsatVS+lHdgsGiA+sjW6Dxg?= =?us-ascii?Q?F3P05A09yt4n/Z+AxvcC3HIEv6RbiYddQ8b9tFWb5Dpqm/9GwuAqc9K86WUH?= =?us-ascii?Q?kKh/N0kyIHLsOga4Rup2tCmp8oLEkktJJFhqvg2J6MEtZ7gKwOOUfHP+NiCn?= =?us-ascii?Q?MdyaV7FbdlxTBtFFpGiArWOyIw2ID/q6qpfE71xVFxQe6e7MG1R0M0DNEQkJ?= =?us-ascii?Q?azpk8ipYaBYt7njEmTQhqMIOtlakoSrpG9CRA4eKp/GdqTnV06A35Bj9i3t1?= =?us-ascii?Q?LACdugHfwy6wn6DOnht1u4ut/qyi4q+Pl5d1f6DtOBP57I4pJsChklhWCoWf?= =?us-ascii?Q?yPGZ0KJCSVWDdsIuverNx7oOtkw37/wPQZgUXdEO9QK46lc/yijWPw9I8yD6?= =?us-ascii?Q?pMGWwTOQK1/0gchVFxFgKKPwaeAG5+Bu5yfogr+/9Fda52Nr2VTzR5CBwnQL?= =?us-ascii?Q?r5WWpR2BbFAnkT16r+ZS/ilRrQqMsxUJiS97RxzBO4Twe2XgV/+L9TCGmSk7?= =?us-ascii?Q?A1LhDr6sdvVUp4RwyPMioeefMAxuN2daq53yYbwlSqqnoSJa6nmSQSlNIgAu?= =?us-ascii?Q?2xVdRUCvNOvACq7jBCyX97XMBqIE6bbShiQWEX86AUosV2Nlxzc5ZSUbs+Yn?= =?us-ascii?Q?rGPWpCuztYAjiTOLByUCNciOJVr6?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(1800799015)(82310400017); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 08:05:33.3844 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a962b577-6650-494f-4ef1-08dc83a3f17a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002323.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB8827 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Bing Zhao The RTE_FLOW_ACTION_TYPE_END action needs to be translated into the MLX5DR_ACTION_TYP_LAST for the future usage. It is only needed in the hardware steering backward compatible API. Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_flow_hw.c | 19 +++++++++++++++++++ 2 files changed, 20 insertions(+) diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 92ad33d486..0d30e7ab36 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -1509,6 +1509,7 @@ struct mlx5_dev_ctx_shared { /* Direct Rules tables for FDB, NIC TX+RX */ void *dr_drop_action; /* Pointer to DR drop action, any domain. */ void *pop_vlan_action; /* Pointer to DR pop VLAN action. */ + void *hw_dummy_last; /* Pointer to the DR dummy end action, any domain. */ #if defined(HAVE_IBV_FLOW_DV_SUPPORT) || !defined(HAVE_INFINIBAND_VERBS_H) struct mlx5_send_to_kernel_action send_to_kernel_action[MLX5DR_TABLE_TYPE_MAX]; #endif diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index efd2141913..015622f3bf 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -10639,6 +10639,17 @@ flow_hw_configure(struct rte_eth_dev *dev, if (ret) goto err; } + /* + * All domains will use the same dummy action, only used in the backward + * compatible API. Initialize it for only once. No order dependency. + */ + if (!priv->sh->hw_dummy_last) { + priv->sh->hw_dummy_last = mlx5dr_action_create_last(priv->dr_ctx, + MLX5DR_ACTION_FLAG_HWS_RX); + if (!priv->sh->hw_dummy_last) + /* Do not overwrite the rte_errno. */ + goto err; + } if (!priv->shared_host) flow_hw_create_send_to_kernel_actions(priv); if (port_attr->nb_conn_tracks || (host_priv && host_priv->hws_ctpool)) { @@ -10717,6 +10728,10 @@ flow_hw_configure(struct rte_eth_dev *dev, flow_hw_ct_mng_destroy(dev, priv->ct_mng); priv->ct_mng = NULL; } + if (priv->sh->hw_dummy_last) { + mlx5dr_action_destroy(priv->sh->hw_dummy_last); + priv->sh->hw_dummy_last = NULL; + } flow_hw_destroy_send_to_kernel_action(priv); flow_hw_cleanup_ctrl_fdb_tables(dev); flow_hw_free_vport_actions(priv); @@ -10832,6 +10847,10 @@ flow_hw_resource_release(struct rte_eth_dev *dev) mlx5dr_action_destroy(priv->hw_def_miss); flow_hw_destroy_nat64_actions(priv); flow_hw_destroy_vlan(dev); + if (priv->sh->hw_dummy_last) { + mlx5dr_action_destroy(priv->sh->hw_dummy_last); + priv->sh->hw_dummy_last = NULL; + } flow_hw_destroy_send_to_kernel_action(priv); flow_hw_free_vport_actions(priv); if (priv->acts_ipool) { -- 2.25.1