From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4820E44144; Mon, 3 Jun 2024 10:17:25 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 505C842E1B; Mon, 3 Jun 2024 10:17:15 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2044.outbound.protection.outlook.com [40.107.223.44]) by mails.dpdk.org (Postfix) with ESMTP id 2341D42DFF for ; Mon, 3 Jun 2024 10:17:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LMPMkXTgOE2o8mjyVSpgzbi94KUEYw6EhumfpzDlo5U0spf0KFoZANEI8v7vWOO98zKRwkeQfCuK6YbhXaoa6olZhDCxO+vHsJnpvI1neYIIZe1Up/mbDVClXwjEcAzQUnmhGwkORcQRq4zmHNKyuD44i52MvbTbV912hne77kLv70R5sCBMzKoMU1NKTUWm8CM2uh9Oow5SkOSaFHcYentkfLq832enjdJX2dPiyl/XExhJ/ixsVgzVMYLa8j2YpuLK/GbnbVUrF3sb1J5nAGLjfBRHj6nmR6kXZeNuxkn00lVJJcAzkaYfHAKw93lqwg1QB9zM4cKEWXwD0WFiDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gsKVRRNLiOB+jJ2/CRj3wwgMBGT3kE22cLMhRQmEW7k=; b=J0Jg61nM4fv29ylC5RioKve+j9gRfJrp/1eDAQuaWaPGkr0xFz/ocbPcmWYCxJXLNtenAdvGIhUne/e7GevF1ZvCp+kfgk2vV0BapgUV20LP4EDWgvlpQGNj3LhFNUEhmXsCX9D2i11GeovtUaoljNX7zopMi3mB4nVxvCh3eZlFWi2WVzxKMU9U5PSz4X4Yezj5C4SuuKFthtdQbcg4liV48otL+xKIkVrke8YjNVcwWHSK6M7xQjinb1qlV2+3Kj32+VZC/X39LEv8LkKP15OgKIf07sKomIlCKyS1qPusq9GbKz22ERQxkDG1OQtOuwAJdKharxGMohHXWD+7YA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gsKVRRNLiOB+jJ2/CRj3wwgMBGT3kE22cLMhRQmEW7k=; b=nAayAeFt1l0Rg5XWz99A0gpWr4oUTJKJt6I23zZ7VNMEgZ27AAkdGMq+kE5M5AGXMh6wmd027G5/jXMDCieGYRaQeRhgFSq06DufOS5tTH1uRHeEMtfOQv2I7p1ts3Qx+9GQoSE5JjfLHjfwVgPrnuyBgruE8j3xle0CqWgJXQZKpt+6iHrBat7CxIdNCkips6pga4FMf6gFvO61yigcdF6kxLiPeHvsKASaoN/ffU512XVVWYj8KpuIwblO1oXAC99cTFOr/GRmqx6BKREgcCqfE0veg5cfbez8e7x5AtouK8Lbxrt4j4bsYACa9d3meyh9E9xoZ+UW1giGDxVm9w== Received: from DM6PR08CA0028.namprd08.prod.outlook.com (2603:10b6:5:80::41) by CYXPR12MB9319.namprd12.prod.outlook.com (2603:10b6:930:e8::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.27; Mon, 3 Jun 2024 08:17:11 +0000 Received: from DS2PEPF0000343C.namprd02.prod.outlook.com (2603:10b6:5:80:cafe::39) by DM6PR08CA0028.outlook.office365.com (2603:10b6:5:80::41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.30 via Frontend Transport; Mon, 3 Jun 2024 08:17:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS2PEPF0000343C.mail.protection.outlook.com (10.167.18.39) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 3 Jun 2024 08:17:10 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 3 Jun 2024 01:16:59 -0700 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 3 Jun 2024 01:16:59 -0700 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 3 Jun 2024 01:16:56 -0700 From: Maayan Kashani To: CC: , , , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v2 25/34] net/mlx5: clean up TODO comments Date: Mon, 3 Jun 2024 11:16:39 +0300 Message-ID: <20240603081640.3609-4-mkashani@nvidia.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20240603081640.3609-1-mkashani@nvidia.com> References: <20240602102908.197054-1-mkashani@nvidia.com> <20240603081640.3609-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF0000343C:EE_|CYXPR12MB9319:EE_ X-MS-Office365-Filtering-Correlation-Id: 99591ba1-8c4d-48f8-1184-08dc83a5914a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|1800799015|376005|82310400017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?FSmq5jfOakEndpBcpD0ocGeQtb61JsAWWaMhRu8Vd1T//aZH2aR6qjbYD1mR?= =?us-ascii?Q?yAILe5o/3ggqrdbqopsro9fgIAl5ehFXnfx5PJ3qD62Ev6a2HknZbTd/Ln+p?= =?us-ascii?Q?6BDM/IZQsNl2PZ4Xqd7zg46mYRO+AE8J1FPn+eKvX0hohRVlAj5DNHS8oxjY?= =?us-ascii?Q?XYM6fbcjsU56jYdzVMr/jaqjPwvlE89JlA2nkBx1I761OR0noYFnTIPqUL9+?= =?us-ascii?Q?BmZB5aUsSVX3hHnfAwKPfi1M0+IsSSIM9wKuwbojkjbLOu5bBzawPIVEwdOf?= =?us-ascii?Q?EQmAtSF5sjuFvU1WmFMM9Qk81qEv2DTzYixbMuYZVQt3yahmGvT2kWVrM7Ab?= =?us-ascii?Q?0eAun1seXf0G5z9Xhc1aNzYxNIuxhYgpi++q29eR2StD/VA/Ove6ATND6vil?= =?us-ascii?Q?MmLSEajKr/h9h28GhhqgDLyvL6Ybpw5iM4XASNszg/Jaa7YX1bkwmxxW2a4d?= =?us-ascii?Q?YUrYGWVEAdvcb1qzdPaUIrQ0TXFNBE+dUMnb/FApw/RyVUgq3O1NT1tNNgRD?= =?us-ascii?Q?ki/+o5q07CVurw9h2SjdoSYPXJG20n9uFVN+gXDtd+psrsEjEpIIgoAn5qdf?= =?us-ascii?Q?8v8tjxrKZYAMLZA+BD3gFsk3q+INGcpE2JzBUOaCJl2YgCtB7A3dnDrimW1U?= =?us-ascii?Q?dRIjVRrJ4/TMSX+Zwzarh8KvqczTvX9QNsm8Smq8gFNXjzFS8X0Fl/qy75et?= =?us-ascii?Q?KJLBgS/AoGROt+ykjTAAAPeLYke7ZpBfYt7BYAAYMS5eYFVfngg1D3m3zw23?= =?us-ascii?Q?J7GHJDeY7TSC/WI233jYyPtXPYPilwA/y26LuXf1JpR2URLSRa7ZBJgmUW+2?= =?us-ascii?Q?jbTrHDIPyLcs6NBAbJCz4l8d37EXlK6CYD0MznSFkxloLVxysPzYUv3h9HnJ?= =?us-ascii?Q?jIkeLGZaoKZqTUvWoi27EoJhVExvcPmXIscN0SWKhWLKZxFN/IUNu6t/T1/j?= =?us-ascii?Q?Ptpqx+UrRMAhTrXh/awaW/+ip65k5W8PG1y8AZnazStpEmBRhqThFJm4IVZy?= =?us-ascii?Q?AB8kN/v9UzVJTXLm9kf8lpp0pcZolGynowvJVmUnLNX3U6E/WeEf1hYGai/H?= =?us-ascii?Q?T6wIFRVD9bMMGIsInI4G4mkQcv7pfEtIKOhysLK/RjeNPcn3IwVVHL2LiImd?= =?us-ascii?Q?GFdO+tvk0NL0MkkdZbxbpI/0fM8KgaQpP5tA+16fqbWT/Nvfr5L8rpavD+BQ?= =?us-ascii?Q?4UIZSSAfdP/Aj8CFixyknUYm50KsmBQBBNT+P1zoFj/F2E3U7Nax8h6sBunJ?= =?us-ascii?Q?jtheBvP4oNm2sjGnotTvek9w7yRdDRyUW1xsQgNRBWLFkgZ6+dCmL4HR74x3?= =?us-ascii?Q?M16YMUMiUa7/o8u9OS8CC+/4nrt1gZ/bUzPj8O28iGJZqi3s0yi2gCTx4SSG?= =?us-ascii?Q?wGya2WTCMZX/+6mN5UoSovqT5EWT?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(376005)(82310400017); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 08:17:10.8754 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99591ba1-8c4d-48f8-1184-08dc83a5914a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF0000343C.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9319 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org review and cleanup unneeded TODO comments. Signed-off-by: Maayan Kashani --- drivers/net/mlx5/mlx5_flow_hw.c | 32 +++++++++----------------------- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 61b6a71bbf..d9e43c25c3 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -12390,7 +12390,6 @@ static int flow_hw_prepare(struct rte_eth_dev *dev, return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "cannot allocate flow aux memory"); - /*TODO: consider if other allocation is needed for actions translate. */ return 0; } @@ -12633,9 +12632,8 @@ flow_hw_translate_flow_actions(struct rte_eth_dev *dev, table_type = MLX5DR_TABLE_TYPE_NIC_TX; else table_type = MLX5DR_TABLE_TYPE_NIC_RX; - /* TODO: consider add flag if using only non template mode to reduce table struct size. */ + /* TODO: consider to reuse the workspace per thread. */ table = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*table), 0, SOCKET_ID_ANY); - /* TODO: consider sending only relevant fields to construct. */ if (!table) return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_ACTION, actions, "Failed to allocate dummy table"); @@ -12833,9 +12831,7 @@ flow_hw_allocate_actions(struct rte_eth_dev *dev, NULL, "fail to allocate actions"); } -/* TODO: remove dev if not used */ -static int flow_hw_apply(struct rte_eth_dev *dev __rte_unused, - const struct rte_flow_item items[], +static int flow_hw_apply(const struct rte_flow_item items[], struct mlx5dr_rule_action rule_actions[], struct rte_flow_hw *flow, struct rte_flow_error *error) @@ -12901,16 +12897,7 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, .group = attr->group, .priority = attr->priority, .rss_level = 0, - /* - * TODO: currently only mlx5_flow_lacp_miss rule is relevant: - * action type=(enum rte_flow_action_type) MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS. - * I don't want to waist time going over all actions for this corner case. - * Needs to use another preparation code to update this action flags. - * if (action_type == (enum rte_flow_action_type) - * MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS) - * act_flags |= MLX5_FLOW_ACTION_DEFAULT_MISS; - */ - .act_flags = 0, /*TODO update*/ + .act_flags = action_flags, .tbl_type = 0, }; @@ -12958,11 +12945,6 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, if (ret) goto error; - /* - * TODO: check regarding release: CT index is not saved per rule, - * the index is in the conf of given action. - */ - /* * If the flow is external (from application) OR device is started, * OR mreg discover, then apply immediately. @@ -12970,7 +12952,7 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, if (external || dev->data->dev_started || (attr->group == MLX5_FLOW_MREG_CP_TABLE_GROUP && attr->priority == MLX5_FLOW_LOWEST_PRIO_INDICATOR)) { - ret = flow_hw_apply(dev, items, hw_act.rule_acts, *flow, error); + ret = flow_hw_apply(items, hw_act.rule_acts, *flow, error); if (ret) goto error; } @@ -13012,7 +12994,7 @@ flow_hw_destroy(struct rte_eth_dev *dev, struct rte_flow_hw *flow) DRV_LOG(ERR, "bwc rule destroy failed"); } flow->operation_type = MLX5_FLOW_HW_FLOW_OP_TYPE_DESTROY; - /* TODO: notice this function does not handle shared/static actions. */ + /* Notice this function does not handle shared/static actions. */ hw_cmpl_flow_update_or_destroy(dev, flow, 0, NULL); /** @@ -13108,6 +13090,10 @@ static uintptr_t flow_hw_list_create(struct rte_eth_dev *dev, uint64_t item_flags = flow_hw_matching_item_flags_get(items); uint64_t action_flags = flow_hw_action_flags_get(actions, error); + /* + * TODO: add a call to flow_hw_validate function once it exist. + * and update mlx5_flow_hw_drv_ops accordingly. + */ if (action_flags & MLX5_FLOW_ACTION_RSS) { const struct rte_flow_action_rss -- 2.25.1