From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5689644145; Mon, 3 Jun 2024 12:55:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4545742E85; Mon, 3 Jun 2024 12:55:06 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2079.outbound.protection.outlook.com [40.107.244.79]) by mails.dpdk.org (Postfix) with ESMTP id 78AD142E6E for ; Mon, 3 Jun 2024 12:55:04 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=LsVbELknxUBWDq4uzU69u6GGoWJgYBZIcUXJaiNT96FhxX7AEJvaI5dbgTCwnTCK4Clb0oqWHxcmqMzytlcLs0Sn7ds3szdGeymlHL7n0B0hHTEP5n9dOmWBakYUynu8OSfDh3dhb3r8jfoaFPH7a0YSGDe0qVSH0jwWu7HYWWSicOwOF7F6uelB5MaODsvcFDKqzMamL9mn6NW1jMWoKc30R1FgnS0tlMeGbWEp4P/sLgjnsSOIXzzt2qYyoZkB22jnxv9CC/T2/X9qHfaPBn5PPQzKWhhOr7xVhXgHXHm96Zmfy0SG8wh8rihbF6goHO6mb8T7epPp4RZi5K3cXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gsKVRRNLiOB+jJ2/CRj3wwgMBGT3kE22cLMhRQmEW7k=; b=ehZkteiIZ59DXiQKp/65mxLfYIN/bwkVxCw5KBgL1r81ovU82KlWoLl7mHFg2SM9oza1t+hnyWFpfdkE4cjRBzgDBYXcBNxN03tKjPWS61KuRVD+53xMwG1dd7JC7zMvbYgrKmqmUjMS10ODhn+RjJXjZdlJGbCTcW/tzPXFoWEZdprPSc+dtEsUyy3ttEApCSTWF0s4eHs7cwdJOaBZZtm3/D3U2PEh5n+S9kOVFNUyuwr1Gdjo6aN+JQKeY2YyYHfCwchPxikQktHDPv+osFWd2NM0/PrXZJtwaEIEN8yB7Ka6KepD0Fh8p/gEuErZi7AWKFoqG0tLqHJyQs+3Ow== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gsKVRRNLiOB+jJ2/CRj3wwgMBGT3kE22cLMhRQmEW7k=; b=HZF4CRttrf7fKknsvAso3ugX0yV+j0Woe9X2dXW20eyskagve3Ni3qB4L53fuJF6X2k7jX7e91a6cuOUXcb8AmkkSJ13RBhwcjBy456B2XmjUaat2U7idfILN8xTVuis4tts0l4pHcEtCpsslzI9y42jY6i/lii4Zc7x98Y+Osj06z9MbNtJ8KVHNSqAH9malQZs4dJTbhJTtSBQEkAId9QPsx5uyvMGOssmiTq7j/ddshqHqpGGNLUCWGaCWCdJ0QmqvF9nYt4LZAEr4aJPdrKF0uNM+A2UCBWY4V7g4G4TFvkEPgxJ5NS6suHxUyWbcvH5iMeyfKHq4qCNw62GbA== Received: from BY5PR17CA0046.namprd17.prod.outlook.com (2603:10b6:a03:167::23) by SA1PR12MB6920.namprd12.prod.outlook.com (2603:10b6:806:258::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.22; Mon, 3 Jun 2024 10:55:01 +0000 Received: from SJ1PEPF0000231F.namprd03.prod.outlook.com (2603:10b6:a03:167:cafe::30) by BY5PR17CA0046.outlook.office365.com (2603:10b6:a03:167::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.30 via Frontend Transport; Mon, 3 Jun 2024 10:55:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by SJ1PEPF0000231F.mail.protection.outlook.com (10.167.242.235) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Mon, 3 Jun 2024 10:55:00 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 3 Jun 2024 03:54:50 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Mon, 3 Jun 2024 03:54:49 -0700 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Mon, 3 Jun 2024 03:54:47 -0700 From: Maayan Kashani To: CC: , , , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v3 4/4] net/mlx5: clean up TODO comments Date: Mon, 3 Jun 2024 13:54:30 +0300 Message-ID: <20240603105430.10818-4-mkashani@nvidia.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20240603105430.10818-1-mkashani@nvidia.com> References: <20240602102908.197054-1-mkashani@nvidia.com> <20240603105430.10818-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF0000231F:EE_|SA1PR12MB6920:EE_ X-MS-Office365-Filtering-Correlation-Id: 14182c0b-20d8-488d-87c7-08dc83bb9d98 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|82310400017|36860700004; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?NeuBV2/etd1RZ66k0AAOj3ir8ce8mxaqTsw9cN1HXY4p4FZtJBNZq37EUVr5?= =?us-ascii?Q?RUKalgBh3Muyn+zM1fgGDUT15O5/2yVL6kuKBhYOVKWb3THjP3xbZ6EACDWE?= =?us-ascii?Q?tY3c2p7AW9jDTx615cVxXpZgUiKSr9TejjlBQZs/9RnZI32fYLF7njihe/8u?= =?us-ascii?Q?4+9ZbcOaQM6QNtROKldz8+qgcUgQaqLq4bxWNdKAVFXct3XN22n5m9pHCx49?= =?us-ascii?Q?5DT+OgK15PlxDGVh900AnTiL+ikDC+lU7MZNOxJugVVXaiFXNRGnnNhuPShY?= =?us-ascii?Q?DCRsbNLCXtbsMoClnz3zOj7ORnGCP8yr+WDPRbcojJcT0OBStclGQvEbW4aS?= =?us-ascii?Q?zbTLhFM4eWx05uUBpDxGcSLKRQ6durDmCdlSU8CvEBynWuAJ2qVkeBhiT2W2?= =?us-ascii?Q?moS7eanmRuPYmryFUxpkEwEmN7BKBHlfPAGY2cxtyQMqBHeqTC1fbf1i6VjP?= =?us-ascii?Q?/SEu11MWm5KlKOR3iUX6qkoTTIuZdHM7lir5Dfy6n50tKBNqwKFdbDTnl1jM?= =?us-ascii?Q?N+WZOY9tgUcpp82RU1uXNwuwXZF+VDbTbkgQFXQObHndvDu4UdYafCsiR31W?= =?us-ascii?Q?SbB5E1v9qb2A0Yf0DWM/JYbTnRNExnkCJ6KAXCfHnrrafxQkladqQvb9Aq6B?= =?us-ascii?Q?cbCdq4KNdZ2g8u9hryGCo7RZjFnB5Q10Tc103Pamj9vsvkZNXe5kIfUEQGR8?= =?us-ascii?Q?YrCiyEXHWvKbQf7B8Yxe85KLpBeSmiPYtZAFI3LMFiTZrDpLpiYz2EHL9W79?= =?us-ascii?Q?JblCHS1jKbB7DQR5zgi0dsSh2fEIXRpijsm5LGTOZFlXAX4Tdfhup/WYoM3P?= =?us-ascii?Q?a8F5Gjk91nvlE8S4jabQN0m6pXNBwncDM1Ua4iTiGzGdDGF3cYsJuLB0kHQl?= =?us-ascii?Q?yr04i+v0bB6/Ttn+em2poCvU8q4jsmZh2A/LK/0JIl0qudqvXxIEexIwzmQ+?= =?us-ascii?Q?eRdGiGMFtkIDtCr0N/f5snIksQFH/hKd0As9tIhOwCor3uYI+Y0jdDtjgd7Q?= =?us-ascii?Q?qOSjkC9k738+lTiXItEiK7B90PqZJ+qzjocBCr6MynjaR0aXpxhpkLx8CUD6?= =?us-ascii?Q?zLkrgch9BHk7kxLRUOBJBI9QOGPo2TtCNWEyPnx1d1Cgu1g2VBuTJfbYV9Z0?= =?us-ascii?Q?y0yxhQqmMhmlCnh6FDm6DHrIWs6LT31dqHo7NSUF8J9jJLEFyOdkYC202FsG?= =?us-ascii?Q?phafZZdnaACrvFM+EBVanjXpzV4FBcCDNnxXzITPGU1q09LPZ3gn7379EXzt?= =?us-ascii?Q?R2+jA/SL6TbKi1/pSVoDSBGK7AWDo4rmBqLB0zuADuNoVuYspbwnu6/5pi5X?= =?us-ascii?Q?sPRztrTyyGLcMRFPntMXt22/L9jvue7HJyv1LI/xAFc1cXd7YpnHnPLxmYu2?= =?us-ascii?Q?E5dhaCEorpV+dmmPt7rUuLJ/kHRt?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(82310400017)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jun 2024 10:55:00.5597 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 14182c0b-20d8-488d-87c7-08dc83bb9d98 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF0000231F.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB6920 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org review and cleanup unneeded TODO comments. Signed-off-by: Maayan Kashani --- drivers/net/mlx5/mlx5_flow_hw.c | 32 +++++++++----------------------- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 61b6a71bbf..d9e43c25c3 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -12390,7 +12390,6 @@ static int flow_hw_prepare(struct rte_eth_dev *dev, return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "cannot allocate flow aux memory"); - /*TODO: consider if other allocation is needed for actions translate. */ return 0; } @@ -12633,9 +12632,8 @@ flow_hw_translate_flow_actions(struct rte_eth_dev *dev, table_type = MLX5DR_TABLE_TYPE_NIC_TX; else table_type = MLX5DR_TABLE_TYPE_NIC_RX; - /* TODO: consider add flag if using only non template mode to reduce table struct size. */ + /* TODO: consider to reuse the workspace per thread. */ table = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*table), 0, SOCKET_ID_ANY); - /* TODO: consider sending only relevant fields to construct. */ if (!table) return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_ACTION, actions, "Failed to allocate dummy table"); @@ -12833,9 +12831,7 @@ flow_hw_allocate_actions(struct rte_eth_dev *dev, NULL, "fail to allocate actions"); } -/* TODO: remove dev if not used */ -static int flow_hw_apply(struct rte_eth_dev *dev __rte_unused, - const struct rte_flow_item items[], +static int flow_hw_apply(const struct rte_flow_item items[], struct mlx5dr_rule_action rule_actions[], struct rte_flow_hw *flow, struct rte_flow_error *error) @@ -12901,16 +12897,7 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, .group = attr->group, .priority = attr->priority, .rss_level = 0, - /* - * TODO: currently only mlx5_flow_lacp_miss rule is relevant: - * action type=(enum rte_flow_action_type) MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS. - * I don't want to waist time going over all actions for this corner case. - * Needs to use another preparation code to update this action flags. - * if (action_type == (enum rte_flow_action_type) - * MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS) - * act_flags |= MLX5_FLOW_ACTION_DEFAULT_MISS; - */ - .act_flags = 0, /*TODO update*/ + .act_flags = action_flags, .tbl_type = 0, }; @@ -12958,11 +12945,6 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, if (ret) goto error; - /* - * TODO: check regarding release: CT index is not saved per rule, - * the index is in the conf of given action. - */ - /* * If the flow is external (from application) OR device is started, * OR mreg discover, then apply immediately. @@ -12970,7 +12952,7 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, if (external || dev->data->dev_started || (attr->group == MLX5_FLOW_MREG_CP_TABLE_GROUP && attr->priority == MLX5_FLOW_LOWEST_PRIO_INDICATOR)) { - ret = flow_hw_apply(dev, items, hw_act.rule_acts, *flow, error); + ret = flow_hw_apply(items, hw_act.rule_acts, *flow, error); if (ret) goto error; } @@ -13012,7 +12994,7 @@ flow_hw_destroy(struct rte_eth_dev *dev, struct rte_flow_hw *flow) DRV_LOG(ERR, "bwc rule destroy failed"); } flow->operation_type = MLX5_FLOW_HW_FLOW_OP_TYPE_DESTROY; - /* TODO: notice this function does not handle shared/static actions. */ + /* Notice this function does not handle shared/static actions. */ hw_cmpl_flow_update_or_destroy(dev, flow, 0, NULL); /** @@ -13108,6 +13090,10 @@ static uintptr_t flow_hw_list_create(struct rte_eth_dev *dev, uint64_t item_flags = flow_hw_matching_item_flags_get(items); uint64_t action_flags = flow_hw_action_flags_get(actions, error); + /* + * TODO: add a call to flow_hw_validate function once it exist. + * and update mlx5_flow_hw_drv_ops accordingly. + */ if (action_flags & MLX5_FLOW_ACTION_RSS) { const struct rte_flow_action_rss -- 2.25.1