From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F4CD44173; Thu, 6 Jun 2024 12:07:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9985842D80; Thu, 6 Jun 2024 12:07:29 +0200 (CEST) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2057.outbound.protection.outlook.com [40.107.212.57]) by mails.dpdk.org (Postfix) with ESMTP id 1185042D78 for ; Thu, 6 Jun 2024 12:07:28 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZDdHG9bPc7ihBvy8B1BO59JojVOKhR4X1UC30CXXBkN9SvXjK4y3eJ4pkTfHViVR7eYYh1Xwbm0CmzTaGAfZVeiNVsv6aCB7FQZe5roUjWdOubpq9Mx+cCIiXf3kMGcyyPeJtAxVdkJE9dRj6G+RdASJufTZ+MXNKbOwWitIxGe4wQxwRTKn9810gGqdaB+URGbR6jnwg/b7EEESPA5k+j0quX2Hj/tJPP1dGSfhk/be6z6mK+4KgoHtRrx9ANETOXhjSw4RMnuza7eYcKXRg8iMswElEls9n98rQXlE9FFye3Hp8H+bAGdkKGwUWR35XZzAxBz4hIBTF2Dz38F1CQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=r09NSqK/VP+sHFllKaWjIjoLNWPPP4w5NqbvEKhO0K0=; b=cWaLWMT9XUIKWENM1ovdHlMGcvwx9BYokUAH4/BXbWs/xq8D4DRGwCHjyC0lEz9Zh52C3qQj/9B6rRF0grkcyZUPPN02q2lNrjTQA/QywUbGguSB/egkIjxum0yC1gTg2ZHiyZYVQR/844EL/bhs1e/jaQKEM5DF8i2Zaeg3RxJhpijj6ZrdJcIip8I7m5SXWK6cYG9+zBPLBMx4wpuYm89f0cY+RVlI8XFh8X3Qpggr0c1VRQIVd8B1DYa5IYwChtYmJbL2b3rDcCoOWerWA9tpfcL2k5eRXjEKnIXRX6SsCDUfnxI6o3q4XfGj+qWozVMXob15JGvdvG6xCxsg8A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=r09NSqK/VP+sHFllKaWjIjoLNWPPP4w5NqbvEKhO0K0=; b=CYsYb7nfxkyitLRw+oyhmeYjGMRJnppky8ms8+o2F/ifWQJI0hBkMcrSzORwAW2CaNyixLf5xM2Sv23wQYrc3Ec75rhc9YsVRLpHjAJf+KG06EPxVZD63BUw4Y9aPFmTmg0vKB/dA6aLyWSYGdj1wPB9XBFYNzPJsELMtgYbshWusbOx5xIryCzU76i+YvERMUSCJl+6n33TGsVu4LWTJCWzBhog3BKOYQQd72/ivQ+VDA/w5m8Z/wLpHNrPFoevBwYaHGTakImDekjPh3RkHa/mexly/wXYKDrkMb73mFfIxPpkbWlrxZ56KX6EgSHxUFfYXMD+tAw+G3wW7hIh5w== Received: from SJ0PR03CA0131.namprd03.prod.outlook.com (2603:10b6:a03:33c::16) by DS7PR12MB5719.namprd12.prod.outlook.com (2603:10b6:8:72::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.17; Thu, 6 Jun 2024 10:07:25 +0000 Received: from SJ1PEPF00002319.namprd03.prod.outlook.com (2603:10b6:a03:33c:cafe::2b) by SJ0PR03CA0131.outlook.office365.com (2603:10b6:a03:33c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.30 via Frontend Transport; Thu, 6 Jun 2024 10:07:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF00002319.mail.protection.outlook.com (10.167.242.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.15 via Frontend Transport; Thu, 6 Jun 2024 10:07:24 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 6 Jun 2024 03:07:17 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 6 Jun 2024 03:07:16 -0700 Received: from nvidia.com (10.127.8.14) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4 via Frontend Transport; Thu, 6 Jun 2024 03:07:14 -0700 From: Maayan Kashani To: CC: , , , Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad Subject: [PATCH v4 4/4] net/mlx5: clean up TODO comments Date: Thu, 6 Jun 2024 13:06:15 +0300 Message-ID: <20240606100615.171695-5-mkashani@nvidia.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20240606100615.171695-1-mkashani@nvidia.com> References: <20240603105430.10818-1-mkashani@nvidia.com> <20240606100615.171695-1-mkashani@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00002319:EE_|DS7PR12MB5719:EE_ X-MS-Office365-Filtering-Correlation-Id: 2eb26081-8dd4-467b-ee7d-08dc8610769d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|1800799015|376005|36860700004|82310400017; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?Sd0henfCWeIwCCCo/tOs3tBxaEKcZ1iZAAdJJE2yfFVm5Z5iypooNmsRdX7g?= =?us-ascii?Q?lcmsSfajPdMNxG3+kjHv3d8Dq7oQV3DX0Y1FuQiCUeDMotlAlQCyvrSeOlk7?= =?us-ascii?Q?h1MAc+pZGyn+W8nBUpQkk7pVwjtwOUMmMv+rQEw8fufS2v1bykMq+SIhgh2U?= =?us-ascii?Q?ZKHHfNm0m8eGflYD3xAEtOLMGD4Zgmwgy4pZZBTaUiexEBqdgsSnb1r2M+fc?= =?us-ascii?Q?YTbX6T3hzadR2QohchdCpnqw58Y0WD/F1Gc0hGi+Z2tbutQtENP9nBrISa4Y?= =?us-ascii?Q?dTVwUvt3flGmeb3hoc6v8nj4ze/JtmKrxi/wWb9+iNznSERyA7vnRVlekgC8?= =?us-ascii?Q?mc2Z3cz7RdTFgx9tIrqN+oEJFcOyVydBN2Zy7vVoOAPjmwNTHbdCTpU1WdH4?= =?us-ascii?Q?1/1wb4o2n/wRWJzYetEV1pZSkeglT6wKhfHLDfYmUVY/JcWbV9yVI2n86UZA?= =?us-ascii?Q?H2zb8pW2S0iyXvPwufS8lep6AJqx37Zqpneina5ny/ejQqlp5lXddxiQOAQz?= =?us-ascii?Q?1uhR8IZthAQVr7kXDWjs9ZOnV6JOl91mR0nqsbRh3HG4EcC4NSDgbNSl7v8p?= =?us-ascii?Q?LD4bvQ6sci4dj2lJocE6SRYy9fhaCC+P3Z2LI8ZoUvAy+qTKpB/zRW2kGmdQ?= =?us-ascii?Q?YW+Qkpqz3QRGp5ZIsa5AQ5P3fK/hsYcfbKzC2DS/Vp6uejhtKu19ABLFPH6u?= =?us-ascii?Q?HoMTX4cWj55t7MHm+vuWiM5Wa7rKKBobAjqzzahrXqLkjpcXYDxiArdQg6qS?= =?us-ascii?Q?tExk2txdXEughKMCa9L0A95Z8+OFvb5QsQzYezc9Zph5doAb6ElpEHcSqpxO?= =?us-ascii?Q?ZVf9+pJ1Rua5BXkSbnS81+gy067CAp/9CIbmV7kpd4LKg5uovMCl8fxcs24n?= =?us-ascii?Q?vpUiW0WY9Gw1dY5loSiJApaYFunDcQ8BkFMeQHeC+Hvg9WL17yZaBmBCVo+h?= =?us-ascii?Q?VIQYTTWliK8NVqlTI8HFVmjyPGWA2drLPxyQ0SbGwWUHwOJI3R1FLGGcgBuA?= =?us-ascii?Q?fZ9NoVlpVZvRb2DugkiHSWCxtelk55+fKejUH4MMttb5ioFri79MX+sW+rHK?= =?us-ascii?Q?4Du9DBpVk7W+EahrV3od/V+G3KAyfOoSkohnefb7U4g0wtdIZkziDOx/rRwh?= =?us-ascii?Q?SlPuZzgt/XiATFuXTCb2PpegDD1+tXdfsKIXxk+oFpbJOEX/EtQUasQVvtul?= =?us-ascii?Q?nWBjTk+nI45SRHbQVBeOe1f5VMK52+kvs4yXsP7z+jMyFPFPpwvMo0GQd1h6?= =?us-ascii?Q?ZxH+9B+LJ3+OmsXV9QJp8Q84JufN8KrSZmZgsxxCa7/76clqAnkp1bwTOx5t?= =?us-ascii?Q?6ysYnJWqAwM9BSKKWB4RE403rhIKaL27SGhiPdXoa8+9D1aXsKQMHTxMKyck?= =?us-ascii?Q?iIFlwhG48NxD3Z/rga9+IUZnia+d68fNEtyXmIzalBzqfzqbwQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230031)(1800799015)(376005)(36860700004)(82310400017); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jun 2024 10:07:24.7272 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2eb26081-8dd4-467b-ee7d-08dc8610769d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00002319.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR12MB5719 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org review and cleanup unneeded TODO comments. Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/mlx5_flow_hw.c | 32 +++++++++----------------------- 1 file changed, 9 insertions(+), 23 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 61b6a71bbf..d9e43c25c3 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -12390,7 +12390,6 @@ static int flow_hw_prepare(struct rte_eth_dev *dev, return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "cannot allocate flow aux memory"); - /*TODO: consider if other allocation is needed for actions translate. */ return 0; } @@ -12633,9 +12632,8 @@ flow_hw_translate_flow_actions(struct rte_eth_dev *dev, table_type = MLX5DR_TABLE_TYPE_NIC_TX; else table_type = MLX5DR_TABLE_TYPE_NIC_RX; - /* TODO: consider add flag if using only non template mode to reduce table struct size. */ + /* TODO: consider to reuse the workspace per thread. */ table = mlx5_malloc(MLX5_MEM_ZERO, sizeof(*table), 0, SOCKET_ID_ANY); - /* TODO: consider sending only relevant fields to construct. */ if (!table) return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_ACTION, actions, "Failed to allocate dummy table"); @@ -12833,9 +12831,7 @@ flow_hw_allocate_actions(struct rte_eth_dev *dev, NULL, "fail to allocate actions"); } -/* TODO: remove dev if not used */ -static int flow_hw_apply(struct rte_eth_dev *dev __rte_unused, - const struct rte_flow_item items[], +static int flow_hw_apply(const struct rte_flow_item items[], struct mlx5dr_rule_action rule_actions[], struct rte_flow_hw *flow, struct rte_flow_error *error) @@ -12901,16 +12897,7 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, .group = attr->group, .priority = attr->priority, .rss_level = 0, - /* - * TODO: currently only mlx5_flow_lacp_miss rule is relevant: - * action type=(enum rte_flow_action_type) MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS. - * I don't want to waist time going over all actions for this corner case. - * Needs to use another preparation code to update this action flags. - * if (action_type == (enum rte_flow_action_type) - * MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS) - * act_flags |= MLX5_FLOW_ACTION_DEFAULT_MISS; - */ - .act_flags = 0, /*TODO update*/ + .act_flags = action_flags, .tbl_type = 0, }; @@ -12958,11 +12945,6 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, if (ret) goto error; - /* - * TODO: check regarding release: CT index is not saved per rule, - * the index is in the conf of given action. - */ - /* * If the flow is external (from application) OR device is started, * OR mreg discover, then apply immediately. @@ -12970,7 +12952,7 @@ flow_hw_create_flow(struct rte_eth_dev *dev, enum mlx5_flow_type type, if (external || dev->data->dev_started || (attr->group == MLX5_FLOW_MREG_CP_TABLE_GROUP && attr->priority == MLX5_FLOW_LOWEST_PRIO_INDICATOR)) { - ret = flow_hw_apply(dev, items, hw_act.rule_acts, *flow, error); + ret = flow_hw_apply(items, hw_act.rule_acts, *flow, error); if (ret) goto error; } @@ -13012,7 +12994,7 @@ flow_hw_destroy(struct rte_eth_dev *dev, struct rte_flow_hw *flow) DRV_LOG(ERR, "bwc rule destroy failed"); } flow->operation_type = MLX5_FLOW_HW_FLOW_OP_TYPE_DESTROY; - /* TODO: notice this function does not handle shared/static actions. */ + /* Notice this function does not handle shared/static actions. */ hw_cmpl_flow_update_or_destroy(dev, flow, 0, NULL); /** @@ -13108,6 +13090,10 @@ static uintptr_t flow_hw_list_create(struct rte_eth_dev *dev, uint64_t item_flags = flow_hw_matching_item_flags_get(items); uint64_t action_flags = flow_hw_action_flags_get(actions, error); + /* + * TODO: add a call to flow_hw_validate function once it exist. + * and update mlx5_flow_hw_drv_ops accordingly. + */ if (action_flags & MLX5_FLOW_ACTION_RSS) { const struct rte_flow_action_rss -- 2.21.0