From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 58A2F4416A;
Thu, 6 Jun 2024 14:27:06 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id DD2EE402E7;
Thu, 6 Jun 2024 14:27:05 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [170.10.129.124])
by mails.dpdk.org (Postfix) with ESMTP id 510C540299
for <dev@dpdk.org>; Thu, 6 Jun 2024 14:27:05 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1717676824;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding;
bh=OUarHPZp30V6SLl8wd9ufrKd59apDwTwAB92wAmlupc=;
b=KAZ8+9DDqOHMjOuL4OoT1ISEqYStHe8XmBABCaLf/HxoV73ddYIIBkfBSXUGgwPT2VY0sl
eHL2ihFPuQeGztCxFxtGV/tIe0EGAzrfh4DS35lQyRXpFi75/sd5KUOmC3P3Ew39bWRxyD
0zyrvH0HqIAHlEOXQBry8Bq1l554X2E=
Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73])
by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,
cipher=TLS_AES_256_GCM_SHA384) id us-mta-369-ZvIAeP7tN9-VOoJR5YgM2w-1; Thu,
06 Jun 2024 08:26:59 -0400
X-MC-Unique: ZvIAeP7tN9-VOoJR5YgM2w-1
Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com
[10.11.54.10])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
(No client certificate requested)
by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C96A73C00088;
Thu, 6 Jun 2024 12:26:58 +0000 (UTC)
Received: from dmarchan.redhat.com (unknown [10.45.226.102])
by smtp.corp.redhat.com (Postfix) with ESMTP id E6010492C2C;
Thu, 6 Jun 2024 12:26:56 +0000 (UTC)
From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: stable@dpdk.org, Ciara Power <ciara.power@intel.com>,
Chengwen Feng <fengchengwen@huawei.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Shaowei Sun <1819846787@qq.com>
Subject: [PATCH] telemetry: lower log level on socket error
Date: Thu, 6 Jun 2024 14:26:54 +0200
Message-ID: <20240606122654.2889214-1-david.marchand@redhat.com>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"; x-default=true
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
When starting two DPDK programs using the same DPDK prefix (like for
example OVS and testpmd, both running as primary processes in
--in-memory mode), the first DPDK process of the two spews some error
log when the second starts:
TELEMETRY: Socket write base info to client failed
This is because telemetry init involves trying to connect on existing
sockets to check if it can take over an existing socket file.
On the other hand, this error log provides no helpful information.
Lower this log to debug level.
Fixes: e14bb5f10509 ("telemetry: fix connected clients count")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/telemetry/telemetry.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/telemetry/telemetry.c b/lib/telemetry/telemetry.c
index 1663bd8c68..509fae76ec 100644
--- a/lib/telemetry/telemetry.c
+++ b/lib/telemetry/telemetry.c
@@ -382,7 +382,7 @@ client_handler(void *sock_id)
"{\"version\":\"%s\",\"pid\":%d,\"max_output_len\":%d}",
telemetry_version, getpid(), MAX_OUTPUT_LEN);
if (write(s, info_str, strlen(info_str)) < 0) {
- TMTY_LOG_LINE(ERR, "Socket write base info to client failed");
+ TMTY_LOG_LINE(DEBUG, "Socket write base info to client failed");
goto exit;
}
--
2.44.0