From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1192F424C3; Tue, 11 Jun 2024 00:07:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A22BB402D8; Tue, 11 Jun 2024 00:07:26 +0200 (CEST) Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by mails.dpdk.org (Postfix) with ESMTP id 8F30C400D6 for ; Tue, 11 Jun 2024 00:07:25 +0200 (CEST) Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-52c8973ff29so506732e87.0 for ; Mon, 10 Jun 2024 15:07:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718057245; x=1718662045; darn=dpdk.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R8jG2/6IlEiqhTETgPN2T2NMTil3BFiED0ZmFQ1f+W4=; b=e4Sg3diUkFfv/Y7+Ii0CEpP1Zf1wgVQtvh82YleTKDNjM/mDNIXSPtN9mZI1SR8KNm zRDBrK4ke3tlbSNhJlAeoCsDHbJ2x05HiLgF+YfOiVYD2Tibo6fiKQKfhGelAg09EUmL gIPh6Qe4x2qaj7kNc5wV+gZJUz5MMHUvw+KZ5hlZ1LxyuLwPI24wqh9A9SINlfH5vIeP 25ivZmk30w8MF4pzfhTqXVDQ/cW80PBD6UytJ2OmKhipn0DZ5t5q3oGrrf9q40rZvjZ9 VyQ19rGiF1CzJI2MyTnplFQWAAn82buSy7Vo/jA59eKQ2MPzMyzLMJGyPy4MwPQy4eaK zhiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718057245; x=1718662045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=R8jG2/6IlEiqhTETgPN2T2NMTil3BFiED0ZmFQ1f+W4=; b=GGx1ejAGDX37cu8UhIrmg6h5hn8R1raZmdCHV/OUu0NzGrTueZHyojcIS/3A51DNX8 7f9YYIwDqRzjrWLFdybHItfqjUSUlLw/1EmTT5bEDzGoKb5x++P/T3Vi9N/CcxqPqArp /hY2JDZ0QNoBcP0018Go7Z5x4+nK41ZHBPkJMjvQiSUdG4X2kKd2rKxSE3BQZEHGyuIX 7mAAs4cBiYJBEFQpyr9H81XFsGk5NheLyfXMdGYErU1S1IOfnSlqfOEqHjUzhSGk10AI NpR7fNfLj0WktBHc4le1UpGxZQHEV8jbldhEBUs9tPUeUfI5E1IdDpy55Elxcuefd3OJ YR+A== X-Gm-Message-State: AOJu0YyAvfSoPrI4md/DhUJCUfXqQD+hKZTc20NarDB2afpIGxIupn74 kxN/a461fwpi8Mr6tvBOAjBDCdNlfBDUFyPGfxHNDHmTxEzsszJY X-Google-Smtp-Source: AGHT+IHdNVSbFTiu6yvK28PUv9ZfUKzhUOzRcw47qC3z5uQqhvGkwOsYrO5r1X2+JAF3yH+5ikB9rA== X-Received: by 2002:ac2:44cc:0:b0:52c:89b6:6b82 with SMTP id 2adb3069b0e04-52c89b66c37mr2476341e87.27.1718057244619; Mon, 10 Jun 2024 15:07:24 -0700 (PDT) Received: from localhost.localdomain.xyz (bba-2-50-153-135.alshamil.net.ae. [2.50.153.135]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-52bc06dad40sm1516948e87.69.2024.06.10.15.07.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Jun 2024 15:07:24 -0700 (PDT) From: mmaatuq To: Long Li Cc: dev@dpdk.org, mmaatuq Subject: [PATCH v2] net/mana: fix uninitialized scalar variable Date: Tue, 11 Jun 2024 02:07:02 +0400 Message-ID: <20240610220703.679689-1-mahmoudmatook.mm@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org in case we didn't enter or finished the loop without getting ifname we ret shouldn't have an arbitrary value. Coverity issue: 424690 Signed-off-by: mmaatuq --- v2: Fixed typo in word "arbitrary" --- drivers/net/mana/mana.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mana/mana.c b/drivers/net/mana/mana.c index 68c625258e..c37c4e3444 100644 --- a/drivers/net/mana/mana.c +++ b/drivers/net/mana/mana.c @@ -715,7 +715,7 @@ mana_dev_stats_reset(struct rte_eth_dev *dev __rte_unused) static int mana_get_ifname(const struct mana_priv *priv, char (*ifname)[IF_NAMESIZE]) { - int ret; + int ret = -ENODEV; DIR *dir; struct dirent *dent; -- 2.43.0