From: Stephen Hemminger <stephen@networkplumber.org>
To: Wathsala Vithanage <wathsala.vithanage@arm.com>
Cc: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru,
thomas@monjalon.net, ruifeng.wang@arm.com, dev@dpdk.org,
nd@arm.com
Subject: Re: [RFC] ring: remove unnecessary fences in C11 ring for performance
Date: Thu, 13 Jun 2024 08:34:46 -0700 [thread overview]
Message-ID: <20240613083446.49f659c1@hermes.local> (raw)
In-Reply-To: <20230612194716.1050379-2-wathsala.vithanage@arm.com>
On Mon, 12 Jun 2023 19:47:16 +0000
Wathsala Vithanage <wathsala.vithanage@arm.com> wrote:
> For improved performance over the current C11 based ring
> implementation, two ACQUIRE fences between the load of the old_head
> and the load of the const_tail in __rte_ring_move_prod_head and the
> load of old_head and load of the prod_tail in
> __rte_ring_move_cons_head functions have been removed. These two
> fences are not required for the safety of the ring library.
>
> Signed-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Makes sense, but needs to be rebased with current rte_thread changes.
prev parent reply other threads:[~2024-06-13 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 19:47 Wathsala Vithanage
2023-06-12 19:47 ` Wathsala Vithanage
2024-06-13 15:34 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240613083446.49f659c1@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
--cc=wathsala.vithanage@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).