From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A35B54541C; Thu, 13 Jun 2024 17:34:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A99C402F0; Thu, 13 Jun 2024 17:34:50 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id F3F88402E4 for ; Thu, 13 Jun 2024 17:34:48 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-70423e8e6c9so1037583b3a.0 for ; Thu, 13 Jun 2024 08:34:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718292888; x=1718897688; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Z3yprSDah4g7VadjmCnFuaKg5TnLae8yzzfkgNXiq4U=; b=qImk91B1HpZJluvxGGoWdIHjK5LaxjIXIELwze/1gQ50hvqQIHLPCyG38TK9++wKiw E7XTd2q3KFRf5IDjbUZUUrnbnGJtFNw2UA4csqNZF2d57x8n7AjRRu/yJaplzI42s4B6 MJ/xNUzGfZFeCz/KnRSMj0U63tHYyDEA3pBhTIL8KZaVhsbECVR0RcD5y20kySekzJub 1i4shJqN49c1tONWX5DMzzbPEzuc15r1WpOENkjYlYxMmeob+zTGhc8XdZ2LwXw8dIGD Zvcydt9Bm5f6QHnBa+adz++vjf0a1wX9dR+B3ofEJ9ro8VX0PFEWcV55QvKTIYbF8uMe yfkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718292888; x=1718897688; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z3yprSDah4g7VadjmCnFuaKg5TnLae8yzzfkgNXiq4U=; b=TbqRpCCmcbohb9llzPCJw9Y/3DniIHSYm46aim1a67pAapGG+Y45L4a2iGcJknCR/W Mx9WioKU6qBwsM7fdTQDYGY5oYkIQIPIOAIJLMTfOu3E6phqznV6DLey8wes9Pk2kxJS 8/mIKboeu8GyBItFdraPjbOWGAUsXNpclvtgFBXFxKfpFlJvjrOxTC+0eLw8MH1XYDcV QEOeGM4m/UgoRVSO0wB6N7Df8zJQOEq2iAOYjm2FEYGV0qEkk3rA7z4dLBuKT7mTJgJF XVssv2xtHzcUU0yO8vbfFvAp+fDxshf07shtIpetFh6WLt3GHLHU78jWfIr/7G+idRAR 88EQ== X-Forwarded-Encrypted: i=1; AJvYcCVlQe06sAIaZl7tl3I2ng9e2vOMxQW9NJgavymaX+msReJsrgeFV3ZJ098eI8revLaQC1JoSdCCL6FC4rI= X-Gm-Message-State: AOJu0YxHddouNCZavLoGoxcLXRivao9a01w6E8YWQLV1tFx0KOhEi3Ae p8O02UNlzpirdpY1ufKO1Ss9YXqa2MxysTjP12cGCnNaoT31+k6+EwDKr7t3piA= X-Google-Smtp-Source: AGHT+IG5SkSqOO8ElOwrju2oQMxj7r+SqRq6qJH53OoWb1RQPcWd1lQXNpQVNyCWjyb8n47/R4y/Fg== X-Received: by 2002:a05:6a00:13a8:b0:704:3a0f:1d7f with SMTP id d2e1a72fcca58-705bcedf246mr5480029b3a.31.1718292888074; Thu, 13 Jun 2024 08:34:48 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc96b665sm1464150b3a.76.2024.06.13.08.34.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 08:34:47 -0700 (PDT) Date: Thu, 13 Jun 2024 08:34:46 -0700 From: Stephen Hemminger To: Wathsala Vithanage Cc: honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru, thomas@monjalon.net, ruifeng.wang@arm.com, dev@dpdk.org, nd@arm.com Subject: Re: [RFC] ring: remove unnecessary fences in C11 ring for performance Message-ID: <20240613083446.49f659c1@hermes.local> In-Reply-To: <20230612194716.1050379-2-wathsala.vithanage@arm.com> References: <20230612194716.1050379-1-wathsala.vithanage@arm.com> <20230612194716.1050379-2-wathsala.vithanage@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 12 Jun 2023 19:47:16 +0000 Wathsala Vithanage wrote: > For improved performance over the current C11 based ring > implementation, two ACQUIRE fences between the load of the old_head > and the load of the const_tail in __rte_ring_move_prod_head and the > load of old_head and load of the prod_tail in > __rte_ring_move_cons_head functions have been removed. These two > fences are not required for the safety of the ring library. > > Signed-off-by: Wathsala Vithanage > Reviewed-by: Honnappa Nagarahalli > Reviewed-by: Ruifeng Wang Makes sense, but needs to be rebased with current rte_thread changes.