From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E978B45460; Fri, 14 Jun 2024 20:11:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D5EBE40B9A; Fri, 14 Jun 2024 20:11:36 +0200 (CEST) Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by mails.dpdk.org (Postfix) with ESMTP id 3A68240B9A for ; Fri, 14 Jun 2024 20:11:36 +0200 (CEST) Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-70417a6c328so2016509b3a.1 for ; Fri, 14 Jun 2024 11:11:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1718388695; x=1718993495; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=b79cxFy2OFtw48ic2BFZot6bd0+sUFjM2vRf70bDuG4=; b=1TyAbDbr9/5r2vrvy4fTQ6Mi1+0u4y8MVFj3zCl/F5viESauQ42yElQBPVtT5r6uUj Hb/OLf057aHOOl70Lzx07dicAt/7ErgKdn6psoPRhQfeA/ZXnkYSywAuFbcHkwreTZ0o fGj8G6oyHxN9vSFOSV6rN/zGeJeM60dY60ZaLDQRLjzs020WGmu+Ocf+uehTdnshCLjY j99dak43/AWA5l1h17qBN/sChOX4cYAQ8Y1z7nMboL8WnIkDSbkAvWJtcaUBjfL7Hiis FXy0vCCgvY+0pIugIdY91So6OX8KCXlzIbtJ3mOLBrbaDUdrBosA9iq2w5N6vmcnj5XV GnsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718388695; x=1718993495; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b79cxFy2OFtw48ic2BFZot6bd0+sUFjM2vRf70bDuG4=; b=JNuWH6Ql3/+JKcVNzRvLaKp2dkkYbYZTycoixRXjl0hrrbnVkn9qd/zltdsIboBYOn 0M36Q4yttmUFZkfG2vQW61hlCqjuTUvJlBOPHOhiaWbEStR/nOv/mA031OkuHbBP/23z Ky/4hPD/ZeJkdGOrq+1t7NlS/GqeUMQqDxXwTvzmddi4kb1jJW2hvRsL+pvg0nY5wj83 y9nDsPKiMAqzVj42p7lHho4lYfH8dp39eqDlriuV2MKNqO/kACoI6cIx5+7TGh2KVm+r lMxWZnmxzWyWaVmj5uVThQTtDnQ6cRVl7Kvjg43qvGlQzGxdjb4IO18ClEyhbNjIKtVM K+rQ== X-Forwarded-Encrypted: i=1; AJvYcCV83XrZavNG3obnz0lfVM9yv9BQvvgDRJYkWw+vL3Qt80A5SNf9NgGeiqgc9eKTu1Rw82ObwcuiCk2ZJZc= X-Gm-Message-State: AOJu0Yx1npgwXlVd8qWDIpGSsghFcrUynarI+4Bxmexcld/u63gMCsIu W7ata9zHq/g5t2g2MQsQI0949eaciF/Gsibrw74R+VKSOYUdEV7VdIxnrMkgeh8= X-Google-Smtp-Source: AGHT+IFw1YvmALnS6uiEKSQLZ7beRbelX1TfB3a3C4I3SlXrSFvN66GlUdUW44taMSHfjlRBQ+hryw== X-Received: by 2002:a05:6a20:f385:b0:1b8:4107:ce38 with SMTP id adf61e73a8af0-1bae824d386mr3096381637.49.1718388695455; Fri, 14 Jun 2024 11:11:35 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705ccb3e4e7sm3337450b3a.139.2024.06.14.11.11.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Jun 2024 11:11:35 -0700 (PDT) Date: Fri, 14 Jun 2024 11:11:33 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Ferruh Yigit" , "Sivaprasad Tummala" , , , , , Subject: Re: [PATCH v2] app/testpmd: fix lcore ID restriction Message-ID: <20240614111133.3cb31be7@hermes.local> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F523@smartserver.smartshare.dk> References: <20240415194631.124343-1-sivaprasad.tummala@amd.com> <20240416095556.173787-1-sivaprasad.tummala@amd.com> <5de50671-73b8-432d-a1a2-ce6b3120e73d@amd.com> <5a0370e4-aa42-4bc4-a5a8-34c37b88b95f@amd.com> <20240613121330.71538e19@hermes.local> <3fad191a-1402-4bb2-9992-6e2f4a50d295@amd.com> <20240614082707.3a2becec@hermes.local> <98CBD80474FA8B44BF855DF32C47DC35E9F523@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 14 Jun 2024 19:50:29 +0200 Morten Br=C3=B8rup wrote: > > > ``` > > > ../../root/dpdk/app/test-pmd/config.c: In function =20 > > 'icmp_echo_config_setup': =20 > > > ../../root/dpdk/app/test-pmd/config.c:5159:30: error: comparison =20 > > between =20 > > > signed and unsigned integer expressions [-Werror=3Dsign-compare] > > > if ((nb_txq * nb_fwd_ports) < nb_fwd_lcores) =20 > >=20 > > That does look like a compiler bug. uint16 multiplied by uint16 should > > be uint16. =20 >=20 > Not, C doesn't promote types like that. Arithmetic operations always prom= ote smaller types to int or unsigned int. And since uint16 fits in int, uin= t16 is promoted to int (not unsigned int). You are right. Long winded explanation here: https://stackoverflow.com/questions/46073295/implicit-type-promotion-rules