[PATCH] Revert "bus/vdev: fix devargs in secondary process"

[PATCH] Revert "bus/vdev: fix devargs in secondary process"

[Stephen Hemminger]

This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.

That commit broke use of dumpcap with vdev's and probably
other uses of secondary processes with vdev as well.

Bugzilla ID: 1450

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/bus/vdev/vdev.c | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c
index 14cf856237..05582f1727 100644
--- a/drivers/bus/vdev/vdev.c
+++ b/drivers/bus/vdev/vdev.c
@@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args)
 	return devargs;
 }
 
-static struct rte_devargs *
-vdev_devargs_lookup(const char *name)
-{
-	struct rte_devargs *devargs;
-	char dev_name[32];
-
-	RTE_EAL_DEVARGS_FOREACH("vdev", devargs) {
-		devargs->bus->parse(devargs->name, &dev_name);
-		if (strcmp(dev_name, name) == 0) {
-			VDEV_LOG(INFO, "devargs matched %s", dev_name);
-			return devargs;
-		}
-	}
-	return NULL;
-}
-
 static int
 insert_vdev(const char *name, const char *args,
 		struct rte_vdev_device **p_dev,
@@ -291,11 +275,7 @@ insert_vdev(const char *name, const char *args,
 	if (name == NULL)
 		return -EINVAL;
 
-	if (rte_eal_process_type() == RTE_PROC_PRIMARY)
-		devargs = alloc_devargs(name, args);
-	else
-		devargs = vdev_devargs_lookup(name);
-
+	devargs = alloc_devargs(name, args);
 	if (!devargs)
 		return -ENOMEM;
 
-- 
2.43.0

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

[Stephen Hemminger]

On Fri, 31 May 2024 10:41:18 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> 
> That commit broke use of dumpcap with vdev's and probably
> other uses of secondary processes with vdev as well.
> 
> Bugzilla ID: 1450
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Please review this. Current code is broken when using vdev's

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

[David Marchand]

On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Fri, 31 May 2024 10:41:18 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
>
> > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> >
> > That commit broke use of dumpcap with vdev's and probably
> > other uses of secondary processes with vdev as well.
> >
> > Bugzilla ID: 1450
> >
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Please review.
Thanks.


-- 
David Marchand

RE: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

[Jiang, YuX]

> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, June 18, 2024 9:06 PM
> To: Burakov, Anatoly <anatoly.burakov@intel.com>; Ye, MingjinX
> <mingjinx.ye@intel.com>
> Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>;
> Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>
> Subject: Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
> 
> On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Fri, 31 May 2024 10:41:18 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> > >
> > > That commit broke use of dumpcap with vdev's and probably other uses
> > > of secondary processes with vdev as well.
> > >
> > > Bugzilla ID: 1450
> > >
> > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> 
> Please review.
> Thanks.
> 
> 
> --
> David Marchand

Hi Stephen,
Can below patch series fix Bugzilla ID:1450? Can you have a try?
https://patchwork.dpdk.org/project/dpdk/list/?series=31507

Best regards,
Yu Jiang

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

[Stephen Hemminger]

On Wed, 19 Jun 2024 01:38:15 +0000
"Jiang, YuX" <yux.jiang@intel.com> wrote:

> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Tuesday, June 18, 2024 9:06 PM
> > To: Burakov, Anatoly <anatoly.burakov@intel.com>; Ye, MingjinX
> > <mingjinx.ye@intel.com>
> > Cc: dev@dpdk.org; Stephen Hemminger <stephen@networkplumber.org>;
> > Richardson, Bruce <bruce.richardson@intel.com>; Mcnamara, John
> > <john.mcnamara@intel.com>
> > Subject: Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"
> > 
> > On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
> > <stephen@networkplumber.org> wrote:  
> > >
> > > On Fri, 31 May 2024 10:41:18 -0700
> > > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > >  
> > > > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> > > >
> > > > That commit broke use of dumpcap with vdev's and probably other uses
> > > > of secondary processes with vdev as well.
> > > >
> > > > Bugzilla ID: 1450
> > > >
> > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> > 
> > Please review.
> > Thanks.
> > 
> > 
> > --
> > David Marchand  
> 
> Hi Stephen,
> Can below patch series fix Bugzilla ID:1450? Can you have a try?
> https://patchwork.dpdk.org/project/dpdk/list/?series=31507
> 
> Best regards,
> Yu Jiang

Yes, that fixes what I was seeing where dumpcap or pdump (secondary process)
would not start when using vdev.

Re: [PATCH] Revert "bus/vdev: fix devargs in secondary process"

[Thomas Monjalon]

19/06/2024 17:04, Stephen Hemminger:
> On Wed, 19 Jun 2024 01:38:15 +0000
> "Jiang, YuX" <yux.jiang@intel.com> wrote:
> > From: David Marchand <david.marchand@redhat.com>
> > > On Mon, Jun 17, 2024 at 4:49 PM Stephen Hemminger
> > > <stephen@networkplumber.org> wrote:  
> > > >
> > > > On Fri, 31 May 2024 10:41:18 -0700
> > > > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > > >  
> > > > > This reverts commit 6666628362c94a0b567a39a0177539c12c97d999.
> > > > >
> > > > > That commit broke use of dumpcap with vdev's and probably other uses
> > > > > of secondary processes with vdev as well.
> > > > >
> > > > > Bugzilla ID: 1450
> > > > >
> > > > > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>  
> > > 
> > > Please review.
> > > Thanks.
> > > 
> > > 
> > > --
> > > David Marchand  
> > 
> > Hi Stephen,
> > Can below patch series fix Bugzilla ID:1450? Can you have a try?
> > https://patchwork.dpdk.org/project/dpdk/list/?series=31507
> > 
> > Best regards,
> > Yu Jiang
> 
> Yes, that fixes what I was seeing where dumpcap or pdump (secondary process)
> would not start when using vdev.

Then I will prefer the revert from the original author of the regression,
with more details.